June 2017 - Koha-bugs - lists.koha-community.org

[Bug 11974] Enable non-default unix socket location for database connections.
by bugzilla-daemon＠bugs.koha-community.org 02 Jun '17

02 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11974 --- Comment #23 from Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> --- Created attachment 63940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63940&action=ed… Bug 11974 - Enable non-default unix socket location for database connections. ----------------- - BUSINESS CASE - ----------------- Currently Koha doesn't support using a non-default unix socket for database connections. Using unix sockets is generally ~20-30% faster compared to using TCP packets. Because Koha abuses the database a lot, this will make a difference. Using a non-default unix socket is useful if you want to run multiple databases (eg. mysql and mariadb) in the same OS (eg. for testing purposes). Also if one needs to move the unix socket, for example to share it between LXC containers using a shared partition, this feature might be handy. Using unix sockets for connections are faster than TCP because there is no need for TCP and IP layer packet generation. Instead applications can communicate directly without extra overhead. The benefit is marginal for a single query, around 0.5ms, but escalates linearly when hundreds of queries are performed. ------------ - SOLUTION - ------------ Mysql uses unix sockets for localhost connections only, but DBI::Mysql cannot automatically find the non-default socket path, thus it needs to be explicitly given. This patch modifies the Koha::Database->_new_schema routine to check for the presence of mysql_socket in koha-conf.xml and prioritize the socket connection. This patch works on MariaDB and Mysql and hopefully on PostgreSQL. ------------- - TEST PLAN - ------------- DEFAULT: 1. edit koha-conf.xml 1.1. put your socket path to the <socket>-attribute by default /var/run/mysqld/mysqld.sock or create the xml-entry <socket>/var/run/mysqld/mysqld.sock</socket> 2. load any koha's web-page. Shouldn't get any errors. BAD SOCKET: 1. but a bad path as your mysql_socket, eg /var/run/mysqld/mysqld.sockBADBAD 2. load any koha's web-page. It should fail due to DB connection error. Thank you for testing! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14826] Resurrect account offsets table
by bugzilla-daemon＠bugs.koha-community.org 02 Jun '17

02 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Christopher Brannon <cbrannon(a)cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon(a)cdalibrary.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8016] Items are not tie to the transaction using "global" action.
by bugzilla-daemon＠bugs.koha-community.org 02 Jun '17

02 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8016 Chris Slone <cslone(a)camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Severity|enhancement |normal CC| |cslone@camdencountylibrary. | |org --- Comment #2 from Chris Slone <cslone(a)camdencountylibrary.org> --- Hi, This is still an issue and is in need of fixing as it presents a potentially more severe problem when paying the replacement charge for an item if the item is still checked-out to the patron. So, for example, if your cronjob is set to mark an item lost and you charge patron's for lost items, using anything other than the 'pay' button will not remove the item from the patron's checkouts after the charge has been paid. To replicate: 1.) Set preference WhenLostChargeReplacementFee to 'Charge' 2.) Edit the record of a checked-out item to the lost status indicated by your DefaultLongOverdueChargeValue. Note: To keep the item checked-out, this must be done by opening and editing the item's record (not directly from the items tab of the bibliographic record). You can also use an item that your longoverdue cronjob marked. 3.) Confirm that the item is still checked-out to the patron and that the replacement fee was charged. 4.) Use pay selected, pay amount, write off, or write off all with the replacement charge and confirm the action as normal. 5.) The charge will be removed but the item will still be checked-out to the patron's record. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11176] Purchase suggestions should respect the 'active' switch on budgets
by bugzilla-daemon＠bugs.koha-community.org 02 Jun '17

02 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune(a)bulac.fr -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl
by bugzilla-daemon＠bugs.koha-community.org 02 Jun '17

02 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune(a)bulac.fr -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11974] Enable non-default unix socket location for database connections.
by bugzilla-daemon＠bugs.koha-community.org 02 Jun '17

02 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11974 Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Enable unix socket |Enable non-default unix |connections for database |socket location for |connections. |database connections. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11974] Enable unix socket connections for database connections.
by bugzilla-daemon＠bugs.koha-community.org 02 Jun '17

02 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11974 Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18721 [Bug 18721] C4::Installer uses Koha::Database instead -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11974] Enable unix socket connections for database connections.
by bugzilla-daemon＠bugs.koha-community.org 02 Jun '17

02 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11974 Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |--- Status|CLOSED |REOPENED --- Comment #22 from Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> --- Beating a dead horse which might not be dead for long. Bug 18721 refactors the installer. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 02 Jun '17

02 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #112 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Marcel de Rooy from comment #110) > And: > die "There is no valid csv profile given" unless $csv_profile; > Being liberal now. But we should actually use Koha::Exceptions now according > to a new rule in the coding guidelines. I filled new bug 18720 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 02 Jun '17

02 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18720 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18720 [Bug 18720] Get rid of "die" in favor of exceptions in C4::Acquisition::GetBasketAsCsv -- You are receiving this mail because: You are watching all bug changes.

1 0