July 2017 - Koha-bugs - lists.koha-community.org

[Bug 5471] Quotes in tags cause moderation approval/rejection to fail
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5471 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64208|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 65334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65334&action=ed… Bug 5471 - Quotes in tags fail This patch makes changes to the tag moderation template and JavaScript to fix handling of tags with double or single quotes. This patch also moves the tags moderation JavaScript out of the template and into a separate JS file. To test you should have multiple tags awaiting moderation, including tags which contain double and single quotes. - Go to Tools -> Tags. - In the list of tags pending approval, test approving and rejecting tags, including those containing single or double quotes. - The state of the "Approve" or "Reject" buttons should correctly change according to the action you chose. - The label in the status column should update correctly. - In the "Check lists" form, submitting approved, rejected, and unclassified terms should result in the correct message. Signed-off-by: Lee Jamison <ldjamison(a)marywood.edu> Works correctly based on test plan. Tested using single- and double-quoted tags. Passes QA Tools. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5471] Quotes in tags cause moderation approval/rejection to fail
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5471 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15140] Add MARC21 776 to OPAC and staff display
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers(a)biblibre.co | |m --- Comment #31 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 30 Jul '17

30 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #36 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65325&action=ed… Bug 14385: Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 30 Jul '17

30 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #35 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65324&action=ed… Bug 14385: Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 30 Jul '17

30 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #34 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65323&action=ed… Bug 14385: Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 30 Jul '17

30 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #33 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65322&action=ed… Bug 14385: Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 30 Jul '17

30 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #32 from M. Tompsett <mtompset(a)hotmail.com> --- Good progress. Just need to finalize testing the C4/Search.pm changes. Here is the test plan thus far. prove -v t/db_dependent/Items.t C4::Biblio changes (EmbedItemsInMarcBiblio) tested C4::Items changes (GetHiddentItemnumbers) tested the Items.t is tested itself too. perldoc C4::Items /PERLDOC -- finds changes installer/data/mysql/atomicupdate/bug_14385-add_OpacHiddenItemsExceptions_syspref.sql koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref -- run an upgrade -- log in to staff client -- home -> koha administration -> global system preferences -> opac -- should be an added OpacHiddenItemsExceptions under OpacHiddenItems in the Policy section. -- should be able to save various values. installer/data/mysql/sysprefs.sql -- drop the db -- create the db -- fresh install -- log in to staff client -- home -> koha administration -> global system preferences -> opac -- should be an added OpacHiddenItemsExceptions under OpacHiddenItems in the Policy section. -- should be able to save various values. opac/opac-search.pl -- set the OpacHiddenItems to "itype: [BK]" -- set the OpacHiddenItemsExceptions to "S" -- make sure to catalogue at least two books, since you dropped everything. -- Adding from Z39.50 is easiest. -- do a full reindex -- in the OPAC, search for "itype:BK" -- there should be nothing found. -- log in as the superlibrarian (which you probably set to S for staff) -- in the OPAC, search for "itype:BK" -- there should be two entries -- change OpacHiddenItemsExceptions to "PT" (because your superlibrarian is probably S and not PT) -- in the OPAC, search for "itype:BK" -- there should be nothing found. opac/opac-detail.pl -- As you know there are two books, try a direct URL: {OPACBaseURL}/opac-detail.pl?biblionumber=1 -- it should return a 404 page -- change OpacHiddenItemsExceptions back to "S" -- try the direct URL again. -- it should show up. opac/opac-MARCdetail.pl -- change the OpacHiddenItemsExceptions back to "PT" -- try a direct URL: {OPACBaseURL}/opac-MARCdetail.pl?biblionumber=1 -- it should return a 404 page -- change OpacHiddenItemsExceptions back to "S" -- try the direct URL again. -- it should show up. opac/opac-ISBDdetail.pl -- change the OpacHiddenItemsExceptions back to "PT" -- try a direct URL: {OPACBaseURL}/opac-ISBDdetail.pl?biblionumber=1 -- it should return a 404 page -- change OpacHiddenItemsExceptions back to "S" -- try the direct URL again. -- it should show up. prove -v t/db_dependent/Search.t the Search.t itself is proved. catalogue/search.pl -- Log in to the staff client -- search for "itype:BK" -- two results -- change OpacHiddenItemsExceptions and OpacHiddenItems as desired -- two results all the time, because this is the staff client! cataloguing/addbooks.pl -- Make sure you have records in the cataloguing reservoir This is done by staging at least one MARC record. -- In the staff client, home -> Cataloguing -> Cataloguing search -- Search for something that will find some records in the reservoir -- Make sure results are expected regardless of hidden item system preferences. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 29 Jul '17

29 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #31 from M. Tompsett <mtompset(a)hotmail.com> --- Perhaps when I have a more solid block of time, I'll be able to debug why the opac search results give links to the staff client. DOH! Still things to fix. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18998] New: Searching capability dies every few days - Zebra problem?
by bugzilla-daemon＠bugs.koha-community.org 28 Jul '17

28 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18998 Bug ID: 18998 Summary: Searching capability dies every few days - Zebra problem? Change sponsored?: --- Product: Koha Version: 17.05 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: wyneken(a)physik.uni-freiburg.de QA Contact: testopia(a)bugs.koha-community.org I'm running Koha version 17.05.01 on Debian 8.8. I set up Koha a few months ago and we're still learning the system. One thing we've noticed that presumably is not normal is that after a few days, for some reason the searching capability dies. My guess is that it has something to do with Zebra. I can get search back up and going by restarting Koha. I use "invoke-rc.d koha-common restart". Presumably some daemon or other dies but I haven't been able to figure out which one. Maybe it happens during the regular cronjobs? Does anybody have any ideas how I can figure out what's happening? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3