August 2017 - Koha-bugs - lists.koha-community.org

[Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '17

19 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946 --- Comment #6 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Marc Véron from comment #5) > Still valid? While working on Bug 14385, I think I saw code that was not copied between various opac/opac-###detail.pl files. I think this may still be valid. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '17

19 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #103 from M. Tompsett <mtompset(a)hotmail.com> --- Comment 51 and 58 constitute the most recent test plan. A more complete single one to come soon. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '17

18 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #102 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 66210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66210&action=ed… Bug 14385: Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '17

18 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #101 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 66209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66209&action=ed… Bug 14385: Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '17

18 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #100 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 66208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66208&action=ed… Bug 14385: Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '17

18 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #99 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 66207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66207&action=ed… Bug 14385: Add missing test to trigger Koha/BiblioUtils/Iterator change -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '17

18 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #98 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 66206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66206&action=ed… Bug 14385: Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '17

18 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #97 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 66205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66205&action=ed… Bug 14385: Refactor EmbedItemsInMarcBiblio parameters to hashref -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '17

18 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #96 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 66204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66204&action=ed… Bug 14385: Add some commenting to make sense of logic -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '17

18 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #95 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 66203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66203&action=ed… Bug 14385: Fix QA Test tool failures C4/Search.pm had some tabs. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0