August 2017 - Koha-bugs - lists.koha-community.org

[Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '17

14 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65541|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 65950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65950&action=ed… Bug 10306: Add tests for module changes GetMarcSubfieldStructure: In Biblio.t we are adding a subtest that checks the structure returned by this routine. Is it a hashref pointing to arrayrefs of hashrefs? ;) In Search.t this routine was mocked. The change in the returned structure is now applied to this mock too (moving the marc tag hashes into arrayrefs). GetMarcFromKohaField: In Biblio.t we add a subtest for it. We are checking if it returns multiple mappings (per kohafield) and calling it in scalar context too. GetMarcSubfieldStructureFromKohaField: The existing subtest in Biblio.t is expanded to also test the call in list context. TransformKohaToMarc: This sub has its own test script. We are adding a subtest in TransformKohaToMarc.t for a test with multiple mappings, and for mapping to a control field in another framework. This also tests the additional framework parameter. Additionally, we add a test for the new no_split option used for items. TransformMarcToKoha: This implicitly tests its helper sub _get_inverted. This patch adds a new test script for this routine. TransformMarcToKohaOneField: A few tests are added to the previous new test script. Test plan: [1] Run t/db_dependent/Biblio.t [2] Run t/db_dependent/Biblio/TransformKohaToMarc.t [3] Run t/db_dependent/Biblio/TransformMarcToKoha.t [4] Run t/db_dependent/Search.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '17

14 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65540|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 65949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65949&action=ed… Bug 10306: Allow controlfields in TransformKohaToMarc Since the interface allows you to connect a kohafield to a MARC controlfield, this routine should be able to handle that. Unfortunately it did not. Test plan: Change will be tested in Biblio/TransformKohaToMarc.t in the next patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '17

14 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #28 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 65948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65948&action=ed… Bug 10306: Core module changes for multiple mappings In order to allow multiple Koha to MARC mappings (for one kohafield), we need to adjust a few key routines in C4/Biblio.pm. This results in a few changes in dependent modules too. Note: Multiple mappings also include 'alternating' mappings. Such as the case of MARC21 260 and 264: only one of both fields will be used. Sub TransformMarcToKoha will handle that just fine; the opposite transformation is harder, since we do no longer know which field was the source. In that case TransformKohaToMarc will fill both fields. We only use that operation in Koha for items (in Acquisition and Cataloging). Sub GetMarcSubfieldStructure This sub used a selectall_hashref, which is fine as long as we have only one mapping for each kohafield. But as DBI states it: If a row has the same key as an earlier row then it replaces the earlier row. In other words, we lose the first mapping if we have two. This patch uses selectall_arrayref with Slice and rearranges the output so that the returned hash returns an arrayref of hashrefs for each kohafield. In order to improve consistency, we add an order clause to the SQL statement used too. Sub GetMarcFromKohaField This sub just returned one tag and subfield, but in case of multiple mappings we should return them all now. Note: Many calls still expect just one result and will work just fine: my ($tag, $sub) = GetMarcFromKohaField(...) A possible second mapping would be silently ignored. Often the sub is called for biblionumber or itemnumber. I would not recommend the use of multiple mappings for such fields btw. In case the sub is called in scalar context, it will return only the first tag (instead of the number of tags and subfields). Sub GetMarcSubfieldStructureFromKohaField This sub previously returned the hash for one kohafield. In scalar context it will behave like before: it returns the first hashref in the arrayref that comes from GetMarcSubfieldStructure. In list context, it returns an array of all hashrefs (incl. multiple mappings). The sub is not used in C4::Ris. Removed the use statement. Sub TransformKohaToMarc This sub got a second parameter: frameworkcode. Historically, Koha more or less assumes kohafields to be defined across all frameworks (see Koha to MARC mappings). Therefore it falls back to Default when it is not passed. When going thru all mappings in building a MARC record, it also supports multiple mappings. Note that Koha uses this routine in Acquisition and in Cataloging for items. Normally the MARC record is leading however and the Koha fields are derivatives for optimization and reporting. The added third parameter allows for passing a new option no_split => 1. We use this option in C4::Items::Item2Marc; if two item fields are mapped to one kohafield but would have different values (which would be very unusual), these values are glued together. When transforming to MARC again, we do not want to duplicate the item subfields, but we keep the glued value in both subfields. This operation only affects items, since we are not doing this reverse operation for biblio and biblioitem fields. Sub _get_inverted_marc_field_map This sub is a helper routine of TransformMarcToKoha, the opposite transformation. When saving a MARC record, all kohafields are extracted including multiple mappings. Suppose that you had both 260c and 264c in your record (which you won't), than both values get saved initially into copyrightdate like A | B. The additional code for copyrightdate will extract the first year from this string. A small fix in TransformMarcToKoha makes that it only saves a value in a kohafield if it is defined and not empty. (Same for concatenation.) Sub TransformMarcToKohaOneField This sub now just calls TransformMarcToKoha and extracts the requested field. Note that since we are caching the structure, this does not result in additional database access and is therefore performance-wise insignificant. We simplify code and maintenance. Instead of modifying the passed hashref, it simply returns a value. A call in C4::Breeding is adjusted accordingly. The routine getKohaField in Koha::MetadataRecord is redirected to TransformMarcToKohaOneField. NOTE: The fourth patch restructures/optimizes TransformMarcToKoha[OneField]. Sub get_koha_field_from_marc This sub can be removed. A call is replaced by TransformMarcToKohaOneField in C4::XISBN. Note: The commented lines for sub ModZebrafiles are removed (directly under TransformMarcToKohaOneField). Test plan: For unit tests and interface tests, please see follow-ups. Run qa tools in order to verify that the modules still compile well. Read the code changes and verify that they make sense. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '17

14 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow multiple Koha to Marc |Koha to MARC mappings (Part |mappings (say publication |1): Allow multiple mappings |info in MARC21 260 or RDA |per kohafield (for say |264) |260/RDA 264) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19094] New: +61-1800-059-007 Avg aℕtivirus tℯch suppℴrt phℴℕℯ ℕumbℯr Avg aℕtivirus tℯchℕical suppℴrt ℕumbℯrdfgfdgdf
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '17

14 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19094 Bug ID: 19094 Summary: +61-1800-059-007 Avg aℕtivirus tℯch suppℴrt phℴℕℯ ℕumbℯr Avg aℕtivirus tℯchℕical suppℴrt ℕumbℯrdfgfdgdf Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcxmgjhkw(a)mailtraps.com QA Contact: testopia(a)bugs.koha-community.org Avg aℕtivirus tℴll frℯℯ ℕumbℯr iℕ usa Avg aℕtivirus cℴℕtact phℴℕℯ ℕumbℯr Avg aℕtivirus tℯchℕical suppℴrt Avg aℕtivirus custℴmℯr suppℴrt tℯlℯphℴℕℯ Avg aℕtivirus Avg tℯch suppℴrt phℴℕℯ ℕumbℯr Avg aℕtivirus custℴmℯr sℯrvicℯ Avg tℯchℕical suppℴrt phℴℕℯ ℕumbℯr Avg custℴmℯr sℯrvicℯ suppℴrt Avg custℴmℯr sℯrvicℯ ℯmail addrℯss Avg custℴmℯr sℯrvicℯ rℯviℯws cℴℕtact Avg custℴmℯr sℯrvicℯ Avg tℯch suppℴrt ℕumbℯr usa Avg aℕtivirus cℴℕtact ℕumbℯr Avg tℯchℕical suppℴrt usa Avg tℯchℕical suppℴrt ℕumbℯr Avg tℯch suppℴrt phℴℕℯ Avg tℯch suppℴrt ℕumbℯr Avg custℴmℯr sℯrvicℯ tℯlℯphℴℕℯ ℕumbℯr Avg aℕtivirus custℴmℯr suppℴrt ℕumbℯr Avg iℕtℯrℕℯt sℯcurity tℯchℕical suppℴrt Avg aℕtivirus custℴmℯr suppℴrt phℴℕℯ ℕumbℯr Avg aℕtivirus custℴmℯr sℯrvicℯ phℴℕℯ ℕumbℯr Avg aℕtivirus custℴmℯr suppℴrt ℕumbℯr Avg aℕtivirus custℴmℯr sℯrvicℯ ℕumbℯr phℴℕℯ ℕumbℯr fℴr Avg aℕtivirus custℴmℯr sℯrvicℯ Avg aℕtivirus custℴmℯr suppℴrt Avg aℕtivirus custℴmℯr sℯrvicℯ phℴℕℯ ℕumbℯr us Avg aℕtivirus phℴℕℯ ℕumbℯr custℴmℯr sℯrvicℯ us phℴℕℯ ℕumbℯr Avg aℕtivirus custℴmℯr sℯrvicℯ Avg aℕtivirus phℴℕℯ ℕumbℯr custℴmℯr sℯrvicℯ custℴmℯr sℯrvicℯ ℕumbℯr fℴr Avg aℕtivirus Avg aℕtivirus custℴmℯr sℯrvicℯ phℴℕℯ Avg tℯch suppℴrt phℴℕℯ ℕumbℯr us Avg tℯch suppℴrt ℕumbℯr Avg custℴmℯr suppℴrt phℴℕℯ ℕumbℯr Avg custℴmℯr sℯrvicℯ phℴℕℯ ℕumbℯr Avg phℴℕℯ ℕumbℯr custℴmℯr sℯrvicℯ Avg sℯcurity phℴℕℯ ℕumbℯr custℴmℯr sℯrvicℯ phℴℕℯ ℕumbℯr fℴr Avg custℴmℯr sℯrvicℯ Avg custℴmℯr sℯrvicℯ phℴℕℯ ℕumbℯr Avg iℕtℯrℕℯt sℯcurity custℴmℯr sℯrvicℯ phℴℕℯ ℕumbℯr Avg custℴmℯr sℯrvicℯ phℴℕℯ ℕumbℯrs Avg sℯcurity custℴmℯr sℯrvicℯ phℴℕℯ ℕumbℯr Avg phℴℕℯ ℕumbℯr custℴmℯr suppℴrt phℴℕℯ ℕumbℯr fℴr Avg custℴmℯr suppℴrt Avg suppℴrt phℴℕℯ ℕumbℯr Avg tℯlℯphℴℕℯ suppℴrt ℕumbℯr Avg aℕtivirus custℴmℯr sℯrvicℯ tℯlℯphℴℕℯ ℕumbℯr Avg aℕtivirus tℴll frℯℯ custℴmℯr carℯ ℕumbℯr Avg tℯchℕical suppℴrt ℕumbℯr Avg suppℴrt phℴℕℯ ℕumbℯr Avg custℴmℯr suppℴrt phℴℕℯ ℕumbℯr Avg aℕtivirus tℯchℕical suppℴrt phℴℕℯ ℕumbℯr phℴℕℯ ℕumbℯr fℴr Avg tℯchℕical suppℴrt Avg custℴmℯr sℯrvicℯ phℴℕℯ ℕumbℯr usa Avg custℴmℯr sℯrvicℯ ℕumbℯr Avg tℯchℕical suppℴrt ℕumbℯr usa Avg custℴmℯr suppℴrt ℕumbℯr Avg tℯch suppℴrt ℕumbℯr phℴℕℯ ℕumbℯr fℴr Avg suppℴrt Avg suppℴrt phℴℕℯ ℕumbℯr usa Avg phℴℕℯ ℕumbℯr custℴmℯr sℯrvicℯ Avg phℴℕℯ ℕumbℯr tℯch suppℴrt Avg hℯlp phℴℕℯ ℕumbℯr Avg hℯlp dℯsk phℴℕℯ ℕumbℯr Avg phℴℕℯ ℕumbℯr usa Avg cℴℕtact phℴℕℯ ℕumbℯr usa Avg cℴℕtact phℴℕℯ ℕumbℯr custℴmℯr sℯrvicℯ Avg phℴℕℯ ℕumbℯr what is thℯ phℴℕℯ ℕumbℯr fℴr Avg custℴmℯr sℯrvicℯ Avg gℴld suppℴrt phℴℕℯ ℕumbℯr Avg phℴℕℯ ℕumbℯr suppℴrt Avg sℯcurity phℴℕℯ ℕumbℯr Avg custℴmℯr sℯrvicℯ ℕumbℯr usa Avg cℴℕtact ℕumbℯr usa Avg usa phℴℕℯ ℕumbℯr Avg suppℴrt ℕumbℯr usa Avg tℯch suppℴrt ℕumbℯr usa Avg phℴℕℯ ℕumbℯr custℴmℯr sℯrvicℯ Avg phℴℕℯ ℕumbℯrs custℴmℯr suppℴrt Avg phℴℕℯ suppℴrt ℕumbℯr Avg suppℴrt cℴℕtact ℕumbℯr Avg suppℴrt ℯmail addrℯss Avg suppℴrt tℯlℯphℴℕℯ ℕumbℯr Avg aℕtivirus custℴmℯr carℯ Avg custℴmℯr carℯ tchℕical suppℴrt Avg custℴmℯr carℯ ℕumbℯr usa tℴll frℯℯ Avg custℴmℯr carℯ usa Avg usa custℴmℯr carℯ fℴr tℯch suppℴrt phℴℕℯ ℕumbℯr fℴrAvg custℴmℯr sℯrvicℯ phℴℕℯ ℕumbℯr fℴrAvg custℴmℯr suppℴrt Avg tℯchℕical suppℴrt phℴℕℯ ℕumbℯr usa phℴℕℯ ℕumbℯr fℴrAvg tℯchℕical suppℴrt Avg aℕtivirus hℯlpliℕℯ ℕumbℯr phℴℕℯ ℕumbℯr fℴrAvg tℯch suppℴrt Avg aℕtivirus tℴll frℯℯ ℕumbℯr Avg custℴmℯr suppℴrt phℴℕℯ ℕumbℯr tℯlℯphℴℕℯ ℕumbℯr fℴrAvg tℯchℕical suppℴrt Avg aℕtivirus hℯlp phℴℕℯ ℕumbℯr Avg phℴℕℯ ℕumbℯr tℯchℕical suppℴrt Avg aℕtivirus phℴℕℯ ℕumbℯr usa Avg phℴℕℯ ℕumbℯr suppℴrt Avg aℕtivirus suppℴrt tℯlℯphℴℕℯ ℕumbℯr Avg aℕtivirus phℴℕℯ suppℴrt Avg aℕtivirus tℯchℕical suppℴrt custℴmℯr carℯ ℕumbℯr Avg aℕtivirus tℯchℕical suppℴrt Phℴℕℯ ℕumbℯr iℕ usa Avg aℕtivirus tℯchℕical suppℴrt ℯmail addrℯss Avg aℕtivirus custℴmℯr suppℴrt phℴℕℯ ℕumbℯr Avg ℕtivirus cℴℕtact phℴℕℯ ℕumbℯr fℴr usa Avg aℕtivirus tℯchℕical suppℴrt cℴℕtact ℕumbℯr Avg aℕtivirus tℯchℕical suppℴrt chat Avg aℕtivirus tℴll frℯℯ ℕumbℯr Avg tℯchℕical suppℴrt phℴℕℯ ℕumbℯr Avg aℕtivirus tℯchℕical suppℴrt hℯlp dℯsk phℴℕℯ ℕumbℯr Avg tℯchℕical suppℴrt ℕumbℯr tℴll frℯℯ ℕumbℯr Avg tℯchℕical suppℴrt phℴℕℯ ℕumbℯr https://en.vikidia.org/wiki/SECURE_PC_%2B61-18%C3%94%C3%94-%C3%9459-%C3%94%… https://en.vikidia.org/wiki/!!!UPDATE_Avg_!!!@@_%2B61-1800-059-007_Avg_a%E2… https://en.vikidia.org/wiki/Kuku_avg_%2B61-1800-059-007_Avg_a%E2%84%95tivir… https://en.vikidia.org/wiki/%2B61-1800-059-007_Avg_a%E2%84%95tivirus_t%E2%8… http://virustechsupportmilttt.blogspot.in/2017/08/vbcxbcvcxvbb.html https://jinggggstechsupport.wordpress.com/2017/08/14/avg-tℯch-suppℴrt-ℕumbℯ… Avg aℕtivirus custℴmℯr suppℴrt phℴℕℯ ℕumbℯr Avg aℕtivirus custℴmℯr sℯrvicℯ phℴℕℯ ℕumbℯr Avg aℕtivirus custℴmℯr suppℴrt phℴℕℯ ℕumbℯr Avg aℕtivirus custℴmℯr sℯrvicℯ phℴℕℯ ℕumbℯr phℴℕℯ ℕumbℯr fℴr Avg aℕtivirus custℴmℯr sℯrvicℯ cℴℕtact Avg aℕtivirus custℴmℯr sℯrvicℯ phℴℕℯ ℕumbℯr Avg symaℕtℯc suppℴrt phℴℕℯ ℕumbℯr Avg symaℕtℯc custℴmℯr sℯrvicℯ phℴℕℯ ℕumbℯr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 10306] Allow multiple Koha to Marc mappings ( say publication info in MARC21 260 or RDA 264)
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '17

14 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19097 Blocks| |19096 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096 [Bug 19096] Koha to MARC mappings Part 2 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19092] New: da
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '17

13 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19092 Bug ID: 19092 Summary: da Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs(a)lists.koha-community.org Reporter: davelopers.anime21(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 65944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65944&action=ed… daw ad -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 14803] Rental and fine fees are not updating on circulation screen
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '17

13 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #46 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Christopher, is the amount outstanding on top updated immediately with the checkout? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19090] New: Hacked By KingSkrupellos Cyberizm.Org Digital Security Technological Turkish Moslem Army
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '17

13 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19090 Bug ID: 19090 Summary: Hacked By KingSkrupellos Cyberizm.Org Digital Security Technological Turkish Moslem Army Change sponsored?: --- Product: Koha Version: 17.05 Hardware: Other OS: Mac OS Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: k1ngskrup3ll0s(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Created attachment 65937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65937&action=ed… Hacked By KingSkrupellos Cyberizm.Org Digital Security Technological Turkish Moslem Army Hacked By KingSkrupellos Cyberizm.Org Digital Security Technological Turkish Moslem Army -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 14803] Rental and fine fees are not updating on circulation screen
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '17

12 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #45 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- Testing at Koha US on master. The process seems to work fine without the patch. Is this still needed??? -- You are receiving this mail because: You are watching all bug changes.

1 0