August 2017 - Koha-bugs - lists.koha-community.org

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '17

03 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #58 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 65471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65471&action=ed… Bug 7317: Add date requested to OPAC requests table. * koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt: Add request.placed to requests output table. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '17

03 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #57 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 65470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65470&action=ed… Bug 7317: Switch to borrowername from borrowernumber -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '17

03 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63475|0 |1 is obsolete| | --- Comment #56 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 65469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65469&action=ed… Bug 7317: Bugfix: remove `my` statements & dereference. * Koha/Illrequest.pm (available_backends): Remove incorrect `my` statements for @backends variable. (custom_capability): Explicitly dereference `$self->capabilities`. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '17

03 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard <oleonard(a)myacpl.org> --- In my test I set the hold limit for DVDs to 10, and the "Maximum total holds allowed (count)" for patron type "Juvenile" to 5. I placed holds for a patron with that patron category until the number exceeded 5 and then exceeded 10. Neither hold limit appears to be working. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '17

03 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #53 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Pete Edwards from comment #51) > OK - I see the point about most of my question and will raise it on devel. > But, isn't this the correct place to point out when a patch causes a > regression problem. It is breaking an existing API. The codebase is moving very fast, the legacy code is removed and replaced with oop. Since the community is not maintaining the plugins and some are not publicly released, it is hard to know what changes will break something. I guess the answer would be to suggest plugin's authors to write tests in order to catch these regressions and then to provide a new version of the plugin. Another answer would be to contribute to the codebase instead of writing plugins ;) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '17

03 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #52 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Pete Edwards from comment #51) > OK - I see the point about most of my question and will raise it on devel. > But, isn't this the correct place to point out when a patch causes a > regression problem. It is breaking an existing API. There are a couple options for you on this issue: - File a bug explaining the regression and requesting it to be fixed. You need to set the 'depends on' field to this bug number. Beware that others migt consider the change is ok and close the bug as WORKSFORME. API changes are not usually considered a bug, but an enhancement. But this is just a matter of discussing (dis)advantages and reaching a middle ground. If there's a regression it is always a good practice to provide a regression test patch. - Comment on koha-devel the 'general' situation, in which there's an API change that should be better explained on the release notes. Which I would agree with BTW. Looking forward to this discussion! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '17

03 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #51 from Pete Edwards <koha(a)jsense.co.uk> --- OK - I see the point about most of my question and will raise it on devel. But, isn't this the correct place to point out when a patch causes a regression problem. It is breaking an existing API. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '17

03 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17438 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '17

03 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #50 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Pete Edwards from comment #49) > Thanks for the responses but I don't think you quite understood my point. I > only gave the specific instance as an example of someone else who would be > affected by this patch but I don't use that one. > > I have written a plugin myself that is now broken because of this change. > How does a plugin author find out when you may a change to koha that breaks > plugins? I am saying that both the internal assumptions made in this patch > and the types of input and output parameters have changed so all plugins > using the to_marc method will have broken. I didn't see anything in the > release notes notifying people that there was an API change. So this is a development/comunication workflow question. Please raise this on the koha-devel mailing list instead. If you have suggestions, then it can be formally proposed to be discussed on a IRC dev meeting. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '17

03 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #49 from Pete Edwards <koha(a)jsense.co.uk> --- Thanks for the responses but I don't think you quite understood my point. I only gave the specific instance as an example of someone else who would be affected by this patch but I don't use that one. I have written a plugin myself that is now broken because of this change. How does a plugin author find out when you may a change to koha that breaks plugins? I am saying that both the internal assumptions made in this patch and the types of input and output parameters have changed so all plugins using the to_marc method will have broken. I didn't see anything in the release notes notifying people that there was an API change. -- You are receiving this mail because: You are watching all bug changes.

1 0