September 2017 - Koha-bugs - lists.koha-community.org

[Bug 18966] New: Move of checkouts - Deal with duplicate IDs at DBMS level
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '17

14 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18966 Bug ID: 18966 Summary: Move of checkouts - Deal with duplicate IDs at DBMS level Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: blocker Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 18651, 18931 Koha suffers of big bugs due to its history: When data are deleted, they are moved to another tables. For instance issues and old_issues: when a checkin is done, it is moved to the old_issues table. That leads to a main problem that is described on https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix However we tried first to fix the problem (for issues/old_issues) at code level on bug 18242. The goal was to prevent data lost. Data lost may happens in this case: Check an item out (issue_id = 1) Check an item in (issue_id = 1) Restart MySQL (reset auto increment for issue_id to 1) Check an item out (issue_id = 1) Check an item in => BOOM, the issue_id is a PK in old_issues and the move fails. Before bug 18242 the data were lost, we inserted the value into old_issues, which fails silently (because of RaiseError set to 0 in Koha::Database), then delete the row from issues. That has been fixed using a transaction. This patch introduced a regression we tried to fix on bug 18651 comment 0, the patron was charged even if the checkin was rejected. A good way to fix that would have been to LOCK the tables: 1- Start a transaction 2- LOCK the table to make sure nobody will read id and avoid race conditions 3- Move the content from one table to the other, dealing with ids 4- UNLOCK the table 5- Commit the transaction But there were problems using LOCK and DBIx::Class (See commit 905572910b3a - Do no LOCK/UNLOCK the table). Finally the solution implemented is not acceptable for several reasons: - batch checkins may fail - issue_id will always stay out of sync (between issues and old_issues) See 18651 comment 66. Since the next stable releases are very soon, and we absolutely need to fix this problem, I am suggesting to: 1- Execute the move in a transaction to avoid data lost and reject the checkin if we face IDs dup => It will only reject 1 checkin (max is 1 * MySQL restart), no need to deal with race conditions, 2- Display a warning on the checkin page and link to a solution/explanation 3- Communicate as much as we can on the proper fix: Update auto increment values when the DBMS is restarted - https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix 4- Display a warning on the about page for corrupted data (see bug 18931) 5- Write and make available a maintenance script to fix corrupted data (TODO LATER) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 [Bug 18651] Move of checkouts is still not correctly handled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 [Bug 18931] Add a "data corrupted" section on the about page -- You are receiving this mail because: You are watching all bug changes.

1 43

[Bug 19314] 1
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '17

14 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19314 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Koha security |Koha Component|Koha |Architecture, internals, | |and plumbing Group|Koha security | Assignee|chris(a)bigballofwax.co.nz |koha-bugs(a)lists.koha-commun | |ity.org QA Contact| |testopia(a)bugs.koha-communit | |y.org --- Comment #1 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Hello, Can you provide more information please? When do you get this warning? Which version of Koha are you using? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '17

14 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #60 from Josef Moravec <josef.moravec(a)gmail.com> --- Hm, does it make sense to have "access" to accountlines on both endpoint? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15428] Different timeout preference for opac and intranet
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '17

14 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #1 from Lisette <lisetteslatah(a)gmail.com> --- This seems like it could be a huge privacy issue on Catalog computers in public libraries. It would be nice if we could set the staff and OPAC to different timeouts. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15428] Different timeout preference for opac and intranet
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '17

14 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 Lisette <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19311] New: E-mail staff about items on a watch list
by bugzilla-daemon＠bugs.koha-community.org 13 Sep '17

13 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19311 Bug ID: 19311 Summary: E-mail staff about items on a watch list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com I would love it if we could create a watch list for staff members. For example, I need to know when certain electronics are overdue so I can have them deactivated. I would see the following with this feature: * Feature would be available to users by patron id # or patron category * Tab would appear in user account * User would be able to list item by barcode or item number, and could be notified by e-mail when an item's status changes to a particular value. * Option of specifying how many days a status must be at a particular value before sending a notification (not a notification delay). * Option to create notification groups (group of items) that could be watched by a single watch rule. * Option of sharing watch group with specific users by combinations of patron id, card number, branch, and patron category. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 6557] biblioitems.totalissues unused
by bugzilla-daemon＠bugs.koha-community.org 13 Sep '17

13 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19310 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19310 [Bug 19310] Warning on UpdateTotalIssuesOnCirc should be revisited -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 13 Sep '17

13 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 David Bourgault <david.bourgault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.bourgault(a)inlibro.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 13 Sep '17

13 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 David Bourgault <david.bourgault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59446|0 |1 is obsolete| | Attachment #64802|0 |1 is obsolete| | Attachment #64824|0 |1 is obsolete| | --- Comment #53 from David Bourgault <david.bourgault(a)inlibro.com> --- Created attachment 67115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67115&action=ed… Bug 12532 - Send emails to guarantee and guarantor Adds setting "RedirectGuaranteeEmail". When setting is enabled, emails to patron with a guarantor will be send to both guarantor and guarantee. Does this by amending the C4::Members::GetNoticeEmail() sub. It does not affect values in the message_queue table. Test plan: Before applying 1) Select patron with guarantor 2) Enable checkout emails 3) Checkout item. Email will be sent only to guarantee 4) Apply patch 5) Run updatedatabase.pl 6) Enable 'RedirectGuaranteeEmail' in system preferences 7) Go through step 1) to 3). Email should now be sent to both. 8) Run t/db_dependant/Members.t Obsoletes all previous patches, which failed to apply/ Sponsored by: Ville de Victoriaville -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10412] The ability to update Acquisitions with credit notes, with the option to link to an existing invoice
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '17

12 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412 Patrick Robitaille <patrick.robitaille(a)ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille(a)ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes.

1 0