September 2017 - Koha-bugs - lists.koha-community.org

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '17

07 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61879|0 |1 is obsolete| | --- Comment #68 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 66935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66935&action=ed… Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. Signed-off-by: Brendan Gallagher <brendan(a)bywatersolutions.com> tmp -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '17

07 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61878|0 |1 is obsolete| | --- Comment #67 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 66934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66934&action=ed… Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress Signed-off-by: Brendan Gallagher <brendan(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '17

07 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '17

07 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66906|0 |1 is obsolete| | --- Comment #27 from Marc Véron <veron(a)veron.ch> --- Created attachment 66926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66926&action=ed… Bug 12691: [FOLLOW-UP] Fixing some logic Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15339] TestBuilder build parameter warnings
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '17

07 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19268 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15339] TestBuilder build parameter warnings
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '17

07 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15339] TestBuilder build parameter warnings
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '17

07 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 --- Comment #11 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 66924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66924&action=ed… Bug 15339: [QA Follow-up] Add a warning too when source is not supplied When you do not supply a source and add a few wrong parameters, you would not be warned. Because build simply returns undef. Adding a carp and a test for that situation too. Note: In the earlier subtest 'trivial tests' build was called without source. This now generates a warning. We just catch if there is a warning and test the actual warning itself later on. Test plan: Run t/db_dependent/TestBuilder.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15339] TestBuilder build parameter warnings
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '17

07 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66894|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 66923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66923&action=ed… Bug 15339: Improve parameter validation Only value and source are allowed Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15339] TestBuilder build parameter warnings
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '17

07 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66893|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 66922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66922&action=ed… Bug 15339: TestBuilder warnings (tests) Makes TestBuilder::build() alert the user when unreognized parameters are passed, which happens when the user supplies the column values directly, forgetting the 'value' hash. This patch contains the tests that doubles as a demonstration of the kind of error the patch is intended to prevent. Sponsored-By: Halland County Library Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15339] TestBuilder build parameter warnings
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '17

07 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66892|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 66921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66921&action=ed… Bug 15339: TestBuilder warnings (code) Makes TestBuilder::build() alert the user when unreognized parameters are passed, which happens when the user supplies the column values directly, forgetting the 'value' hash. This patch holds the code changes. Examples of the kind of errors that it catches are in the tests (separate patch). Sponsored-By: Halland County Library Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0