September 2017 - Koha-bugs - lists.koha-community.org

[Bug 15339] TestBuilder build parameter warnings
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '17

06 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Patches have been rebased and adapt to the new code. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15339] TestBuilder build parameter warnings
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '17

06 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 --- Comment #6 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 66894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66894&action=ed… Bug 15339: Improve parameter validation Only value and source are allowed Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15339] TestBuilder build parameter warnings
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '17

06 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 66893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66893&action=ed… Bug 15339: TestBuilder warnings (tests) Makes TestBuilder::build() alert the user when unreognized parameters are passed, which happens when the user supplies the column values directly, forgetting the 'value' hash. This patch contains the tests that doubles as a demonstration of the kind of error the patch is intended to prevent. Sponsored-By: Halland County Library Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15339] TestBuilder build parameter warnings
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '17

06 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45527|0 |1 is obsolete| | Attachment #45528|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 66892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66892&action=ed… Bug 15339: TestBuilder warnings (code) Makes TestBuilder::build() alert the user when unreognized parameters are passed, which happens when the user supplies the column values directly, forgetting the 'value' hash. This patch holds the code changes. Examples of the kind of errors that it catches are in the tests (separate patch). Sponsored-By: Halland County Library Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15339] TestBuilder build parameter warnings
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '17

06 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11580] If returnBeforeExpiry is on, holidays are not taken into account to calculate the due date
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '17

06 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #24 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Alex Arnaud from comment #21) > Created attachment 66886 [details] [review] > Bug 11580 - Fix expiry calculation and rewrite tests (In reply to Jonathan Druart from comment #23) > Created attachment 66888 [details] [review] > Bug 11580: Add one more test and clear the cache > > Make sure we are not just returning J-1 and clear the cache before and > after the tests. These last 2 patches have been pushed to master, thanks Alex! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '17

06 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #24 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- What are we doing here? If it is just replacing syspref fetch with Koha.Preference, the following is wrong: - [% IF ( display_patron_image ) %] + [% IF ( Koha.Preference('ShowPatronImageInWebBasedSelfCheck') ) %] display_patron_image is set when $borrower is set AND the pref is set. We had too many regressions in this area, I will not take any risks. If we are doing something else, it is not written in the commit messages. Please clarify. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11580] If returnBeforeExpiry is on, holidays are not taken into account to calculate the due date
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '17

06 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|returnBeforeExpiry and |If returnBeforeExpiry is |closed day |on, holidays are not taken | |into account to calculate | |the due date -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11580] returnBeforeExpiry and closed day
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '17

06 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #23 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 66888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66888&action=ed… Bug 11580: Add one more test and clear the cache Make sure we are not just returning J-1 and clear the cache before and after the tests. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11580] returnBeforeExpiry and closed day
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '17

06 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud(a)biblibre.com --- Comment #22 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Here is a fix about Jonathan's comment. I don't know which status to choose for this BZ since it has been pushed to master... -- You are receiving this mail because: You are watching all bug changes.

1 0