January 2018 - Koha-bugs - lists.koha-community.org

[Bug 18228] New: Working title
by bugzilla-daemon＠bugs.koha-community.org 29 Mar '18

29 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 Bug ID: 18228 Summary: Working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt(a)gmail.com Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

1 63

[Bug 17941] New: CanBookBeRenewed is very inefficient/slow
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '18

28 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Bug ID: 17941 Summary: CanBookBeRenewed is very inefficient/slow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: boutrosboutrosboutros(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com I started investigating why populating the checkout list in the patron view sometimes took ages (minutes), and on occations even causing the system to almost halt because of DB overload. It turned out that reason is calls to C4::Circulation::CanBookBeRenewed. The critical factor is whether an item has many holds on it, and if there are many items that can fill the hold. Briefly looking at the code it seems obvious that the time spent grows exponentially with the number of holds and items. As one example, checking if an item with 111 holds (and 12 items on the biblio) can be renewed takes around 25 sec and generates over 18,000 SQL queries. I can't help to think there must be some missed "early returns" opportunities in the loops somewhere. For example, if there are more unfulfilled holds than available items, can the item ever be renewed? If no, return before even begin to calculate.. However, I know holds are full of complexities and things I probably haven't thought about so I need to dig into the code more. I would be very gratefull if anyone knowledgeable about this part of the code could help me find some ways to optimize this! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 54

[Bug 20045] New: Switch single-column templates to Bootstrap grid: Various
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045 Bug ID: 20045 Summary: Switch single-column templates to Bootstrap grid: Various Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: dcook(a)prosentient.com.au, josef.moravec(a)gmail.com, misilot(a)fit.edu, nengard(a)gmail.com, testopia(a)bugs.koha-community.org Blocks: 19980 This patch will convert several unrelated templates to use the Bootstrap grid: - about.tt - auth.tt - serials/subscription-add.tt - admin/admin-home.tt - reports/reports-home.tt - suggestion/suggestion.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 19468] New: Can't create basket in acquisitions
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19468 Bug ID: 19468 Summary: Can't create basket in acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Depends on: 15685 When trying to create a new basket in acq, I get an internal server error: Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/C4/Acquisition.pm line 829. I think this might be a side effect of the recently pushed bug 15685. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 19695] New: Uncertain prices should not use find in list context
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19695 Bug ID: 19695 Summary: Uncertain prices should not use find in list context Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: stefan.berndtsson(a)ub.gu.se QA Contact: testopia(a)bugs.koha-community.org When clicking on Uncertain prices button from a basket, the log fails with the following message: Cannot use "->find" in list context at <path>/acqui/uncertainprice.pl line 76. Similar to Bug 18179. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 19979] New: Search.t fails on facet info with one branch
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19979 Bug ID: 19979 Summary: Search.t fails on facet info with one branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 19452] New: working title
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452 Bug ID: 19452 Summary: working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 38

[Bug 20111] New: Patron card creator - some strings are not translatable
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '18

26 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Bug ID: 20111 Summary: Patron card creator - some strings are not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: victor.grousset(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Hopefully at least 80% of the fixes and 70% of the test plan of bug 19522 will be reusable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 20085] New: Better translatability of smart-rules.tt
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '18

26 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20085 Bug ID: 20085 Summary: Better translatability of smart-rules.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr Template smart-rules.tt in administration contains some if/elsif/else with translatable strings. For example : [% IF rule.onshelfholds == 1 %] Yes [% ELSIF rule.onshelfholds == 2 %] If all unavailable [% ELSE %] If any unavailable [% END %] Adding span to translatable strings will allow to have the same translation than : <select name="onshelfholds" id="onshelfholds"> <option value="1">Yes</option> <option value="0">If any unavailable</option> <option value="2">If all unavailable</option> </select> This is important to allow editing an existing circulation and fine rule. Actually for example in french some strings are translated differently : msgid "%s Yes %s If all unavailable %s If any unavailable %s" msgstr "%s Oui %s Si tous indisponibles %s Si aucun indisponible %s" msgid "If any unavailable" msgstr "Si au moins un exemplaire est indisponible" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 19961] New: Move template JavaScript to the footer: Patron card creator
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '18

26 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19961 Bug ID: 19961 Summary: Move template JavaScript to the footer: Patron card creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for patron card creator templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

1 7