January 2018 - Koha-bugs - lists.koha-community.org

[Bug 13990] ILS-DI LookupPatron Requries ID Type
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '18

28 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 --- Comment #17 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 71004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71004&action=ed… Bug 13990: Followup: silence warnings on testing prove t/db_dependent/ILSDI_Services.t Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13990] ILS-DI LookupPatron Requries ID Type
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '18

28 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 --- Comment #16 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 71003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71003&action=ed… Bug 13990: QA Followup - Add unit test coverage prove t/db_dependent/ILSDI_Services.t Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13990] ILS-DI LookupPatron Requries ID Type
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '18

28 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 --- Comment #15 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 71002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71002&action=ed… Bug 13990: Followup - fix various whitespace errors - tabs to 4 spaces - trailing whitespace - missing vertical whitespace before =head3 Without this patch, this bug fails qa test tools. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13990] ILS-DI LookupPatron Requries ID Type
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '18

28 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70997|0 |1 is obsolete| | Attachment #70998|0 |1 is obsolete| | Attachment #70999|0 |1 is obsolete| | Attachment #71000|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 71001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71001&action=ed… Bug 13990 - ILS-DI LookupPatron Requries ID Type Patch provides a constrained set of borrower attributes to try in turn if the ID type is not specified. Also added "email" to the POD documented list of id types seeing as its quite a useful one for integration developers. Test plan: 1) without the patch applied, turn on ils-di interface in your admin sysprefs and then try accessing the URL: https://your-server/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=Mabel replacing "your-server" your Koha dev test domain name (localhost:8080 if you're using a kohadevbox VM) and "Mabel" with the first name of a patron (Mabel is in the test database already if you're using that). You should get back an error message in the XML. 2) Apply the patch and repeat. This time you should get an <id> element in the XML with Mabel's patron ID in it. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13990] ILS-DI LookupPatron Requries ID Type
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '18

28 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13990] ILS-DI LookupPatron Requries ID Type
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '18

28 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from M. Tompsett <mtompset(a)hotmail.com> --- Moved back to signed off, as full case unit testing was added for the affected function: C4::ILSDI::Services::LookupPatron. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13990] ILS-DI LookupPatron Requries ID Type
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '18

28 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 --- Comment #12 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 71000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71000&action=ed… Bug 13990: Followup: silence warnings on testing prove t/db_dependent/ILSDI_Services.t Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13990] ILS-DI LookupPatron Requries ID Type
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '18

28 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 --- Comment #11 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 70999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70999&action=ed… Bug 13990: QA Followup - Add unit test coverage prove t/db_dependent/ILSDI_Services.t Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13990] ILS-DI LookupPatron Requries ID Type
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '18

28 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70966|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 70998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70998&action=ed… Bug 13990: Followup - fix various whitespace errors - tabs to 4 spaces - trailing whitespace - missing vertical whitespace before =head3 Without this patch, this bug fails qa test tools. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13990] ILS-DI LookupPatron Requries ID Type
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '18

28 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70965|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 70997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70997&action=ed… Bug 13990 - ILS-DI LookupPatron Requries ID Type Patch provides a constrained set of borrower attributes to try in turn if the ID type is not specified. Also added "email" to the POD documented list of id types seeing as its quite a useful one for integration developers. Test plan: 1) without the patch applied, turn on ils-di interface in your admin sysprefs and then try accessing the URL: https://your-server/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=Mabel replacing "your-server" your Koha dev test domain name (localhost:8080 if you're using a kohadevbox VM) and "Mabel" with the first name of a patron (Mabel is in the test database already if you're using that). You should get back an error message in the XML. 2) Apply the patch and repeat. This time you should get an <id> element in the XML with Mabel's patron ID in it. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0