January 2018 - Koha-bugs - lists.koha-community.org

[Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #12 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 70394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70394&action=ed… Bug 11046: Improve the readability of the regex using named capture The tests tell me I am good -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #21 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #15) > QA Comment > Interesting feature! Limited testing did not reveal problems. > > Functionality issue: > In Administration, smart-rules, the section "Default checkout limit by > patron category" contains the item "Maximum total holds allowed (count)". I've submitted a patch to improve the section name. > Not sure if the label should contain total and count btw. Removed > But the section should be renamed. This does not pertain any longer to > checkout limits only. Agreed. > Furthermore I would expect to have max_holds also under Default checkout, > hold and return policy. It seems consistent to add it also without a patron > category restriction. That behavior is controlled by the maxreserves system preference. We should move that out of a syspref and into the circ rules. I'd be happy to do that on another bug but it's definitely out of the scope of this bug. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #20 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 70392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70392&action=ed… Bug 15524 [QA Followup] - Change language used -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #19 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 70391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70391&action=ed… Bug 15524: (follow-up) Rename database update This ensures that this update is applied in the correct order relative to its dependent bugs. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #18 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 70390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70390&action=ed… Bug 15524 - Update Schema Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67180|0 |1 is obsolete| | Attachment #67181|0 |1 is obsolete| | Attachment #67531|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 70389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70389&action=ed… Bug 15524 - Set limit on maximum possible holds per patron by category It's possible to set a limit on the maximum number of holds for a particular branch/category/itemtype, but not on the total number of holds for a given patron (by branch/category). This new rule works in conjunction with the existing branch/borrower/item rules in that Koha will use the lower of the two limits. This new rule counts all holds of all types, which prevents bib-level holds from not being counted for the purpose of these limits. This makes the most sense and was also requested by the sponsor. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Go to the circ rules editor, note the new max holds rules by patron category in the "Checkout limit by patron category". ( Should we rename this section? ) 4) Create find a patron that is allowed to place a hold, count the number of holds that patron has. Lets make that number 'X'. 5) Set the new max holds rule to X for "All libraries" 6) Note the patron can no longer place another hold 7) Set the new max holds rule to X + 1 for the patron's home library 8) Note the patron can again place another hold 9) Set the new max holds rule to X for the patron's home library 10) Note the patron can no longer place another hold Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #16 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #15) > QA Comment > Interesting feature! Limited testing did not reveal problems. > > Functionality issue: > In Administration, smart-rules, the section "Default checkout limit by > patron category" contains the item "Maximum total holds allowed (count)". I've submitted a patch to improve the section name. > Not sure if the label should contain total and count btw. Removed > But the section should be renamed. This does not pertain any longer to > checkout limits only. Agreed. > Furthermore I would expect to have max_holds also under Default checkout, > hold and return policy. It seems consistent to add it also without a patron > category restriction. That behavior is controlled by the maxreserves system preference. We should move that out of a syspref and into the circ rules. I'd be happy to do that on another bug but it's definitely out of the scope of this bug. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #77 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Also, when I see: @@ -1141,18 +1141,9 @@ sub IsAvailableForItemLevelRequest { } return $any_available ? 0 : 1; + } else { # on_shelf_holds == 0 "If any unavailable" (the description is rather cryptic and could still be improved) + return $item->{onloan} || IsItemOnHoldAndFound( $item->{itemnumber} ); } - - if ($item->{onloan}) { - return 1; - } - - if ( Koha::Holds->search({itemnumber => $item->{itemnumber}, - found => ['W', 'T']})->count ) { - return 1; - } Then: +sub hasItemswaitingOrInTransit { + my ( $self ) = @_; + + if ( Koha::Holds->search({ biblionumber => $self->id, + found => ['W', 'T'] })->count ) { + return 1; + } I am pretty sure something is wrong. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #76 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Additionally, do you think adding camelCase method's name in a module containing only snake_case is a good idea? -- You are receiving this mail because: You are watching all bug changes.

1 0