January 2018 - Koha-bugs - lists.koha-community.org

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #16 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #15) > QA Comment > Interesting feature! Limited testing did not reveal problems. > > Functionality issue: > In Administration, smart-rules, the section "Default checkout limit by > patron category" contains the item "Maximum total holds allowed (count)". I've submitted a patch to improve the section name. > Not sure if the label should contain total and count btw. Removed > But the section should be renamed. This does not pertain any longer to > checkout limits only. Agreed. > Furthermore I would expect to have max_holds also under Default checkout, > hold and return policy. It seems consistent to add it also without a patron > category restriction. That behavior is controlled by the maxreserves system preference. We should move that out of a syspref and into the circ rules. I'd be happy to do that on another bug but it's definitely out of the scope of this bug. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #77 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Also, when I see: @@ -1141,18 +1141,9 @@ sub IsAvailableForItemLevelRequest { } return $any_available ? 0 : 1; + } else { # on_shelf_holds == 0 "If any unavailable" (the description is rather cryptic and could still be improved) + return $item->{onloan} || IsItemOnHoldAndFound( $item->{itemnumber} ); } - - if ($item->{onloan}) { - return 1; - } - - if ( Koha::Holds->search({itemnumber => $item->{itemnumber}, - found => ['W', 'T']})->count ) { - return 1; - } Then: +sub hasItemswaitingOrInTransit { + my ( $self ) = @_; + + if ( Koha::Holds->search({ biblionumber => $self->id, + found => ['W', 'T'] })->count ) { + return 1; + } I am pretty sure something is wrong. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #76 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Additionally, do you think adding camelCase method's name in a module containing only snake_case is a good idea? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #75 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Comment on attachment 69815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69815 Bug 4319: [OPAC] Allow holds on waiting/transit items Review of attachment 69815: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=431…) ----------------------------------------------------------------- ::: Koha/Biblio.pm @@ +319,5 @@ > } > > +=head3 hasItemswaitingOrInTransit > + > +=cut Why are you cheating the QA script? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18472] New: Add system preference CustomOnlineHelpStaff to hide / select custom online help system
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 Bug ID: 18472 Summary: Add system preference CustomOnlineHelpStaff to hide / select custom online help system Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Online help pages in staff client display a button 'Edit help' which is not wanted / needed for every installation. Introduce a system variable CustomOnlineHelpStaff to manage the online help system. In a first step it can select between 'None' and the existing 'File based help system' (selected by default). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 41

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #7 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to George Williams (NEKLS) from comment #6) > Signed off based on video that Jesse put together for me. Well, none of the dependencies apply cleanly, where are the patches ? :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library' s circ rules
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I have fixed an easy conflict with commit 971591d4ee8576d6782d32610bbae7cfe4674231 Bug 19029: Add JavaScript security question for cloning circ rules - <input type="submit" value="Clone" /> + <input type="submit" id="clone_rules" value="Clone" /> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library' s circ rules
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67177|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 70387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70387&action=ed… Bug 15520: Add permission to restrict circ rules editing to own library Test plan: 1) Ensure that you have four users: a) A superlibrarian b) A user with all `parameters` permissions (the toplevel `parameters` box is checked). c) A user with the `manage_circ_rules` permission (and, of course, `catalogue`). d) A user with the `manage_circ_rules`, `manage_circ_rules_restricted` and `catalogue` permissions. 2) As all four users, load the "Circulation and fine rules" administration page (admin/smart-rules.pl). 3) The page should be unchanged for the first three users. It should be possible to view and edit the circ rules for all libraries. 4) The last (restricted) user should only be able to view and edit the circ rules for their own library. Followed test plan, patch worked as described Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15937] New: Batch checkout buggy behavior
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '18

09 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15937 Bug ID: 15937 Summary: Batch checkout buggy behavior Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: hector.hecaxmmx(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 1920 For damaged items the warning message is not displayed, and Koha let to checkout the item as shown in the image. <https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48411> I notice about a buggy behavior in this functionallity, for example the program let to checkout the first item available without confirm the checkout message, for example, Maxwell's handbook was borrowed/renewed to this patron every time in which I repeat the process. When the process end, you will presented with this table (<https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48412>), one items was checked-out and the others wasn't, but the message is not clear whether those items was checked out or not. Another thing that I could observe is: if circ policies only allow an specific number e.g. two checkouts and two renews of an item the module doesn't let to checkout if patron has one or more checkouts and the message displayed for the program is not clear; If MaxFine is set affect in the checkouts and don't let us checkout as show in the previous image, and as before, the message doesn't provide an adequate information. NOTE: The images presented in this bug, they are obtained by applying bug 15920. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1920 [Bug 1920] Total price not saving to order -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 9