January 2018 - Koha-bugs - lists.koha-community.org

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 06 Jan '18

06 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #1 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 70314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70314&action=ed… Bug 12001: Move C4::Members::GetMemberAccountRecords -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 06 Jan '18

06 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19921 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 [Bug 19921] Error when updating child to adult patron on system with only one adult patron category -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16853] New: Move changepassword to Koha::Patron->update_password
by bugzilla-daemon＠bugs.koha-community.org 06 Jan '18

06 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16853 Bug ID: 16853 Summary: Move changepassword to Koha::Patron->update_password Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 06 Jan '18

06 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- + unless ($item) { carp "No item passed in!" && return } Not our preferred coding style + return () if (! $yaml =~ /\S/ ); Just return here. The only call is in scalar context. We do not need a list. Shorter: return if $yaml !~ /\S/; + eval { + $denyingrules = YAML::Load($yaml); + }; How much time are we spending on doing this? What is the performance effect? If the pref always looks like field1: [val]\nfield2: [val2] we can just split on newline and split on ':', etc. Give me some convincing numbers please. + return (); Same as above + my $val; + if (exists $item->{$field}) { + $val = $item->{$field}; + } + $val = '' unless defined $val; Why not in just one line: my $val = $item->{$field} // ''; + - How to write these rules is documented on the <a href="http://wiki.koha-community.org/wiki/OpacHiddenItems" target="_blank">Koha wiki</a>. This is from the preference file. Not sure if this is the preferred way. A wiki page could be gone just as easily. Why not just provide an example as close as possible to the pref itself. Just another 40 chars ? Just curious too if this supports denying renewal on an empty string? If so, the conversion from undef to empty string might not be what we want. Can we signal empty string or undef to be a blocking value? [No blocker for me btw :)] Changing status. Please make some adjustments. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 06 Jan '18

06 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #20 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Nick Clemens from comment #19) > It seems due dates were being set to now. If the tests take long enough to > run then the items were overdue. Set the date in the future now Yes, that works better. Thx -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 06 Jan '18

06 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #19 from Nick Clemens <nick(a)bywatersolutions.com> --- It seems due dates were being set to now. If the tests take long enough to run then the items were overdue. Set the date in the future now -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 06 Jan '18

06 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #18 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 70295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70295&action=ed… Bug 15494 - Followup: Make sure items in tests are not overdue prove -v t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 06 Jan '18

06 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19728] New: Move template JavaScript to the footer: Circulation
by bugzilla-daemon＠bugs.koha-community.org 06 Jan '18

06 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19728 Bug ID: 19728 Summary: Move template JavaScript to the footer: Circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 19641 Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for the main circulation page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 [Bug 19641] Move patron templates to the footer -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 06 Jan '18

06 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0