January 2018 - Koha-bugs - lists.koha-community.org

[Bug 19803] New: SQL report export can fail HTTP 414 Request-URI Too Large
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19803 Bug ID: 19803 Summary: SQL report export can fail HTTP 414 Request-URI Too Large Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org After running a saved SQL report, one can download result into a file. This uses a link with the SQL query as URL argument. If this query is really big, the download may fail with HTTP 414 "Request-URI Too Large". This link should use the report id to retrieve SQL query. There is a comment asking this in reports/guided_reports.pl : my $sql = $input->param('sql'); # FIXME: use sql from saved report ID#, not new user-supplied SQL! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #144 from Liz Rea <liz(a)catalyst.net.nz> --- a+ preserving attribution. :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED --- Comment #143 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Josef Moravec from comment #142) > these patchset doesn't apply. Thanks for looking and noticing this. > So just few comments from quick reading of the > code: > > You don't have to change signature of GetHiddenItemnumbers, you can ask for > patron category here... And you can than leave the $search_context as is. I can't recall the reason off the top of my head, and even after rebasing this locally -- I have yet to test and put it back up. But I've got a feeling it had something to so with the nesting of some search functions which were not easily determined to be opac or intranet otherwise. > Also the "opac" param in GetMarcBiblio and EmbedItemsInMarcBiblio is not > needed, you can use C4::Context->interface when you need to know the > actual interface. It is better to pass it in my opinion to refactor the parameters list, so that test functions don't require special mocking to get the C4::Context function to return the correct value in different cases (like shell script utilities). And this makes maintenance for other changes in the future easier for others, and brings the code up to preferred coding style (https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL16:_Hashrefs_sho…) > And some squashing would be nice here ;) I was tweaking, testing, fixing, repeating multiple times. Also, smaller patches are easier to test individually. I will squash as much as possible. I do, however, not want to lose the fact that Aleisha Amohia put in a massive effort which helped me see how to solve my C4::Search mess problem that I had hit while working on originally in bug 10589. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13376] Include a user-editable area/ page for terms and conditions of use in the opac
by bugzilla-daemon＠bugs.koha-community.org 02 Jan '18

02 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13376 Liz Rea <liz(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #5 from Liz Rea <liz(a)catalyst.net.nz> --- This bug got derailed, I still think the original feature proposal is a good one. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
by bugzilla-daemon＠bugs.koha-community.org 02 Jan '18

02 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #10 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 70236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70236&action=ed… Bug 11046: Add the form YYY-? for uncertain years This form occurred in Dutch ISBD rules. The question mark should follow the hyphen(s). Test plan: Run t/db_dependent/Biblio/TransformMarcToKoha.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> TransformMarcToKoha tests passed. Also this patch passed QA test tool Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
by bugzilla-daemon＠bugs.koha-community.org 02 Jan '18

02 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68349|0 |1 is obsolete| | Attachment #68350|0 |1 is obsolete| | --- Comment #9 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 70235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70235&action=ed… Bug 11046: Better handling of uncertain years for publicationyear This patch makes it possible that uncertain year like 18.. or 197x are converted to 1800 or 1970 in Koha field copyrightdate (MARC21) or publicationyear (UNIMARC). (The corresponding MARC record will not be changed obviously.) This change will allow for better results when sorting search results or list contents on copyrightdate. Currently, things like 18.. will sort together with zero. Note: The regex now allows four possible uncertain year markers: x or X, question mark or dot. Test plan: [1] Run t/db_dependent/Biblio/TransformMarcToKoha.t [2] Edit a biblio record. Save 18.. into 260c. Check biblio.copyrightdate. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Followed test plan, patch worked as described, it also passed QA test tool Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
by bugzilla-daemon＠bugs.koha-community.org 02 Jan '18

02 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
by bugzilla-daemon＠bugs.koha-community.org 02 Jan '18

02 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |josef.moravec(a)gmail.com |y.org | CC| |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off
by bugzilla-daemon＠bugs.koha-community.org 02 Jan '18

02 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68934|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 70232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70232&action=ed… Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off Test Plan: 1) Apply patch 2) Turn off AllowOnShelfHolds 3) Create a bib with one item, mark the item as 'on order' 4) Attempt to place a hold on the item, you should now be able to do so -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off
by bugzilla-daemon＠bugs.koha-community.org 02 Jan '18

02 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0