January 2018 - Koha-bugs - lists.koha-community.org

[Bug 10032] Uncertain prices hide 'close basket' without explanation
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 Jon Knight <J.P.Knight(a)lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69748|0 |1 is obsolete| | --- Comment #6 from Jon Knight <J.P.Knight(a)lboro.ac.uk> --- Created attachment 70250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70250&action=ed… Bug 10032: Uncertain prices hide 'close basket' without explanation Added disabled "Close this basket" button when uncertain prices are present. Note that whilst this has a "title" attribute, there is no tooltip shown because JQueryUI disabled buttons don't get DOM events. To test: 1) Before applying the patch, go to staff UI, and select Acquisitions, pick one of your existing vendors (or create a new one) and then open a new basket (call it anything you want). 2) Add a new (empty) record order to the basket. 3) Give the new record a made up title, add a single item (no need to fill in any details), set a price of 10.00 and check the "Uncertain price" checkbox before saving the record. 4) Confirm that the resulting summary page has a button bar that does NOT include any button for closing the basket. 5) Modify the record and remove the check mark from the "Uncertain price" checkbox before saving. 6) Confirm that the resulting basket summary page button bar now does have a "Close this basket" button (as the basket no longer has uncertain prices). 7) Apply the patch. 8) Modify the record again to check the "Uncertain price" checkbox again, then save it. 9) Confirm that the resulting summary page has a button bar that does include a "Close this basket" button but that this button is greyed out and inoperative. 10) Modify the record again to remove the check mark in the "Uncertain price" checkbox, then save the record. 11) Confirm that the resulting summary page has a button bar that does include a "Close this basket" button which is now active (as the order no longer has an uncertain price). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 19602] New: Add usage statistics link to administration sidebar menu
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19602 Bug ID: 19602 Summary: Add usage statistics link to administration sidebar menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org admin-menu.inc doesn't have a link to usage_statistics.pl -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 19456] New: Some pages title tag contains html
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456 Bug ID: 19456 Summary: Some pages title tag contains html Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com This comes from patron-title.inc -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 28

[Bug 19803] New: SQL report export can fail HTTP 414 Request-URI Too Large
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19803 Bug ID: 19803 Summary: SQL report export can fail HTTP 414 Request-URI Too Large Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org After running a saved SQL report, one can download result into a file. This uses a link with the SQL query as URL argument. If this query is really big, the download may fail with HTTP 414 "Request-URI Too Large". This link should use the report id to retrieve SQL query. There is a comment asking this in reports/guided_reports.pl : my $sql = $input->param('sql'); # FIXME: use sql from saved report ID#, not new user-supplied SQL! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #144 from Liz Rea <liz(a)catalyst.net.nz> --- a+ preserving attribution. :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '18

03 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED --- Comment #143 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Josef Moravec from comment #142) > these patchset doesn't apply. Thanks for looking and noticing this. > So just few comments from quick reading of the > code: > > You don't have to change signature of GetHiddenItemnumbers, you can ask for > patron category here... And you can than leave the $search_context as is. I can't recall the reason off the top of my head, and even after rebasing this locally -- I have yet to test and put it back up. But I've got a feeling it had something to so with the nesting of some search functions which were not easily determined to be opac or intranet otherwise. > Also the "opac" param in GetMarcBiblio and EmbedItemsInMarcBiblio is not > needed, you can use C4::Context->interface when you need to know the > actual interface. It is better to pass it in my opinion to refactor the parameters list, so that test functions don't require special mocking to get the C4::Context function to return the correct value in different cases (like shell script utilities). And this makes maintenance for other changes in the future easier for others, and brings the code up to preferred coding style (https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL16:_Hashrefs_sho…) > And some squashing would be nice here ;) I was tweaking, testing, fixing, repeating multiple times. Also, smaller patches are easier to test individually. I will squash as much as possible. I do, however, not want to lose the fact that Aleisha Amohia put in a massive effort which helped me see how to solve my C4::Search mess problem that I had hit while working on originally in bug 10589. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13376] Include a user-editable area/ page for terms and conditions of use in the opac
by bugzilla-daemon＠bugs.koha-community.org 02 Jan '18

02 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13376 Liz Rea <liz(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #5 from Liz Rea <liz(a)catalyst.net.nz> --- This bug got derailed, I still think the original feature proposal is a good one. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
by bugzilla-daemon＠bugs.koha-community.org 02 Jan '18

02 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #10 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 70236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70236&action=ed… Bug 11046: Add the form YYY-? for uncertain years This form occurred in Dutch ISBD rules. The question mark should follow the hyphen(s). Test plan: Run t/db_dependent/Biblio/TransformMarcToKoha.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> TransformMarcToKoha tests passed. Also this patch passed QA test tool Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
by bugzilla-daemon＠bugs.koha-community.org 02 Jan '18

02 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68349|0 |1 is obsolete| | Attachment #68350|0 |1 is obsolete| | --- Comment #9 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 70235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70235&action=ed… Bug 11046: Better handling of uncertain years for publicationyear This patch makes it possible that uncertain year like 18.. or 197x are converted to 1800 or 1970 in Koha field copyrightdate (MARC21) or publicationyear (UNIMARC). (The corresponding MARC record will not be changed obviously.) This change will allow for better results when sorting search results or list contents on copyrightdate. Currently, things like 18.. will sort together with zero. Note: The regex now allows four possible uncertain year markers: x or X, question mark or dot. Test plan: [1] Run t/db_dependent/Biblio/TransformMarcToKoha.t [2] Edit a biblio record. Save 18.. into 260c. Check biblio.copyrightdate. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Followed test plan, patch worked as described, it also passed QA test tool Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
by bugzilla-daemon＠bugs.koha-community.org 02 Jan '18

02 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0