October 2018 - Koha-bugs - lists.koha-community.org

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '18

28 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80327|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '18

28 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80330|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '18

28 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80329|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '18

28 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80328|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '18

28 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80333|0 |1 is obsolete| | --- Comment #67 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 81417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81417&action=ed… Bug 15494: (follow-up) Update tests to generate their own data (no delete) Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '18

28 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80332|0 |1 is obsolete| | --- Comment #66 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 81416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81416&action=ed… Bug 15494: (follow-up) Move yaml syspref code to its own sub in SySpref object To test: 1 - prove -v t/db_dependent/Koha/Config/SysPrefs.t Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '18

28 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80331|0 |1 is obsolete| | --- Comment #65 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 81415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81415&action=ed… Bug 15494: (QA follow-up) Additional polishing [1] Fix two typos in Circulation.t. Although the test does not fail, line 2127 contains two typos. Changing INVISILE to INVISIBLE :) And type should be itype. [2] Remove $yaml as leftover from older code. [3] Add a next when the split on /:/ does not give two results. This will prevent uninit warnings (although still disabled now in Circulation). [4] For the same reason we should switch the lines for NULL and empty string. The undefs you insert should trigger a warn. [5] The line for empty string should not insert undef, but empty string. For the same reason adding the condition defined($_) ... And proving it by adding two tests for the opposite values of callnumber and itemnotes. [6] Adding a strip spaces around the fieldname. User friendly.. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '18

28 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #64 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 81414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81414&action=ed… Bug 15494: Add syspref Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '18

28 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #63 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 81413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81413&action=ed… Bug 15494: Update display of renewal errors To test: 1 - Define a rule to deny renewal 2 - Checkout an item meeting this rule 3 - Attempt renew an item via the OPAC 4 - Attempt renewal via SIP 5 - Attempt renewal via staff client 6 - Verify errors are reasonable Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '18

28 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #62 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 81412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81412&action=ed… Bug 15494: Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0