October 2018 - Koha-bugs - lists.koha-community.org

[Bug 21690] New: Koha::Account->outstanding_credits has no tests
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '18

26 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21690 Bug ID: 21690 Summary: Koha::Account->outstanding_credits has no tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Everything in the Koha namespace should be properly tested.. but Koha::Account has a number of methods that are missing corresponding tests. -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 21689] New: Koha::Account->outstanding_debits has no tests
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '18

26 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21689 Bug ID: 21689 Summary: Koha::Account->outstanding_debits has no tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Everything in the Koha namespace should be properly tested.. but Koha::Account has a number of methods that are missing corresponding tests. -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '18

26 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #66 from Ere Maijala <ere.maijala(a)helsinki.fi> --- I hope I managed to fix all the remaining issues. I left the removal of extra characters in the extractControlNumber template since just encoding them is not the same as getting rid of them, but I also added encoding. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '18

26 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #65 from Ere Maijala <ere.maijala(a)helsinki.fi> --- Created attachment 81305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81305&action=ed… Bug 14716: Fix more unencoded url parameters. Fixes issues found during QA and unifies the SubfieldSelect function across the utils xsl's. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '18

26 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #64 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Great work.. as commented on irc earlier.. I found a few cases where we could be escaping but we're not yet: 1) Where we're searching the `an:` index. Unfortunately, we can't guarantee the marc field we're referring to won't contain any nasty characters. 2) rcn:<xsl:value-of select="marc:controlfield[@tag=001]"/> - 001 isn't entirely guaranteed to be clean either 3) The 'extractControlNumber' template appears to do it's own escaping.. perhaps we could convert this to use the str:encode-uri filter you're importing - This is by no means a failure case though. That's all I can find.. nice work. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11529] Add subtitle field to biblio table
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '18

26 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #7 from Ere Maijala <ere.maijala(a)helsinki.fi> --- I think these days multiple values are concatenated, but with spaces and a pipe character, so it's not very friendly for display purposes. I'll see if I can come up with a patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '18

26 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20995] New: Add request ID to OPAC ILL requests display table
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '18

26 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20995 Bug ID: 20995 Summary: Add request ID to OPAC ILL requests display table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com Currently when an OPAC user is viewing the table of their ILL requests, they do not see the request ID. This is commonly used for referring to requests, so we should add it to this view and the individual request view. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 30

[Bug 21174] New: Sysprefs to enable the opening of OPAC cart in one click
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '18

26 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Bug ID: 21174 Summary: Sysprefs to enable the opening of OPAC cart in one click Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: alexbuckley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org Instead of having to click on the OPAC cart icon, then having to click on the 'Items in your cart: ..' box before the cart popup loads it would be nice to give libraries control if they want the cart popup to appear directly after the cart icon is clicked upon. Implementing a syspref, defaulted to 'false' to enable one click cart opening would libraries allow one click cart opening without having to manually alter the JS. -- You are receiving this mail because: You are watching all bug changes.

1 54

[Bug 11529] Add subtitle field to biblio table
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '18

26 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I think we can map multiple, but they are not all added to the db (I think). I like the idea of separate fields. -- You are receiving this mail because: You are watching all bug changes.

1 0