October 2018 - Koha-bugs - lists.koha-community.org

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #73 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- Created attachment 81032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81032&action=ed… Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #103 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Jonathan Druart from comment #101) > So, from what I understand the third form (for 0) will be not supported, > unless we change the Plural-Forms (are we really supposed to change that?). I don't think we are supposed to. The simple solution would be to always use the {count} so we would have "0 exemplaire" and "1 exemplaire". Or we could handle this in the code: [% IF count %] [% tnx('{count} item', '{count} items', count, { count = count }) %] [% ELSE %] [% t('Not a single item!') %] [% END %] I think there is no best solution here and both can be used. Sometimes we want to display a different message when there are 0 "things", and sometimes not. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74267|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74268|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74269|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74270|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74272|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #102 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Code review: 1. Not important but the Koha.po file provided for the tests are not taken into account. Maybe it could be better to generate the .mo from the tests? 2. No tests provided for misc/translator/LangInstaller.pm - I would not consider it as blocker as it is the current state. 3. The content from the .inc files are added to the .po because they contain TT blocks on several lines. Maybe we should have a list of files to skip and copy as it (?) 4. What is done in Koha::I18N::init is weird, but I trust you if you think everythink is needed. However: pod Locale::Messages, nl_putenv: "The sole purpose of this function is to work around some ideosyncrasies in the environment processing of Windows systems. If you want to portably set or unset environment variables, use this function instead of directly manipulating %ENV." So maybe we should use ENV, it will make the line clear about what it does, and 'git grep $ENV' will work -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #101 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- It works better instead. Just noting: == es-ES - nplurals=2; plural=(n != 1); == msgid "{count} item" msgid_plural "{count} items" msgstr[0] "Uno ejemplar" msgstr[1] "{count} ejemplares" will output: 1: Uno ejemplar 2: 2 ejemplares but also: 0: 0 ejemplares == fr-FR - nplurals=2; plural=(n > 1); == msgid "{count} item" msgid_plural "{count} items" msgstr[0] "Un exemplaire" msgstr[1] "{count} exemplaires" will output: 1: Un examplaire 2: 2 exemplaires but also: 0: Un exemplaire So, from what I understand the third form (for 0) will be not supported, unless we change the Plural-Forms (are we really supposed to change that?). With: "Plural-Forms: nplurals=3; plural=(n==0 ? 0 : n==1 ? 1 : 2);\n" #: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:1 #: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:2 #, perl-brace-format msgid "{count} item" msgid_plural "{count} items" msgstr[0] "Pas d'exemplaire" msgstr[1] "Un exemplaire" msgstr[2] "{count} exemplaires" I get what I expected: 1: Un exemplaire 2: 2 exemplaires 0: Pas d'exemplaire (I have moved the tnx call outside before the SEARCH_RESULT.items_count) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '18

23 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #100 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Jonathan Druart from comment #99) > > - According to > > https://localization-guide.readthedocs.io/en/latest/l10n/pluralforms.html > > Spanish has 2 "plural forms" (one of which is the singular form), so > > msgstr[0] should contain the singular form and msgstr[1] the plural form. > > Did you try if these changes will behave correctly in pootle? > i.e. Does the pootle's interface will let translators filled these forms > according to the language, etc.? I haven't tried but the documentation says that pootle support this feature http://docs.translatehouse.org/projects/translate-toolkit/en/latest/formats… and it's a basic feature of gettext/PO files. I would be very surprised if Pootle doesn't handle it. -- You are receiving this mail because: You are watching all bug changes.

1 0