October 2018 - Koha-bugs - lists.koha-community.org

[Bug 14391] Granular permissions for the administration module
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79558|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 80006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80006&action=ed… Bug 14391: (QA follow-up) Fix some typos Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14391] Granular permissions for the administration module
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79557|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 80005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80005&action=ed… Bug 14391: (QA follow-up) Resolve POD warn on svc..systempreferences *** WARNING: No items in =over (at line 48) / =back list at line 54 in file svc/config/systempreferences *** WARNING: No items in =over (at line 73) / =back list at line 79 in file svc/config/systempreferences => If you use 'over', you should add 'item'-s. Test plan: Run perldoc svc/config/systempreferences Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14391] Granular permissions for the administration module
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79556|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 80004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80004&action=ed… Bug 14391: Add granular permissions to the administration module So far the administration module only allowed for 2 permissions: - circulation conditions (manage_circ_rules) - everything else (parameters_remaining_permissions) With this patch almost every section of the administration page will have its own granular permission. To test: - Create different staff users: 1) One with parameters_remaining_permissions 2) One with parameters 3) One with catalogue and no parameters 4) One superlibrarian - Apply the patch - Run the database update - Check the staff users: 1) All subpermissions, but manage_circ_rules should be checked 2) Nothing should have changed 3) manage_item_serach_fields shoudl be checked (page had catalogue permission before) 4) Nothing should have changed - Try different settings of the permissions and verify that - Administration page behaves correctly - Administration menu behaves correctly ! You shoudl only see what you have permission for https://bugs.koha-community.org/show_bug.cgi?id=14391 Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14391] Granular permissions for the administration module
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 --- Comment #14 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- > Need to take another look here if you think it's really necessary. Will not insist. > > > admin/localization.pl, svc/localization > > > Need manage_itemtypes > > > Understand why you do it, but it seems not logical in the long run. Better > > > add a specific one. > I'll add a separate permission in another follow-up. Please add a see also or blocks for the new report. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11512] Only allow to override maximum number of holds from staff as other overrides would never be filled
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512 --- Comment #15 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Stefan, this is a good use case - the lost items. If this is a regression we should fix it. Could you open a separate bug and link to this? It will give the problem better visibility. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #88 from Michal Denar <black23(a)gmail.com> --- Created attachment 79996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79996&action=ed… Bug 14576: Unit tests To test: 1 - prove -v t/db_dependent/Circulation/Returns.t 2 - prove -v t/db_dependent/Circulation/issue.t 3 - prove -v t/db_dependent/UsageStats.t 4 - All should pass Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79245|0 |1 is obsolete| | Attachment #79246|0 |1 is obsolete| | --- Comment #87 from Michal Denar <black23(a)gmail.com> --- Created attachment 79995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79995&action=ed… Bug 14576: Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) Round Rock Public Library (https://www.roundrocktexas.gov/departments/library/) Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78264|0 |1 is obsolete| | --- Comment #62 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 79994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79994&action=ed… Bug 8630: (follow-up) Make Adlibris cover show on OPAC overdues tab and fix alignment of cover on Staff detail page. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78263|0 |1 is obsolete| | --- Comment #61 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 79993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79993&action=ed… Bug 8630 - Adlibris covers (OPAC less changes) This patch adds two new CSS classes specific to Adlibris covers. Sponsored-By: Halland County Library Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0