December 2018 - Koha-bugs - lists.koha-community.org

[Bug 14334] DBI fighting DBIx over Autocommit in tests
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '18

14 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #31 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #29) > git grep -l RaiseError|wc -l > 29 > What about these DBI remainders ? That should not hurt, I'd even say it should be set for all tests. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14334] DBI fighting DBIx over Autocommit in tests
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '18

14 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83129|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 83201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83201&action=ed… Bug 14334: Remove AutoCommit from tests And use a DBIx transaction instead. Test plan: prove that the test files modified by this patch are passing Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14334] DBI fighting DBIx over Autocommit in tests
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '18

14 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14334] DBI fighting DBIx over Autocommit in tests
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '18

14 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #29 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- git grep -l RaiseError|wc -l 29 What about these DBI remainders ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14334] DBI fighting DBIx over Autocommit in tests
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '18

14 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt(a)gmail.com |m.de.rooy(a)rijksmuseum.nl CC| |m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11492] Receiving a serial item causes routing list notes to be lost
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '18

14 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 --- Comment #7 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 83192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83192&action=ed… Bug 11492: (follow-up) Don't pass publisheddatetext param to NewIssue I have removed publisheddatetext as a param from my patch, but only in the places where my patch added it. Any other instance already existed before my patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11492] Receiving a serial item causes routing list notes to be lost
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '18

14 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11492] Receiving a serial item causes routing list notes to be lost
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '18

14 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 --- Comment #6 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to Jonathan Druart from comment #5) > Hi Aleisha, > > You are doing things that are not advertised in the commit message. For > instance you are passing $publisheddatetext to NewIssue. I feel like this is > wrong, $publisheddatetext should not be kept from one issue to another. > > There is > 1160 my $nextpublisheddate = GetNextDate($subscription, > $publisheddate, 1); > 1161 my $nextpubdate = $nextpublisheddate; > > And $nextpubdate is passed as $planneddate and $publisheddate for the next > one, but $publisheddatetext will be unchanged. Hi Jonathan, I only did this because the subroutine already took $publisheddatetext as a parameter, so thought it would be okay. I will resubmit my patch with an empty string in the place of $publisheddatetext, but otherwise this seems like a different problem. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14759] Replacement for Text::Unaccent
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '18

14 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21848 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14759] Replacement for Text::Unaccent
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '18

14 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #29 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Mirko Tietgen from comment #28) > Some test fails ATM when building a package in Buster (unstable) and looking > into that I ended up here. Looking into packaging Text::Unaccent::PurePerl I > found it has not had an update since 2013 so we would exchange one dead > package for another. I'm thinking "Strip NonspacingMark" instead of Text::Accent* might be the solution? -- You are receiving this mail because: You are watching all bug changes.

1 0