Koha-bugs

Download

koha-bugs@lists.koha-community.org

February 2018

1 participants
2782 discussions

[Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '18

01 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 paxed <pasi.kallinen(a)joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '18

01 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 paxed <pasi.kallinen(a)joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71019|0 |1 is obsolete| | --- Comment #3 from paxed <pasi.kallinen(a)joensuu.fi> --- Created attachment 71102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71102&action=ed… Allow translating "Cancel Rating", and use string formatting for couple other strings - Make the "Cancel rating" text translatable (and change capitalization to conform to Koha coding guidelines) - Improve the two other messages to use formatted strings instead of concatenation. - Use the exact same text for the "your rating" text, so it only appears once in the po-file. Test plan: 1. See that the "Cancel rating" -text doesn't appear in po/xx-YY-opac-bootstrap.po 2. Note how there's two versions of the your rating -text ("your rating: %s, " and "your rating:") in the po-file 3. Apply patch 4. Update the xx-YY translation 5. Check the po-file. It should now contain the "Cancel rating" and a single "your rating: %s, " 6. Translate those texts, and update & install the language. 7. Go to the OPAC detail page of a biblio, and check the rating texts. 8. Hovering over the rating minus -sign should show the translated "Cancel rating" 9. Check that the text after the stars is correct with and without your rating -- You are receiving this mail because: You are watching all bug changes.

1 0

Jump to page: