March 2018 - Koha-bugs - lists.koha-community.org

[Bug 8643] Add important constraint to marc subfields
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '18

30 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|maxime.beaulieu(a)inlibro.com |charles.farmer(a)inlibro.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '18

30 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72170|0 |1 is obsolete| | --- Comment #18 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 73503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73503&action=ed… Bug 12502: QA Follow-up 1) The method under C4 was deleted. There wasn't any reason for a method under Koha, in the end, because it's a simple update that requires no additional processing. If I had to do any legwork with the data before updating the Order fields, I would've written a wrapper. As it stands right now, the work can be done directly in the controller without polluting the Koha/Acquisition/Orders.pm class. 2) Added the ISBN field to csv_header, and added that value to lateorders-export I've also changed the string internaldate to internalnote, small typo fix. 3) Made adjustements client-side and server-side. In the browser, you can now see a small loading icon to inform the user that the 'Save note' button actually triggered an action. A new alert message also informs the user if something awry happened while updating the orders' notes. I took a look at the user page, to see how notes were saved, but I was not satisfied with the idea of mixing an Ajax call with a window.location.reload; doesn't make sense in my mind to uselessly reload the page if the information had already reached the server, and since it was already coded that way, I felt like this change was the best course of action. Server-side, it is now possible to save an empty field. Before this patch, 'if($note)' would actually fail on an empty string, which meant you could never erase a note, for any reason whatsoever. After testing this patch, if the width of the input is still something that you'd like to see changed, I'll have no problem reducing it a little, but you'll have to tell me how large is _too_ large :) 4) Order no. -> Order line 5) Added the new columns to the admin/visibility yaml 6) It would be possible to also display an ISSN, but I won't make this patch any large than it is for now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '18

30 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73500|0 |1 is obsolete| | --- Comment #17 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 73502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73502&action=ed… Bug 12502 - Add ordernumber and ISBN to late order Adds ordernumber as 2nd column and ISBN as last Followed test plan and patch worked as described. Also ran QA test tools and all modified files passed Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '18

30 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73499|0 |1 is obsolete| | --- Comment #16 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 73501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73501&action=ed… Bug 12502 - Add vendor and internal note to late orders page Followed test plan and patch worked as described. Also ran QA test tools and all modified files passed. Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '18

30 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72169|0 |1 is obsolete| | --- Comment #15 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 73500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73500&action=ed… Bug 12502 - Add ordernumber and ISBN to late order Adds ordernumber as 2nd column and ISBN as last Followed test plan and patch worked as described. Also ran QA test tools and all modified files passed Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '18

30 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72168|0 |1 is obsolete| | --- Comment #14 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 73499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73499&action=ed… Bug 12502 - Add vendor and internal note to late orders page Followed test plan and patch worked as described. Also ran QA test tools and all modified files passed. Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20440] New: Please update URL to NORMARC demo
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '18

30 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20440 Bug ID: 20440 Summary: Please update URL to NORMARC demo Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Project website Assignee: wizzyrea(a)gmail.com Reporter: magnus(a)libriotech.no Kia ora! The NORMARC demo on https://koha-community.org/demo/ has these URLs: http://head.bibkat.no/ http://head.bibkat.no:8080/ This demo is no longer maintained. Please replace with these URLs: https://demo.bibkat.no/ https://demo-admin.bibkat.no/ The username and password is the same as before: demo / demo. Thanks for keeping the website alive! -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 7047] renewing serials note not visible
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '18

30 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com Status|Signed Off |Failed QA --- Comment #8 from Nick Clemens <nick(a)bywatersolutions.com> --- Hi Alex, Couple things here: 1 - There is a stray warn left in the patchset 2 - I would tend to agree with Mark, the subroutine should be converted to a hashref 3 - This should probably be two bugs - one to fix the note, one to add the branch option 4 - The span is lost when creating the new column, we should preserve this to retain any CSS that may affect display -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 13795] Delete unused columns from statistics table.
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '18

30 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> --- Could we use "usercode" to log the user/librarian who did the action? It would be useful especially for action types that are not logged in action_logs (i.e. issue renewals, payments, writeoffs) I just want to mention that I have a bunch of different values in proccode, but I have no idea what they mean. mysql> select distinct(proccode) from statistics; +----------+ | proccode | +----------+ | | | 10 | | 1005 | | 1064 | | 1073 | | 1093 | | 11 | | 1152 | | 12 | ... | 9 | | 903 | | 918 | | 920 | | 932 | | 947 | | 98 | | 991 | | 996 | +----------+ 220 rows in set (0,07 sec) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15239] Add multiple items fail on barcode
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '18

30 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239 --- Comment #13 from Charles Farmer <charles.farmer(a)inlibro.com> --- Because C4::Barcodes treats its arguments with shifts, there isn't any way to feed a branch to the constructor at all time without potentially clashing with other barcode types. Work could be done to change shifts to $params->{whatever}, but I went with an 'if' test in additem.pl instead. Also, as mentionned by Jonathan and as explained in the hbyymmincr class, this barcode format is far from perfect. At least, with this patch, it should now be correctly incrementing when autoBarcode is set and add_multiple_copies_submit is used to submit the form. -- You are receiving this mail because: You are watching all bug changes.

1 0