March 2018 - Koha-bugs - lists.koha-community.org

[Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '18

17 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 --- Comment #31 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Frido, maybe you can sign-off again? I think David made changes after my initial sign-off (would have been better in a little follow-up patch) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15284] Switch default ISSUESLIP notice to Template Toolkit
by bugzilla-daemon＠bugs.koha-community.org 16 Mar '18

16 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15284 Roch D'Amour <roch.damour(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |roch.damour(a)inlibro.com --- Comment #4 from Roch D'Amour <roch.damour(a)inlibro.com> --- I tried to apply the patch, but I got a sha1 error. fatal: sha1 information is lacking or useless (installer/data/mysql/de-DE/mandatory/sample_notices.sql). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 16 Mar '18

16 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72983|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 16 Mar '18

16 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #52 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 73055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73055&action=ed… Bug 12310 : Decimal separators issues: some fixes in fines and acquisitions The main aim is to prevent - x100 or /100 of the amounts - decimal part truncation Fixes Bug 19521 - Partial fine payment is not working with comma decimal separator But not Bug 18723 - Dot not recognized as decimal separator (aquisitions) It will be done in a follow up patch. This one is already too huge to test. Bonuses: - get rid of the spaces, currency symbols, names (EUR) It handles: - by default comma and dot as decimal separators on the same instance - dot or comma as thousands separators if choose to use only one of them as decimal separator. See DigitSeparator syspref. == Test plan == 1. In the manual invoice (cgi-bin/koha/members/maninvoice.pl) 2. Apply the annex 1 to the "Amount" field 3. When paying a fine (cgi-bin/koha/members/paycollect.pl) 4. Click on "Pay amount" to go to the page to pay all fines 5. Apply the annex 1 to the "Collect from patron" field 6. Click on "Pay" to go to the page to pay fine 7. Apply the annex 1 to the "Collect from patron" field 8. Go to "Create manual credit" (staff://cgi-bin/koha/members/mancredit.pl) 9. Apply the annex 1 to the "Amount" field 10. Go to the "Add budget" page staff://cgi-bin/koha/admin/aqbudgetperiods.pl?op=add_form 11. Apply the annex 1 to the "Total amount" field 12. Create an active budget 13. Go to the "Add Fund" page for this budget 14. Apply the annex 1 to the "Amount" field 15. Apply the annex 1 to the "Warning at (amount)" field 16. If you have ideas of stuff to try to find *regressions* from the previous versions, then try. You might spare librarian tears by finding something before it's released. 17. Express your happiness. This is important, otherwise the signoff spell won't work! The details of expressing your happinnes depends on your culture and habits. === Annex 1: Subpart for each concerned page === 1. Set DigitSeparator syspref to ",." 2. Input "12,34" 3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the conversion. Validating the form does the same but it's a trick to test more quickly by not changing the page. 4. Ensure that it's converted to 12.34 5. Do the same with "12.34 EUR" and ensure that it's converted to "12.34" 6. Same with "EUR 12.34" → "12.34" 7. "123 456,7" → "123456.7" 8. "EUR 12.34 hi lyon3" → "12.34" 9. "2" → "2" 10. "2,0" → "2.0" XX. TODO WIP thousands sep and other relevant cases XX. Finally validate the form and check that the final value with the dot was well handled. XX. Thinks about Koalas and smile. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8457] No results found on term/phrase click in scan index results list .
by bugzilla-daemon＠bugs.koha-community.org 16 Mar '18

16 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8457 Jon Knight <J.P.Knight(a)lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight(a)lboro.ac.uk --- Comment #8 from Jon Knight <J.P.Knight(a)lboro.ac.uk> --- I've just been trying this on my kohadevbox under master, and I can provoke it to make an error with the default test data (searching for "network" rather than "ivory" to get matches). Is this an issue that has been fixed in another change in the last few years, or am I misunderstanding what the issue is and it is still causing problems? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15287] Use font-awesome on the OPAC
by bugzilla-daemon＠bugs.koha-community.org 16 Mar '18

16 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|francescalamoore(a)gmail.com |oleonard(a)myacpl.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18873] New: Update of the existing default framework with new IFLA unimarc recommendations
by bugzilla-daemon＠bugs.koha-community.org 16 Mar '18

16 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18873 Bug ID: 18873 Summary: Update of the existing default framework with new IFLA unimarc recommendations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: fcouffignal(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 16 Mar '18

16 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mtompset(a)hotmail.com |josef.moravec(a)gmail.com --- Comment #6 from Josef Moravec <josef.moravec(a)gmail.com> --- The problem is a bit complicated, this sub was wrong at all (sorry for mystification you Mark). I added new method Koha::Patron->attributes and use it instead -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 16 Mar '18

16 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #5 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 73019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73019&action=ed… Bug 12159: Add tests Test plan: prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 16 Mar '18

16 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72902|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 73018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73018&action=ed… Bug 12159: Fix getting extended patron attributes for circ-menu Changes: - Replace getting preference ExtendedPatronAttributes by Koha.Preference in templates - Add Koha::Patron->attributes for getting patrons extended attributes - Use this method in circ-menu.inc - Remove getting attributes from members perl scripts Test plan: 0) Apply the patch 1) Add some patron attributes type - with free text, authorised value, limited by libraries... 2) Add some values to this attributes for some patrons 3) Go through as many patron pages as you can and confirm that attributes are shown at side panel when they shoul and are not shown when they should not be shown -- You are receiving this mail because: You are watching all bug changes.

1 0