March 2018 - Koha-bugs - lists.koha-community.org

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '18

09 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72065|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '18

09 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '18

09 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #46 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 72551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72551&action=ed… Bug 14272: (follow-up) Show single news item Patch applies successfully and behaves as expected. Sponsored-by: Catalyst IT Signed-off-by: Dilan Johnpullé <dilan(a)calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '18

09 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70729|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 72550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72550&action=ed… Bug 14272: Show single news item (OPAC) This change makes the news shown on opac-main-pl have clickable headings which shows just that news item in isolation. This is to allow further patches that adds commentary functions. Sponsored-By: Halland County Library Test plan: * Apply this patch. * Go to OPAC main, you should see multiple news items by default. * If you do not see any, go to Staff interface and add a few. * Each nees item heading should be clickable. * When clicked only that item should be shown. * When 'news_id' is present, only a single news item should show. * The breadcrumb should say 'News item' after 'Home'. Updates: * Renamed URL parameter and local variables with 'news_' prefix. * Fixed Search-And-Replace error; 'news_news_id' => 'news_id' * Added breadcrumb for viewing single news item. * Updated OPAC to use new GetNewsToDisplay parameters * Fixed template formatting and calling of GetNewsToDisplay Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> Fixing merge conflicts Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '18

09 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70728|0 |1 is obsolete| | --- Comment #44 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 72549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72549&action=ed… Bug 14272: Show single news item (backend) Updates: * Date formatting added to get_opac_new() * Proper filtering by way of GetNewsToDisplay Sponsored-by: Halland County Library Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> Fixing merge conflicts Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '18

09 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50557|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 72548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72548&action=ed… Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '18

09 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #42 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Just some questions, but I don't feel any of this is a blocker: - In the breadcrumbs the link says "News item" - why not use the heading in the breadcrumbs? - The RSS feed remains visible - is that intended? - OpacMainUserBlock remains at the bottom - is that intended? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12812] Longoverdue.pl --mark-returned doesn't return items
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '18

09 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12812] Longoverdue.pl --mark-returned doesn't return items
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '18

09 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 --- Comment #4 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72545&action=ed… Bug 12812: (Follow-up) Fix use of C4::Circulation Fixes this error: Undefined subroutine &main::MarkIssueReturned called at misc/cronjobs/longoverdue.pl line 316. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12812] Longoverdue.pl --mark-returned doesn't return items
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '18

09 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71336|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72544&action=ed… Bug 12812: Longoverdue.pl --mark-returned doesn't return items The longoverdue.pl option --mark-returned doesn't work unless the --charge option is used as well. Test Plan: 1) Run long overdue with --mark-returned and not --charge, note your items are marked lost but not returned 2) Apply this patch 3) Repeat step 1, the items should now get returned! Tested with (for example): misc/cronjobs/longoverdue.pl --lost 10=1 --mark-returned --verbose --confirm Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0