April 2018 - Koha-bugs - lists.koha-community.org

[Bug 9634] Allow for parameters re-use on SQL reports
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '18

03 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #15 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Nick Clemens from comment #14) > Needs to be rebased on bug 20052 - adding get_prepped_report method to > Koha/Report.pm and covering with tests Nvm, I didn't add this method - will be a future enh, but out of scope here -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9634] Allow for parameters re-use on SQL reports
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '18

03 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #14 from Nick Clemens <nick(a)bywatersolutions.com> --- Needs to be rebased on bug 20052 - adding get_prepped_report method to Koha/Report.pm and covering with tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9634] Allow for parameters re-use on SQL reports
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '18

03 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70735|0 |1 is obsolete| | Attachment #70736|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 73548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73548&action=ed… Bug 9634: Allow for combining same paraneters in SQL reports This patch combines report paramters with the same name and data type (authorised value) This presereves the past ability to provide all parameters as 'sql_params' in order to preserve existing public report links To test: 1 - Create a report that takes multiple parameters, e.g.: SELECT <<cat>> AS one, <<dog|branches>> AS two, <<dog|YES_NO>> as three, <<cat>> as four, <<dog|branches>> as five 2 - Run this report, note you are asked for five parameters 3 - Apply patch 4 - Update database 5 - Run report, note you are asked for three params 6 - Verify the results reflect the supplied parameters 7 - Export the report and verify results 8 - Alter the URL and provide 5 params as sql_params and no param_name variables i.e. http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phas… 9 - Verify results come out as expected Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '18

03 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73215|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '18

03 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #56 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 73546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73546&action=ed… Bug 12310 : Decimal separator issues: some fixes in fines The main goal is to prevent - x100 or /100 of the amounts - decimal part truncation Fixes Bug 19521 - Partial fine payment is not working with comma decimal separator Bonuses: - Gets rid of the spaces, currency symbols, names (EUR) There is nothing specific about currency symbols is this patch. It just removes everything that is not a digit a minus or a separator. It handles: - by default comma and dot as decimal separators on the same instance - dot or comma as thousands separators if choose to use only one of them as decimal separator. See DigitSeparator syspref. - minuses, doesn't remove them == Test plan == 1. Use a translation of the staff interface if possible. 2. When you pay an existing fine (more details in the next steps if needed). Check that you can't enter any string except like "XX.XX" (examples in Annex 1) without having an issue after validation. (x100, trucation, etc) 3. Apply this patch 4. run ~/src/installer/data/mysql/updatedatabase.pl 5. In the manual invoice (cgi-bin/koha/members/maninvoice.pl) 6. Apply the annex 1 to the "Amount" field 7. When paying a fine (cgi-bin/koha/members/paycollect.pl) 8. Click on "Pay amount" to go to the page to pay all fines 9. Apply the annex 1 to the "Collect from patron" field 10. Click on "Pay" to go to the page to pay fine 11. Apply the annex 1 to the "Collect from patron" field 12. Go to "Create manual credit" (staff://cgi-bin/koha/members/mancredit.pl) 13. Apply the annex 1 to the "Amount" field 14. If you have ideas of stuff to try to find *regressions* from the previous versions, then try. You might spare librarian tears by finding something before it's released. (and prevent me from having bounty on my head) 15. Express your happiness. This is important, otherwise the sign off spell won't work! The details of expressing your happiness depend on your culture and habits. === Annex 1: Subpart for each concerned page === 1. Set DecimalSeparators syspref to ",." 2. Input "12,34" 3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the conversion. Validating the form does the same but it's a trick to test more quickly by not switching to another page. 4. The value should have been converted to 12.34 5. What follows is just a list of examples. They don't have to be tried on each field. 6. Do the same with "12,34 EUR" and ensure that it's converted to "12,34" 7. Same with "EUR 12.34" -> "12.34" 8. "EUR 12.34€hi lyonthree" -> "12.34" 9. "123 456,7" -> "123456.7" 10. "2" -> "2" 11. "2,0" -> "2.0" 12. "-1'345.95" -> "-1345.95" 13. ",1234" -> ".1234" 14. Set DecimalSeparators syspref to "," 15. Reload the page with the form 16. "1.000" -> "1000" 17. "1.000.000,10" -> "1000000.10" 18. Set DecimalSeparators syspref to "." 19. Reload the page with the form 20. "1,000" -> "1000" 21. "1,000,000.10" -> "1000000.10" 22. Validate the form and check that the final value with the dot was well handled. 23. Think about Koalas and smile. 🐨🐨🐨 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '18

03 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #28 from Ere Maijala <ere.maijala(a)helsinki.fi> --- Katrin, my patch is alternative to the other ones and in my opinion the correct way to fix this and related encoding issues once and for all. But as I mentioned it's not complete yet and I'd like to have some feedback before I go through the trouble of completing it since it's a bit of tedious work. Kyle's version of url encoding would be fine otherwise, but it will only work for basic latin characters, and the current practice of shoving unencoded stuff into url's is simply wrong and only works because browsers are forgiving in the handling of most characters. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14803] Rental and fine fees are not updating on circulation screen
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '18

03 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #56 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Rebased, and fines look fine, however I think checkouts list is somewhat broken on the circ issuing screen. And I believe that's not to do with this patch, but cannot be 100% sure. Can you please have a look. Thanks -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14803] Rental and fine fees are not updating on circulation screen
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '18

03 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66261|0 |1 is obsolete| | --- Comment #55 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 73542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73542&action=ed… Bug 14803 follow-up: outstanding-fees-amount is a class, not id Multiple outstanding-fees-amount displays on the page -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14803] Rental and fine fees are not updating on circulation screen
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '18

03 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14803] Rental and fine fees are not updating on circulation screen
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '18

03 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65868|0 |1 is obsolete| | --- Comment #54 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 73541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73541&action=ed… bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines -- You are receiving this mail because: You are watching all bug changes.

1 0