May 2018 - Koha-bugs - lists.koha-community.org

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 01 May '18

01 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #73 from Kyle M Hall <kyle(a)bywatersolutions.com> --- > 1) Release notes > Should state consequences to: > - patron import (no change, but can only import with one guarantor?) > - LDAP and SIP (lines where changed, but only in POD?) > - patron REST API (guarantor information can't be changed or asked for) > - Reports using borrowers.guarantorid have to be changed/rewritten Added. Left out LDAP/SIP since there is literally no change in behavior. I updated the documentation since it's there but it should really be removed from the codebase altogether. > 2) QA script > FAIL opac/opac-user.pl > FAIL valid > "my" variable $patron masks earlier declaration in same scope > > FAIL Koha/Patron/Relationships.pm > FAIL pod > Spurious =cut command > *** ERROR: > in file Koha/Patron/Relationships.pm > FAIL pod coverage > POD is missing for 'object_class' > > FAIL Koha/Patron.pm > FAIL pod coverage > POD is missing for 'has_permission' Fixed! QA script is giving me invalid TT syntax failures for some reason. xt/tt_valid.t passes and everything works in actual testing. > a) I tried adding a guarantor from a Teacher (Professional) and from a Kid > (Child) account. Both don't offer the form to me. > > b) Using the 'add child' from an existing patron (Adult), a new form opens > for an adult patron category, the guarantor information is empty. Fixed! > > 5) Code review (splinter): > > ::: Koha/Patron.pm > @@ +119,5 @@ > > > > return scalar Koha::Patron::Images->find( $self->borrowernumber ); > > } > > > > +=head3 library > > Please add a description here too, not just an empty entry. QA tools will be > happy with this, but the missing POD never fixed. Fixed! > @@ +135,5 @@ > > > > +Returns the set of relationships for the patrons that are guarantors for this patron. > > + > > +This is returned instead of a Koha::Patron object because the guarantor > > +may not exist as a patron in Koha. If this is true, the guarantors name > > This is quite a change - is it really implemented in this patch set? What's > the use case? Just a name is not a lot to locate the person if needed. It's not a change, it's a new subroutine. I'm not sure I understand what you mean. The use case is explained in the comment. We can't return Koha::Patron's because not every guarantor is one. So instead we return the guarantor relationships from which a Koha::Patron can be gotten if there is one, otherwise the guarantor info ( name, relationship, etc ) can be read directly from the guarantor relationship object. > ::: koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc > @@ -17,5 @@ > > [% IF CAN_user_borrowers_edit_borrowers %] > > [% IF patron.is_adult AND Koha.Preference("borrowerRelationship") %] > > <a id="addchild" class="btn btn-default btn-sm" href="/cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=[% patron.borrowernumber %]"><i class="fa fa-plus"></i> Add child</a> > > [% END %] > > - [% IF CAN_user_borrowers_edit_borrowers %] > > This change doesn't look like it was intentional/related. Please check. This change is intentional. Looks at the IF above it. We have two nested if statements checking the same thing. There was no need for the inner one so I removed it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 01 May '18

01 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74952|0 |1 is obsolete| | --- Comment #72 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 74953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74953&action=ed… Bug 14570 [QA Followup] - Fix QA issues with POD -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 01 May '18

01 May '18

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 01 May '18

01 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #71 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 74952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74952&action=ed… Bug 14570 [QA Followup] - Fix QA issues with POD -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 01 May '18

01 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #70 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 74951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74951&action=ed… Bug 14570 - Update Schema -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 01 May '18

01 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73583|0 |1 is obsolete| | Attachment #73584|0 |1 is obsolete| | --- Comment #69 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 74950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74950&action=ed… Bug 14570 - Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t Signed-off-by: Kim Peine <kmpeine(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 01 May '18

01 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11512] Only allow to override maximum number of holds from staff as other overrides would never be filled
by bugzilla-daemon＠bugs.koha-community.org 01 May '18

01 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512 Cheryl <clackman(a)fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman(a)fargolibrary.org, | |edischer(a)cityoffargo.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11919] staff should be able to place (and capture) holds on items that cannot fill hold requests for patrons
by bugzilla-daemon＠bugs.koha-community.org 01 May '18

01 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11919 Cheryl <clackman(a)fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edischer(a)cityoffargo.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 01 May '18

01 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs(a)lists.koha-commun |kyle(a)bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0