June 2018 - Koha-bugs - lists.koha-community.org

[Bug 13655] Can't save organisation type patron without entering userid/password
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '18

25 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #20 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11181] Koha geolocalization of OPAC users for better sort results
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '18

25 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11181 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard(a)myacpl.org |koha-bugs(a)lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 5789] Fines don't work when items have null homebranch
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '18

25 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5789 --- Comment #13 from Saiful Amin <saiful(a)semanticconsulting.com> --- (In reply to Saiful Amin from comment #12) > I still don't think scripts should break on missing/bad data. For example, > I've observed that bulkmarcimport.pl breaks if 245$c contains Arabic date. > Ideally, it should warn and skip the record if it can't process the data. > I'm not sure if this is by design. My bad. That's tag 260$c (not 245$c) that breaks batch import. I'll probably add a separate bug for that if it doesn't exist. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5789] Fines don't work when items have null homebranch
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '18

25 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5789 --- Comment #12 from Saiful Amin <saiful(a)semanticconsulting.com> --- (In reply to Jonathan Druart from comment #11) > If we consider that it is a data migration issue I think we should start > writing a script to catch them. > > See also bug 20509. > > We cannot deal everywhere with such inconsistency, and if we do it in this > script, we need to do it everywhere else. > > I would prefer to see a misc script searching for any kinds of data > inconsistency in DB. We will then improve it incrementally. Separate script idea to check data inconsistency is good one. It will save lot of time in fixing issues, such as missing foreign keys. I still don't think scripts should break on missing/bad data. For example, I've observed that bulkmarcimport.pl breaks if 245$c contains Arabic date. Ideally, it should warn and skip the record if it can't process the data. I'm not sure if this is by design. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '18

25 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #35 from Josef Moravec <josef.moravec(a)gmail.com> --- I squashed the original patches for better readability, but then added 4 new follow-ups ;) I tried to reflect the last changes in codebase and coding guidelines. (things are changing quickly). Note for QA: the feature is working OK, but there are definitely some areas where the code could be improved. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '18

25 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #34 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 76392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76392&action=ed… Bug 15326: (follow-up) Fix tools menu highlighting Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '18

25 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #33 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 76391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76391&action=ed… Bug 15326: (follow-up) Don't make links to unpublished pages in opac Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '18

25 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #32 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 76390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76390&action=ed… Bug 15326: (follow-up) Move js to footer, use Asset plugin Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '18

25 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #31 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 76389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76389&action=ed… Bug 15326: (follow-up) utf8 to utf8mb4 Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '18

25 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #30 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 76388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76388&action=ed… Bug 15326: (follow-up) Add CMS feature This patch builds on Martin Persson's patch. I made a few changes that improve the patch and make this feature functional. The only thing I am not completely satisfied with (and doesn't reliably work) is the navigation for the CMS pages on both the staff side and the OPAC side. This needs work. Otherwise the CMS feature works. - Make sure you update database after applying patch - After adding a few pages, confirm that filtering results works (play with different combinations of display location, library and language) - Confirm that pages with specific locations ONLY show up in those locations, i.e. OPAC pages can only be accessed in OPAC and staff interface pages can only be accessed on staff client - Confirm that table is showing correct data, particularly language, location and library - Confirm that if page has not been published and user does not have permission to edit pages, page content will not display on OPAC side. On staff side, a message will show saying that page has not been published - Confirm pagination for table shows and works - Confirm deleting pages works as expected (confirm message before delete) - Confirm link title must be unique when adding new pages - Confirm that editing the details of an existing page works - Confirm that adding a child page will only work if the location of child page matches location of parent page, i.e., if parent page is an OPAC page then child page must also be OPAC page. if parent page is in all locations then child page can be in all or either interface(s) - Confirm Select All/Clear All toggle works - Confirm viewing of CMS pages in OPAC and in staff client works and looks nice Sponsored-by: Region Halland Bug 15326: [FOLLOW-UP] Many fixes This patch: - moves action buttons into a dropdown, adds a delete button to dropdown - fixes the tests (they should now all pass) - fixes qa tool problems - removes the Koha::CmsPages->remove() method (unnecessary) - makes changes to the Koha::CmsPages->add() method (now simpler, easier to test) This is now ready to test. Sponsored-by: Catalyst IT Bug 15326: [FOLLOW-UP] More fixes This patch removes the t/Pages.t file because it isn't required, and other unused methods. This patch is ready to test. The appropriate tests are in t/db_dependent/Pages.t Bug 15326: [FOLLOW-UP] adding and editing fixes Sorry, did not see the second half of your comment. This patch should fix the adding and editing issues in Comment 16. Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing Fixes issues from Comment 19, please test Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0