June 2018 - Koha-bugs - lists.koha-community.org

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '18

14 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #141 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 76087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76087&action=ed… Bug 12395: Use standard <fieldset> + <ol> markup for showorder.tt Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '18

14 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #140 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 76086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76086&action=ed… Bug 12395: (QA follow-up) Add class/id to body tag Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '18

14 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #139 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 76085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76085&action=ed… Bug 12395: Make received orders table consistent with pending orders table (links of More column) Also change "Created by" with "Ordered by" in receive page. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '18

14 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #138 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 76084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76084&action=ed… Bug 12395: Display created_by even if firstname is missing on receiving On receiving orders, "no name" was displayed if the firstname of creator was not filled. The surname should be displayed. Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '18

14 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #137 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 76083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76083&action=ed… Bug 12395: Add unit test to check created_by is correctly set Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '18

14 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76074|0 |1 is obsolete| | Attachment #76075|0 |1 is obsolete| | Attachment #76076|0 |1 is obsolete| | Attachment #76077|0 |1 is obsolete| | Attachment #76078|0 |1 is obsolete| | Attachment #76079|0 |1 is obsolete| | Attachment #76080|0 |1 is obsolete| | Attachment #76081|0 |1 is obsolete| | --- Comment #136 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 76082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76082&action=ed… Bug 12395: Save order line's creator New MySQL column: aqorders.createdby Creator's name is displayed on order's receive pages (acqui/orderreceive.pl and acqui/parcel.pl) On acqui/orderreceive.pl it replace the name of basket's creator On acqui/parcel.pl, to avoid adding more data in the table of pending orders, it is shown in a popup like MARC and Card views Test plan: 1/ Run updatedatabase.pl 2/ Create a new order and go to the receipt page (acqui/parcel.pl) 3/ Click on "Order" link in column "More" (previously "View record") 4/ A javascript popup should appear with your name in it. Close the popup. 5/ Click on "Receive" link 6/ Your name should appear in front of "Created by" label, to the right of the page. Patch updated with use of atomic update. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '18

14 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #135 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Forgot the signed-off-by line, reattaching... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '18

14 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #134 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Julian Maurice from comment #125) > (In reply to Jonathan Druart from comment #124) > > (In reply to Jonathan Druart from comment #113) > > > Bug 12395: Save order line's creator > > > reverts bug 20303 > > > > This one is still missing I think. > > These changes are intended. orderreceive.pl doesn't use > aqbaskets.authorisedby anymore (with those patches applied) Indeed! I have tested to delete the account of the creator and receive an order and it seems ok. The screen displays "Ordered by: " and nothing in front. Maybe we could add something to explain why it's empty. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '18

14 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #133 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 76081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76081&action=ed… Bug 12395: Add FK constraint and use patron-title.inc Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '18

14 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #132 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 76080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76080&action=ed… Bug 12395: (QA follow-up) Change wording for consistency and fix use CGI; Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0