June 2018 - Koha-bugs - lists.koha-community.org

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '18

08 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #31 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Katrin Fischer from comment #27) > 1) Releatives tab doesn't open. JavaScript error: > Error: Syntax error, unrecognized expression: ##relatives-issues-table Fixed in the last patch > 2) I think most libraries will have a mix of large accounts and smaller > ones. Could it make sense to use the server side processing when the patron > has a certain number of checkouts (configurable)? It makes sense, but I think than can go in a separate bug. Do you agree ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12027] Shibboleth authentication for staff client
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '18

08 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '18

08 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 --- Comment #30 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 75913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75913&action=ed… Bug 15219: Fix relatives issues table -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '18

08 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74225|0 |1 is obsolete| | --- Comment #29 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 75912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75912&action=ed… Bug 15219: Fix date sorting when server-side processing is disabled Use DataTables 'columns' option instead of 'aoColumns' This allow more control on what data is used for display, sorting, filtering, ... A large part of this patch is about rewording things to better match the DataTables documentation. The real change is that "mRender": renderingFunc becomes "render": { "display": renderingFunc } So the return value of renderingFunc is now only used for display (not for filtering, sorting, ...) Signed-off-by: Eric Gosselin <eric.gosselin(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '18

08 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74224|0 |1 is obsolete| | --- Comment #28 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 75911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75911&action=ed… Bug 15219: Server-side processing and pagination on checkouts tables Some libraries have patrons with more than 1000 checkouts. Loading all of them at once can be very long, and sometimes can cause timeout errors. This patch prevent that by enabling server-side processing and pagination on checkouts tables. This affects patron's checkouts and patron's relatives' checkouts tables on pages circ/circulation.pl and members/moremember.pl. As server-side processing can be useless and cumbersome with small sets of data, a new system preference is introduced to control this behaviour (server-side processing is disabled by default). Additionally, this patch: - adds a switch to turn off and on row grouping (today's checkouts vs previous checkouts) (on by default) - adds "column settings" for relatives' checkouts tables - factorize some code that was duplicated across the two DataTables configurations (mDataProp) Test plan: 1. Find (or create) a patron that have at least 10 checkouts and where the relatives checkouts table contain at least 10 checkouts. 2. Go to the patron's detail page and check everything works fine in both tables (sorting, pagination, the data itself, ...) 3. Do the same on circulation page (circulation.pl) 4. Enable system preference ServerSideCheckoutsTable 5. Repeat steps 2 and 3 Signed-off-by: Eric Gosselin <eric.gosselin(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '18

08 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #244 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '18

08 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75004|0 |1 is obsolete| | --- Comment #243 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 75909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75909&action=ed… Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. This patch also adds 3 columns: - No. of ordered titles - No. of received titles - Date closed It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '18

08 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75003|0 |1 is obsolete| | --- Comment #242 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 75908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75908&action=ed… Bug 11708: Change aqbasketgroups.closed to closeddate Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '18

08 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #123 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Jonathan Druart from comment #114) > 2. Why not a foreign key on aqorders.created_by (with on delete set null)? > > 3. orderreceive.tt and showorder.tt must use patron-title.inc Fixed in the last patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '18

08 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #122 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 75907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75907&action=ed… Bug 12395: Add FK constraint and use patron-title.inc Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0