July 2018 - Koha-bugs - lists.koha-community.org

[Bug 11983] code to select patrons to purge needs to be centralized
by bugzilla-daemon＠bugs.koha-community.org 20 Jul '18

20 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #12 from David Cook <dcook(a)prosentient.com.au> --- Sounds good to me. I'm all for having method naming conventions. With Perl's "method names as strings" (https://perldoc.perl.org/perlobj.html#Method-Call-Variations) I think you can get the flexibility of Option 1 while using the code in Option 2. my $method = "filter_by_$arg"; my $filtered = $obj->$method(); Boom! And yeah by standardizing method naming conventions, I think we could potentially see some code re-use for methods that are more complex than your average DIBC methods but less complex than super unique methods. You can do some cool stuff with aliasing functions so that you can have different module-specific names for the same generic method as well, so you might get that relevant API while still having code re-use. I see nothing to disagree with (which must be novel considering it's me). Awesome ideas, Martin! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 20 Jul '18

20 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #34 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 77145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77145&action=ed… Bug 8628: [FOLLOW-UP] Fixing internal server error and rebase issues This patch addresses the comments in Comment 23 Test that 1) all qa test tools pass 2) datatable on tools/signs.pl is not broken 3) features uses report group "SIGN" instead of "SIG" 4) you can complete the main test plan (no server errors) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 20 Jul '18

20 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 20 Jul '18

20 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77028|0 |1 is obsolete| | --- Comment #33 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 77144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77144&action=ed… Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 20 Jul '18

20 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77027|0 |1 is obsolete| | --- Comment #32 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 77143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77143&action=ed… Bug 8628: [FOLLOW-UP] More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 20 Jul '18

20 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77026|0 |1 is obsolete| | --- Comment #31 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 77142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77142&action=ed… Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 20 Jul '18

20 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77025|0 |1 is obsolete| | --- Comment #30 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 77141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77141&action=ed… Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13618] Prevent XSS in the Staff Client and the OPAC
by bugzilla-daemon＠bugs.koha-community.org 19 Jul '18

19 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #219 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I am back! Next version has been pushed to the remote branch - https://gitlab.com/joubu/Koha/commits/bug_13618 Here is commit message of the main patch: As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Please test! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15428] Different timeout preference for opac and intranet
by bugzilla-daemon＠bugs.koha-community.org 19 Jul '18

19 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13560] Add an 'Add' option in MARC modification templates
by bugzilla-daemon＠bugs.koha-community.org 19 Jul '18

19 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

1 0