July 2018 - Koha-bugs - lists.koha-community.org

[Bug 13618] Prevent XSS in the Staff Client and the OPAC
by bugzilla-daemon＠bugs.koha-community.org 19 Jul '18

19 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #219 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I am back! Next version has been pushed to the remote branch - https://gitlab.com/joubu/Koha/commits/bug_13618 Here is commit message of the main patch: As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Please test! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15428] Different timeout preference for opac and intranet
by bugzilla-daemon＠bugs.koha-community.org 19 Jul '18

19 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13560] Add an 'Add' option in MARC modification templates
by bugzilla-daemon＠bugs.koha-community.org 19 Jul '18

19 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13560] Add an 'Add' option in MARC modification templates
by bugzilla-daemon＠bugs.koha-community.org 19 Jul '18

19 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #23 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 19 Jul '18

19 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77066|0 |1 is obsolete| | --- Comment #31 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 77136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77136&action=ed… Bug 12001: [17.11.X] Remove simple calls to GetMemberAccountRecords I chose not to backport the main patchset as it was big and didn't apply clean, however, this problem seems to be an issue in 17.11.x This patchset removes the calls where only the total is fetched/used Please consider for backport To test: 1 - Have a patron with some fines 2 - View these pages and confirm fine amounts display: circ/circulation.pl opac/opac-main.pl opac/opac-reserve.pl opac/opac-user.pl reserve/request.pl 3 - Apply patch 4 - View pages again, confirm fines display correctly and no errors -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8676] Show vendor name in source of acquisition
by bugzilla-daemon＠bugs.koha-community.org 19 Jul '18

19 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 --- Comment #8 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Keshav Gupta from comment #7) > This seems to be some Template data related issue. Is anyone find Solution > for the same??? This bug report confirms that the problem exists, and the lack of a patch on this bug report indicates that there isn't a solution yet. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11983] code to select patrons to purge needs to be centralized
by bugzilla-daemon＠bugs.koha-community.org 19 Jul '18

19 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #11 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Hmm. At first glance option 1 shows less code lines and more flexibility with parameters. It might be easier to switch one parameter than selecting another method each time ? But no strong opinion here, and not studied it in detail.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11983] code to select patrons to purge needs to be centralized
by bugzilla-daemon＠bugs.koha-community.org 19 Jul '18

19 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #10 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Thanks for the review, Jonathan :) I far prefer option 2 too now I've written it. I think splitting out the final combinations for script + tool interfaces into their own subclasses also makes sense. Regarding your remarks: - Interesting regarding the join.. perhaps my brain is failing me but I couldn't see how I could do it without the having (whilst maintaining chainability). Happy to be guided here.. I might ask ribasushi for his thoughts there :) - Coming up with method names was almost the hardest bit of this and I'm more than happy to be advised here.. What I would like to see is a fairly standardised recommendation for method names of this type as a guideline. We came up with 'filter_by_' to denote that you are filtering the resultset down. Following that by the 'how' and 'what' makes sense. It's describing the 'how' and 'what' which is causing fun here.. - `last_issued` could be more clearly written as `when_last_issued` perhaps? - oh, did I get the standardisation wrong.. I thought we'd gone from 'checkout' to 'issue', my bad.. that should also be corrected in the above one too. - I'm fine with has_pending_checkouts, I can't think of anything better or more descriptive. I think it is used in cleanborrowers (only it's hidden inside other filters) - 'has' vs 'have'.. hmm, we're in Koha::Patrons so 'have' is right.. thanks - I actually made this one flexible at someone's request.. though I can't remember who.. perhaps it would be better as distinct methods.. more than happy to get some discussion going here. I shall try to raise all this at the next dev meeting.. see if we can bring some more people into the conversation. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13779] sessionID declared twice in C4::Auth::checkauth()
by bugzilla-daemon＠bugs.koha-community.org 19 Jul '18

19 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13779 --- Comment #2 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 77099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77099&action=ed… Bug 13779 - sessionID declared twice in C4::Auth::checkauth() The bug is that $sessionID is declared twice in C4::Auth::checkauth(). At the moment, this doesn't actually create a problem, because no one seems to be using the $sessionID which is returned by checkauth(), except in the case of opac/external/overdrive/auth.pl which skips the second declartion as it doesn't require auth. This patch removes the redefining of the $sessionID variable. In terms of testing, try logging in with a username and password and see if it works. The only risk this patch would pose is breaking auth I would think, since nothing is actually using the return value from checkauth() for $sessionID. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13779] sessionID declared twice in C4::Auth::checkauth()
by bugzilla-daemon＠bugs.koha-community.org 19 Jul '18

19 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13779 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0