July 2018 - Koha-bugs - lists.koha-community.org

[Bug 6647] Label item search should use standard pagination routine
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '18

07 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76748|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 76750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76750&action=ed… Bug 6647: Label item search should use standard pagination routine This patch doesn't fix how pagination links are generated for the label item search results, but it does modify the template so that the pagination links are styled like they are on catalog search results. To test, apply the patch and go to Tools -> Labels. - Open or create a label batch. - Click "Add items" to trigger the pop-up search window. - Perform a search which would return multiple results. - Confirm that the style of the pagination bar matches the one on the catalog search results page. - Confirm that current-page number highlighting works correctly. Signed-off-by: Maryse Simard <maryse.simard(a)inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6647] Label item search should use standard pagination routine
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '18

07 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6647] Label item search should use standard pagination routine
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '18

06 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75858|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 76748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76748&action=ed… Bug 6647: Label item search should use standard pagination routine This patch doesn't fix how pagination links are generated for the label item search results, but it does modify the template so that the pagination links are styled like they are on catalog search results. To test, apply the patch and go to Tools -> Labels. - Open or create a label batch. - Click "Add items" to trigger the pop-up search window. - Perform a search which would return multiple results. - Confirm that the style of the pagination bar matches the one on the catalog search results page. - Confirm that current-page number highlighting works correctly. Signed-off-by: Maryse Simard <maryse.simard(a)inlibro.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6647] Label item search should use standard pagination routine
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '18

06 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5539] Options for Suggestion Emails
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '18

06 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5539 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1971] Suggestion : Should have only one entry by title + a counter of waiting persons
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '18

06 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1971 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14049] Ability to add custom fields to OPAC purchase suggestion form
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '18

06 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14049 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6828] Add Admin Dashboard for staff users.
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '18

06 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1884] Managing Suggestions - way to archive/clean up approved/rejected orders
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '18

06 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1884 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11983] code to select patrons to purge needs to be centralized
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '18

06 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #8 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- So the core proposal here is that we stop adding `->search_for_functionality_x` methods to the DB level Koha::Objects and rather add generalized filters for complex joins etc if we need to. If we really want to add a `for_functionality_x` method/routine to centralize code for say patron manipulations (where we may have a UI and Script driven element) we should break that out into a subclass of some kind that contains the functions/methods for just that area of functionality. Koha::Patron::BulkActions perhaps as an example.. containing `->bulk_selection(filter_a, filter_b)` which internally just calls either a large constructed query (like the code in option 1) or a chained set of queries (from option 2) and then various available `->bulk_actions` that may be applied to the selected set. `->bulk_delete`, `bulk_anonymise`, `bulk_modify` for example? Thoughts? -- You are receiving this mail because: You are watching all bug changes.

1 0