August 2018 - Koha-bugs - lists.koha-community.org

[Bug 13618] Prevent XSS in the Staff Client and the OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '18

09 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #222 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Owen Leonard from comment #221) > I did what I hope was a fairly thorough test of the staff client and found > these issues: > > - IntranetCirculationHomeHTML displays HTML tags as text Done, specific patch for this pref. > - Patron title include showing HTML: <span > class="patron-title">Mr</span> Done, see specific patch. > - Patron details -> Holds tab: Alerts data from the branches table Done, that was tricky and a part I forgot, we need to escape data using JS, see String.prototype.escapeHtml > - Search results page layout is broken. Looks like page-numbers.inc has a > section missing. Ooops, wrong merge conflict resolution. > - Crazy encoding of action buttons on Lists page > - Incorrectly escaped HTML in Notices & slips list Both fixed now. > - Label batch list title encoding wrong > - Spine label print shows HTML Fixed but follow-ups needed (TODO LATER) > - Administration -> Libraries: Alerts data from the branches table It comes from opac_info, which can contain html characters. See admin/branches.tt: library.opac_info is not escaped (" | $raw") > - Administration -> Item types: Alerts data from the items table Same as before for itemtype.checkinmsg. I have added a patch for the missing $raw filter to make it explicit. > - Item searching broken: "Unsupported format html at > /home/vagrant/kohaclone/catalogue/itemsearch.pl line 42." Done, that was a hard one! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '18

09 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Paul Hoffman <paul(a)flo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul(a)flo.org --- Comment #27 from Paul Hoffman <paul(a)flo.org> --- FYI, in our Koha instance (17.11.04) I had to use this in IntranetUserJS: <option value="Other-control-number,phr"> Instead of this: <option value="Other-control-number"> Without ",phr" I found it was doing a ",wrdl" search which failed. Others may find that this is not necessary, but I mention it here for anyone who stumbles upon this only to find that the suggested code doesn't work for them. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '18

09 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #89 from Cab Vinton <bibliwho(a)gmail.com> --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 14957: <h1>Something went wrong !</h1>Applying: Bug 14957 - Rule based permission for MARC fields .git/rebase-apply/patch:871: trailing whitespace. } warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M C4/Biblio.pm M cataloguing/addbiblio.pl M koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc M koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt M misc/migration_tools/bulkmarcimport.pl .git/rebase-apply/patch:871: trailing whitespace. } warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging misc/migration_tools/bulkmarcimport.pl CONFLICT (content): Merge conflict in misc/migration_tools/bulkmarcimport.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc Auto-merging cataloguing/addbiblio.pl Auto-merging C4/Biblio.pm Patch failed at 0001 Bug 14957 - Rule based permission for MARC fields The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. error: Failed to merge in the changes. Bug 14957 - Write protecting MARC fields based on source of import 76208 - Bug 14957 - Rule based permission for MARC fields 76209 - Bug 14957 - Refactor and fix tests and documentation 76210 - Bug 14957 - Remove exports of removed subroutines Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-14957---Rule-based-permission-for-MARC-fields-eC50px.patch . -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12759] Add ability to pass list contents to batch record modification/deletion tools
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '18

09 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 Cab Vinton <bibliwho(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho(a)gmail.com --- Comment #28 from Cab Vinton <bibliwho(a)gmail.com> --- Tested in Biblibre Sandbox no. 2. Unable to select Authorities radio button under either Batch Record Modification or Deletion tool. No problems deleting records, or modifying/ adding content to a MARC field appearing in the editor, using a list as a source of records. Perhaps unrelated, but was unable to add content to a field that was not visible in the MARC editor (e.g., 945, 970). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '18

09 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #50 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Julian Maurice from comment #49) > Are you asking for a 2nd signoff ? Yes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '18

09 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #276 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Rebased again. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '18

09 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76710|0 |1 is obsolete| | --- Comment #275 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 77626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77626&action=ed… Bug 11897: Stockrotation The stock rotation feature adds a batch process to automate rotation of catalgue items with a staff client page under tools to manage rotas/schedules. Once a rota is configured, and your staff user has the right permissions to allocate items, then an additional tab will appear on biblio records allowing the management of of which rota, if any, individual items belong to. It also includes a cron script to process the items on a daily basis. Signed-off-by: Kathleen Milne <kathleen.milne(a)cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '18

09 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76708|0 |1 is obsolete| | --- Comment #274 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 77625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77625&action=ed… Bug 11897: DBIX::Class::Ordered in Stockrotationstage. * Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add grouping_column. Signed-off-by: Kathleen Milne <kathleen.milne(a)cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '18

09 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76707|0 |1 is obsolete| | --- Comment #273 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 77624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77624&action=ed… Bug 11897: DO NOT PUSH: Add stock rotation schema files. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Item.pm: New file. * Koha/Schema/Result/Stockrotationitem.pm: New file. * Koha/Schema/Result/Stockrotationrota.pm: New file. * Koha/Schema/Result/Stockrotationstage.pm: New file. Signed-off-by: Kathleen Milne <kathleen.milne(a)cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '18

09 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76706|0 |1 is obsolete| | --- Comment #272 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 77623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77623&action=ed… Bug 11897: Add Stock Rotation atomic update schema. * installer/data/mysql/atomicupdate/stockrot_tables.sql: New file. * installer/data/mysql/kohastructure.sql (stockrotationrotas) (stockrotationstages, stockrotationitems): New tables. * installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs. * installer/data/mysql/userflags.sql: Add Stockrotaiton userflag. * installer/data/mysql/userpermissions.sql: Add Stockrotation userpermissions. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add Stockrotation menu. Signed-off-by: Kathleen Milne <kathleen.milne(a)cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0