September 2018 - Koha-bugs - lists.koha-community.org

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78558|0 |1 is obsolete| | --- Comment #44 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 79198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79198&action=ed… Bug 15219: Do not call escapeHtml on null values -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78557|0 |1 is obsolete| | --- Comment #43 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 79197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79197&action=ed… Bug 15219: Fix relatives issues table -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78556|0 |1 is obsolete| | --- Comment #42 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 79196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79196&action=ed… Bug 15219: Fix date sorting when server-side processing is disabled Use DataTables 'columns' option instead of 'aoColumns' This allow more control on what data is used for display, sorting, filtering, ... A large part of this patch is about rewording things to better match the DataTables documentation. The real change is that "mRender": renderingFunc becomes "render": { "display": renderingFunc } So the return value of renderingFunc is now only used for display (not for filtering, sorting, ...) Signed-off-by: Eric Gosselin <eric.gosselin(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78555|0 |1 is obsolete| | --- Comment #41 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 79195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79195&action=ed… Bug 15219: Server-side processing and pagination on checkouts tables Some libraries have patrons with more than 1000 checkouts. Loading all of them at once can be very long, and sometimes can cause timeout errors. This patch prevent that by enabling server-side processing and pagination on checkouts tables. This affects patron's checkouts and patron's relatives' checkouts tables on pages circ/circulation.pl and members/moremember.pl. As server-side processing can be useless and cumbersome with small sets of data, a new system preference is introduced to control this behaviour (server-side processing is disabled by default). Additionally, this patch: - adds a switch to turn off and on row grouping (today's checkouts vs previous checkouts) (on by default) - adds "column settings" for relatives' checkouts tables - factorize some code that was duplicated across the two DataTables configurations (mDataProp) Test plan: 1. Find (or create) a patron that have at least 10 checkouts and where the relatives checkouts table contain at least 10 checkouts. 2. Go to the patron's detail page and check everything works fine in both tables (sorting, pagination, the data itself, ...) 3. Do the same on circulation page (circulation.pl) 4. Enable system preference ServerSideCheckoutsTable 5. Repeat steps 2 and 3 Signed-off-by: Eric Gosselin <eric.gosselin(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #46 from Josef Moravec <josef.moravec(a)gmail.com> --- Comment on attachment 79188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79188 Bug 11373: Add a "cash register" feature to the fine payment form. Review of attachment 79188: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=113…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt @@ +75,5 @@ > + <div id="change_message" class="dialog message"> > + <span>The amount collected is greater than the total amount paid.</span><br /> > + <strong>Change to give back: [% give_change | $Price %]</strong><br /><br /> > + <input type="submit" name="submitbutton" value="Confirm payment" /> > + <a class="cancel" href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% patron.borrowernumber %]">Cancel</a> use uri filter @@ +120,5 @@ > + [% IF ( give_change ) %] > + <li> > + <label for="paid">Amount paid:</label> > + <input type="hidden" name="paid" id="paid" value="[% amount_paid %]" /> > + <input type="hidden" name="collected" id="collected" value="[% amount_paid %]" /> use html filter @@ +134,5 @@ > + </li> > + [% ELSE %] > + <li> > + <label for="paid">Amount paid:</label> > + <input name="paid" id="paid" value="[% amountoutstanding | format('%.2f') %]" onchange="moneyFormat(document.payform.paid)"/> use $Price filter @@ +141,3 @@ > <li> > + <label for="collected">Collect from patron:</label> > + <input name="collected" id="collected" value="[% amountoutstanding %]" onchange="moneyFormat(document.payform.collected)" /> use $Price filter @@ +233,5 @@ > </li> > + [% IF ( give_change ) %] > + <li> > + <label for="paid">Amount paid:</label> > + <input type="hidden" name="paid" id="paid" value="[% amount_paid %]" /> use html filter @@ +238,5 @@ > + [% amount_paid | $Price %] > + </li> > + <li> > + <label>Collected from patron:</label> > + <input type="hidden" name="collected" id="collected" value="[% amount_paid %]" /> use html filter @@ +248,5 @@ > + </li> > + [% ELSE %] > + <li> > + <label for="paid">Amount paid :</label> > + <input name="paid" id="paid" value="[% total %]" onchange="moneyFormat(document.payform.paid)" /> use $Price filter @@ +259,3 @@ > [% END %] >  > + <input name="collected" id="collected" value="[% total %]" onchange="moneyFormat(document.payform.collected)"/> use $Price filter -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from Josef Moravec <josef.moravec(a)gmail.com> --- The information on this page is duplicate: https://screenshots.firefox.com/o2GtPtGugLjtJSqq/localhost why do you even add the dialog? Also this could be enabled disabled, please add system preference for this. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #44 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Josef Moravec from comment #43) > (In reply to Blou from comment #41) > > Fixed the rest, but for the padding in the button, we'll need to find > > another solution since an <input> under a class="dialog message" will show > > like that. Not sure why the staff.css specifies that padding, but clearly > > having a confirm button in a message dialog is not the standard Koha way. > > That is because you should have icon on that button - try to add a > class="approve" to button. And add the icon itself like this: <i class="fa fa-fw fa-check"></i> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |josef.moravec(a)gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #43 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Blou from comment #41) > Fixed the rest, but for the padding in the button, we'll need to find > another solution since an <input> under a class="dialog message" will show > like that. Not sure why the staff.css specifies that padding, but clearly > having a confirm button in a message dialog is not the standard Koha way. That is because you should have icon on that button - try to add a class="approve" to button. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10060] Self Checkout module does not honour circ control
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10060 --- Comment #8 from Oliver Behnke <oliver.behnke(a)aei.mpg.de> --- (In reply to Katrin Fischer from comment #6) > Could using a separate self-check user for each branch solve the problem? Katrin, is this already possible or are you suggesting a new feature? I'd love to try that if it's already supported but I don't see how. Cheers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0