September 2018 - Koha-bugs - lists.koha-community.org

[Bug 20730] Missing authentication check in serials/routing.pl
by bugzilla-daemon＠bugs.koha-community.org 15 Sep '18

15 Sep '18

1 0

[Bug 15139] Show non-public item note in overdues report
by bugzilla-daemon＠bugs.koha-community.org 15 Sep '18

15 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139 --- Comment #6 from Spencer <ssmith3(a)mckinneytexas.org> --- Also, this shows up in the header- <<<<<<< HEAD ======= >>>>>>> Bug 15139: Add non-public item notes to overdue report -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15139] Show non-public item note in overdues report
by bugzilla-daemon＠bugs.koha-community.org 15 Sep '18

15 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139 Spencer <ssmith3(a)mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ssmith3(a)mckinneytexas.org --- Comment #5 from Spencer <ssmith3(a)mckinneytexas.org> --- Created attachment 78871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78871&action=ed… screenshot of results The report exports correctly, but the columns do not line up correctly in Koha's display. (http://staff-spicypeanut.sb1.sandboxes.bywatersolutions.com/cgi-bin/koha/ci…) See attached screenshot for example. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page
by bugzilla-daemon＠bugs.koha-community.org 15 Sep '18

15 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely(a)hotmail.com, | |koha(a)univ-lyon3.fr --- Comment #12 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- I can't reproduce this one. Could some else test it ? cc Claire as she's a bug wrangler. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 10869] can't delete order line if title deleted
by bugzilla-daemon＠bugs.koha-community.org 15 Sep '18

15 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #86 from Chris Cormack <chris(a)bigballofwax.co.nz> --- I've rebased and tried to fix things Séverine, I don't know how well it works but if you could test it would be good -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10869] can't delete order line if title deleted
by bugzilla-daemon＠bugs.koha-community.org 15 Sep '18

15 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29668|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10869] can't delete order line if title deleted
by bugzilla-daemon＠bugs.koha-community.org 15 Sep '18

15 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27292|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10869] can't delete order line if title deleted
by bugzilla-daemon＠bugs.koha-community.org 15 Sep '18

15 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #85 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 78864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78864&action=ed… Bug 10869 Followup: Unit tests for DelOrder [The best would be to add a second sign-off to this patch, as I had to to a little change, to take into account the recent rewrite of t/db_dependent/Acquisition.t: $ordernumber3 is now $ordernumbers[2] Mathieu Saby] DelOrder now returns undef if no ordernumber passed. This patch also adds unit tests for DelOrder. Test plan: A. With syspref AcqCreateItem = on placing an order 1. Fill a basket with some orders (some records with already existing items or holds, some without items). New items linked with the order will be created 2. Keep the basket open 3. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 4. In the basket, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 5. After deleting the order, check there is a new line in the "Deleted orders" table 6. Regression test : try to delete other orders, and check the deletion of the order implies the deletion of items created when ordering a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. After you have deleted it, the items created when ordering must have been deleted. 7. Add some other orders to your basket (some records with already existing items or holds, some without items). New items linked with the order will be created 8. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 9. Close the basket 10. Go on receipt page 11. Search the orders of your basket 12. In receipt page, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 13. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. After you have deleted it, the items created when ordering must have been deleted. B. With syspref AcqCreateItem = on receiving an order 1. Fill a basket with some orders (some records with already existing items or holds, some without items). 2. Keep the basket open 3. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 4. In the basket, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 5. After deleting the order, check there is a new line in the "Deleted orders" table 6. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. 7. Add some other orders to your basket (some records with already existing items or holds, some without items). 8. In the catalog, supress all the items attached to one of the record used in the basket, then suppress the record 9. Close the basket 10. Go on receipt page 11. Search the orders of your basket 12. In receipt page, check you can delete the order that was using deleted record (click on link "Delete order" in the right column of the table) 13. Regression test : try to delete other orders a/ If no items were attached to the record before you created the basket, you can delete some other orders, AND their record. Try to delete order and record. b/ If some items were attached to the record before you created the basket, you can delete some other orders, BUT NOT their record. Try to delete only order. And to test the UT: prove t/db_dependent/Acquisition.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Amended the patch as to removing biblio parameter in DelOrder. There is no need to remove the parameter if you will search for biblionumber later on. Deleting records in aqorders_items is discussed on bug 11617. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10869] can't delete order line if title deleted
by bugzilla-daemon＠bugs.koha-community.org 15 Sep '18

15 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #84 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 78863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78863&action=ed… Bug 10869: Followup : update the receipt page (parcel.tt) (Fixed after test by Lyon3 : a bad name was used for a variable. Now "Deleted record..." should NOT be displayed if the record has not been deleted) In main patch, I forgot to made some changes in the parcel.tt page This patch fixes that bu giving the librarian the ability to cancel an order in receipt page if the record is deleted. It also displays the message "Deleted bibliographic record, can't find title" in Summary Note that this behavior will be improved by bug 10758 To test : - create a basket and an order - delete the record used by that order - go on receipt page - in the line matching this order, you should see instead of the title "Deleted bibliographic record, can't find title" - click on "Delete order" : you should be able to delete the order - go to the basket, to check the order was properly cancelled - in receipt page, try to delete an other order (always linked to a record), to be sure there is no regression -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10869] can't delete order line if title deleted
by bugzilla-daemon＠bugs.koha-community.org 15 Sep '18

15 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26692|0 |1 is obsolete| | --- Comment #83 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 78862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78862&action=ed… Bug 10869: Allow the deletion of order line if the record is deleted This patch fixes 2 issues : (medium issue) It is not possible to delete an order in a basket if the biblio record is deleted. (minor issue) There is a useless hyperlink around "Deleted bibliographic notice", and "notice" is a frenchism for "record" Biblionumber was passed to the function as 1st parameter, which made impossible to suppress an order whose associated biblio record was suppressed. Moreover, the biblionumber is not needed to get and suppress the order, but only to suppress items, in a second step. Change made to Acquisitions::DelOrder: - I changed the order of the 2 parameters: now $ordernumber as 1st parameter and $biblionumber as 2d parameter - I renamed $bibnum to $biblionumber - I removed $biblionumber from the main SQL query of the function - I suppressed useless $sth->finish - if no $biblionumber is provided, Koha does not try to suppress the items linked created by acq process Change made to the calls to Acquisitions::DelOrder in Koha's code, to change the order of the parameters - in addorder.pl - in basket.pl - in UT t/db_dependant/Acquisition.t Change made in template basket.tt. This bug was signed off by Cedric some time ago, but it needs a second sign off, because I had to made some little changes. To test : 1. Fill a basket with some records (some records with items or holds, some without items) 2. Supress one of the record 3. In the basket (refresh the screen) check that "Deleted bibliographic notice" line was replaced with "Deleted bibliographic record", without hyperlink arround 4. Delete this order with the link "Delete order" to the right column of the table 5. Check there is a new line in the "Deleted orders" table 6. Check there is no regression : delete an other order (one with no item), then check you cannot delete an order with an item (like before patch) Signed-off-by: Cedric Vita <cedric.vita(a)dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

1 0