September 2018 - Koha-bugs - lists.koha-community.org

[Bug 13779] sessionID declared twice in C4::Auth::checkauth()
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '18

07 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13779 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21325 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13779] sessionID declared twice in C4::Auth::checkauth()
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '18

07 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13779 --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 78528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78528&action=ed… Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl Script offline_circ/download.pl does not use the return values of checkauth. So should not assign them to bad chosen variables that do not correspond with checkauth but with get_template_and_user. Test plan: Look for $template, $loggedinuser, $cookie, $flags in the code. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13779] sessionID declared twice in C4::Auth::checkauth()
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '18

07 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13779 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78452|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 78527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78527&action=ed… Bug 13779: sessionID declared twice in C4::Auth::checkauth() The bug is that $sessionID is declared twice in C4::Auth::checkauth(). At the moment, this doesn't actually create a problem, because no one seems to be using the $sessionID which is returned by checkauth(), except in the case of opac/external/overdrive/auth.pl which skips the second declartion as it doesn't require auth. This patch removes the redefining of the $sessionID variable. In terms of testing, try logging in with a username and password and see if it works. The only risk this patch would pose is breaking auth I would think, since nothing is actually using the return value from checkauth() for $sessionID. NOTE: It was initially defined near the top of the function (~line 791). I believe the scoping would mean the correct version of $sessionID would be used in the latter lines for the unset'ing. I have skimmed code to see if the sessionID return value is used. I did not test overdrive, as I do not know how. However, this is the only area, I think this could possibly break. This change makes sense to me. QA: Please test overdrive. opac/external/overdrive/auth.pl only checks if the value is set, so this patch might fix/break something there? opac/svc/overdrive same kind of check. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> This is a (tiny) code improvement. Now we consistently return the session id that is also stored in the returned cookie. (Which can be an 'anon' session.) Fact is that Koha almost everywhere ignores the returned session id and sometimes gets the session from the cookie (obviously). The session id is also passed to the template by get_template_and_user but never used in templates. As mentioned, the two overdrive scripts are the exception. But since both test on both $user && $sessionID, they will not choke on an anynonomous session id without userid. So theoretically fine, but not tested. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13779] sessionID declared twice in C4::Auth::checkauth()
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '18

07 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13779 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '18

07 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13779] sessionID declared twice in C4::Auth::checkauth()
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '18

07 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13779 --- Comment #6 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- This looks good to me so far, but I will finish it just later today or Monday. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13779] sessionID declared twice in C4::Auth::checkauth()
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '18

07 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13779 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #5 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13779] sessionID declared twice in C4::Auth::checkauth()
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '18

07 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13779 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |dcook(a)prosentient.com.au CC| |m.de.rooy(a)rijksmuseum.nl QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | --- Comment #4 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Please use the assignee field, David. Thx. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '18

06 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #90 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78495&action=ed… Bug 7534: (RM follow-up) Fix TT syntax -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20066] New: Remove forbidden patterns from .inc and .tt files
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '18

06 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066 Bug ID: 20066 Summary: Remove forbidden patterns from .inc and .tt files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: indradg(a)l2c2.co.in QA Contact: testopia(a)bugs.koha-community.org The following files contain forbidden patterns a) includes/datatables.inc => [% interface %] instead of [% themelang %] b) modules/opac-auth-MARCdetail.tt => hard-coded path c) modules/opac-auth-detail.tt => hard-coded path This patch removes these. -- You are receiving this mail because: You are watching all bug changes.

1 7