January 2019 - Koha-bugs - lists.koha-community.org

[Bug 22216] New: Make {GET|PUT} /patrons/{patron_id} staff only
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '19

26 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22216 Bug ID: 22216 Summary: Make {GET|PUT} /patrons/{patron_id} staff only Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST api Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com Target Milestone: --- Now that we voted to have a /public namespace for unprivileged access endpoints, the existing /patrons endpoint needs to be adapted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 22015] New: Move DataTables CSS to global include
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '19

26 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22015 Bug ID: 22015 Summary: Move DataTables CSS to global include Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- We now use DataTables on so many pages in the staff client it doesn't make sense to have to include DataTables CSS on each page where we need it. I propose to move datatables.css and buttons.dataTables.min.css into doc-head-close.inc -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 21427] New: Format prices on ordered/spent lists
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '19

26 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21427 Bug ID: 21427 Summary: Format prices on ordered/spent lists Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org On bug 19271 we decided that the work to fix the prices should be split out into it's own bug. Leaving all credit to Katrin for spotting the issue and the initial patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 19778] New: Move template JavaScript to the footer: Serials, part 4
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '19

25 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19778 Bug ID: 19778 Summary: Move template JavaScript to the footer: Serials, part 4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 17858 +++ This bug was initially created as a clone of Bug #19777 +++ In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for even more of the serials templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 20174] New: Remove xml_sax.pl target from Makefile.pl
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '19

25 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20174 Bug ID: 20174 Summary: Remove xml_sax.pl target from Makefile.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org A line was added to Makefile.PL with Bug #5033 but it doesn't seem like it's used anymore? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 19832] New: SIP checkout removes extra hold on same biblio
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '19

25 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19832 Bug ID: 19832 Summary: SIP checkout removes extra hold on same biblio Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: boutrosboutrosboutros(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com C4/SIP/ILS/Transaction/Checkout.pm includes the following bit of code which remove any hold that that matches the biblio and bilbionumber in checkout: # Fill any reserves the patron had on the item. # TODO: this logic should be pulled internal to AddIssue for all Koha. $debug and warn "pending_queue: " . (@$pending) ? Dumper($pending) : '[]'; foreach (grep {$_->{borrowernumber} eq $self->{patron}->{borrowernumber}} @$pending) { $debug and warn "Filling reserve (borrowernumber,biblionumber,reservedate): " . sprintf("(%s,%s,%s)\n",$_->{borrowernumber},$_->{biblionumber},$_->{reservedate}); ModReserveFill($_); # TODO: adjust representation in $self->item } As far as I can tell, this code is completely unnecessary, since C4::Circulation::AddIssue allread calls C4::Reserves::MoveReserve which fullfills the hold. What's more, if the borrower has multiple holds on the same biblio, all of them will be removed. This is clearly wrong. I purpose to remove the code above, unless someone can explain why SIP checkout should behave different than normal checkout in this case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 18114] New: koha-start-* and koha-stop-* should be replaced with the new command style
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '19

25 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18114 Bug ID: 18114 Summary: koha-start-* and koha-stop-* should be replaced with the new command style Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net Commands like koha-start-zebra and koha-stop-sip should be replaced with koha-zebra --start and koha-sip --stop to emulate the newer style used in script like koha-plack -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 8

[Bug 22235] New: Make maintenance scripts use koha-sip instead of koha-*-sip
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '19

25 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22235 Bug ID: 22235 Summary: Make maintenance scripts use koha-sip instead of koha-*-sip Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 17347] New: 'Renew' tab should ignore whitespace at begining and end of barcode
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '19

25 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17347 Bug ID: 17347 Summary: 'Renew' tab should ignore whitespace at begining and end of barcode Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When you copy a barcode from somewhere else, sometimes there is whitespace at the beginning or the end. The checkout tab ignores this, the renew tab should as well. If you enter " validbarcode" the barcode is not found at the moment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 21808] New: Field 711 is not handled correctly in showAuthor XSLT for relator term or code
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '19

25 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21808 Bug ID: 21808 Summary: Field 711 is not handled correctly in showAuthor XSLT for relator term or code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org The following condition in xsl detail opac and staff looks at $j for field 111 but not for field 711 while it should too. The condition can be written a bit easier to read (without self, parent, etc.) <xsl:if test="marc:subfield[@code='4' or @code='e'][not(parent::*[@tag=111])] or (self::*[@tag=111] and marc:subfield[@code='4' or @code='j'][. != ''])"> -- You are receiving this mail because: You are watching all bug changes.

1 13