October 2019 - Koha-bugs - lists.koha-community.org

[Bug 23384] New: Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '20

15 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 Bug ID: 23384 Summary: Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org After spending a while digging into this, I can't explain why it's a problem, but I know that it is and I know how to fix it. During the development of Bug 23112 I encountered a weird problem whereby adding "use Illrequests" to C4/Circulation.pm causes the whole of the app to break with the following error: Bareword "Koha::ArticleRequest::Status::Pending" not allowed while "strict subs" in use at /home/koha-koha/kohaclone/Koha/Patron.pm line 811. Bareword "Koha::ArticleRequest::Status::Processing" not allowed while "strict subs" in use at /home/koha-koha/kohaclone/Koha/Patron.pm line 811. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Illrequest.pm line 37. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Illrequest.pm line 37. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Illrequests.pm line 23. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Illrequests.pm line 23. Compilation failed in require at /home/koha-koha/kohaclone/C4/Circulation.pm line 49. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Circulation.pm line 49. Compilation failed in require at /home/koha-koha/kohaclone/C4/Overdues.pm line 31. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Overdues.pm line 31. Compilation failed in require at /home/koha-koha/kohaclone/C4/Members.pm line 32. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Members.pm line 32. Compilation failed in require at /home/koha-koha/kohaclone/C4/Letters.pm line 30. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Letters.pm line 30. Compilation failed in require at /home/koha-koha/kohaclone/C4/Suggestions.pm line 29. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Suggestions.pm line 29. Compilation failed in require at /home/koha-koha/kohaclone/C4/Acquisition.pm line 25. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Acquisition.pm line 25. Compilation failed in require at /home/koha-koha/kohaclone/C4/Budgets.pm line 27. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Budgets.pm line 27. Compilation failed in require at /home/koha-koha/kohaclone/C4/Biblio.pm line 94. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Biblio.pm line 94. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Biblio.pm line 27. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Biblio.pm line 27. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Biblios.pm line 26. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Biblios.pm line 26. Compilation failed in require at /home/koha-koha/kohaclone/Koha/ArticleRequest.pm line 26. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/ArticleRequest.pm line 26. Compilation failed in require at /home/koha-koha/kohaclone/Koha/ArticleRequests.pm line 26. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/ArticleRequests.pm line 26. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Patrons.pm line 28. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Patrons.pm line 28. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Item.pm line 33. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Item.pm line 33. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Items.pm line 26. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Items.pm line 26. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Checkout.pm line 28. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Checkout.pm line 28. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Checkouts.pm line 25. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Checkouts.pm line 25. Compilation failed in require at /home/koha-koha/kohaclone/C4/Auth.pm line 37. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Auth.pm line 37. Compilation failed in require at /home/koha-koha/kohaclone/admin/preferences.pl line 23. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/admin/preferences.pl line 23. The reference to "preferences.pl" is a red herring and just reflects the page you're on at the time. The rest of the error is the same regardless of the page. Poking around, I've not been able to determine why the usage of Illrequest in Circulation.pm would cause Patron.pm to suddenly complain about Koha::ArticleRequest::Status::* calls being barewords. With Modern::Perl the strict subs pragma should catch that sort of stuff. So I've really got no idea what's going on. Anyway, the obvious fix is to add "use Koha::ArticleRequest::Status;" to Patron.pm, which is what the patch for this bug is going to do. I just wish I understood why it's a problem in the first place! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25

[Bug 17464] New: Order deny, allow / Deny from all was deprecated in Apache 2.4 and is now a hard error
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '20

15 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 Bug ID: 17464 Summary: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt(a)gmail.com Reporter: bob-ewart(a)bobsown.com QA Contact: testopia(a)bugs.koha-community.org The Allow, Deny and Order directives were deprecated in Apache 2.4 and are no longer recognized. Order deny,allow Deny from all Should be: Require all denied lines 36/37 and 169/170 in koha-httpd.conf should be changed This is in Koha compiled from source and appears in most of the versions I've tried. Also add: <Directory '/usr/share/koha'> Require all granted </Directory> or you will get an 'access forbidden' error If using plugins also add: <Directory '/var/lib/koha'> Require all granted </Directory> -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 23753] New: Background job JavaScript should not try to call humanMsg library
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '20

15 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753 Bug ID: 23753 Summary: Background job JavaScript should not try to call humanMsg library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org While trying to fix Bug 8645 I noticed that background-job-progressbar.js has error-handling code which tries to call the "humanMsg" function which is defined in the "HUMANIZED MESSAGES" plugin humanmsg.js. The plugin is currently loaded on the following pages: admin\preferences.tt cataloguing\editor.tt tools\stage-marc-import.tt Whereas background-job-progressbar.js is used on these pages: offline_circ\process_koc.tt tools\batch_record_modification.tt tools\batchMod-edit.tt tools\manage-marc-import.tt tools\stage-marc-import.tt tools\upload-images.tt The background job error handling doesn't do anything other than return the AJAX error message, so I don't think it's worth it to add the humanmsg plugin everywhere. Better, I think, to change it to an alert. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 21879] New: Code cleaning in printinvoice.pl
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '20

14 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21879 Bug ID: 21879 Summary: Code cleaning in printinvoice.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: kohadevinim(a)devinim.com.tr QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com While working on bug 19489, we realized that some lines are nor necessary anymore, hence we will clean those. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 21

[Bug 18100] New: Pay amount, Pay selected and individual pay behaving differently
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '20

14 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18100 Bug ID: 18100 Summary: Pay amount, Pay selected and individual pay behaving differently Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com This has been tested with the latest 3.22.x and still needs to be confirmed in newer versions of Koha! In the patron account, there are 3 different options for paying a fine. 2 show the payment as positive in green, one as negative in red. To test: 1) Add manual fee of any type 2) Pay using the pay button next to the fine entry (individual) ==> Verify the payment is displayed in red as positive amount 3) Add manual fee of any type 4) Pay using the "Pay selected" button at the bottom ==> Verify the payment is displayed in green as a negative amount 5) Add manual fee of any type 6) Pay using the "Pay amount" button at the bottom ==> Verify the payment is displayed in green as a negative amount Koha itself seems to deal with it somehow, as the sum at the bottom of the table over all payments and fees is always correct. But the difference is also visible in accountlines and can create quite a mess for reporting. One way to work around it currently is using ABS() before calculating with the amounts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 23409] New: Show borrowernotes and opacnote's lines feeds (staff and opac)
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '20

14 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Bug ID: 23409 Summary: Show borrowernotes and opacnote's lines feeds (staff and opac) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: alex.arnaud(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Currently, lines feeds typed in borrowernotes and opacnote are not visible in the interface. Patch is coming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 30

[Bug 19279] New: performance of linked items in search
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '20

13 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279 Bug ID: 19279 Summary: performance of linked items in search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org When catalog has fields 773 (461 in UNIMARC), those linked items are fetched for display in search results. Look like the code could be more performant by replacing item search by $9 with direct call with GetMarcItem(). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 40

[Bug 18488] New: Fines tab on staff client not showing all patron data
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '20

13 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18488 Bug ID: 18488 Summary: Fines tab on staff client not showing all patron data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: jesse(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Created attachment 62625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62625&action=ed… Screen Shot >From the patrons details page on the staff client. Click on fines tab in left column. Default is to the Pay Fines tab - Patron information displays correct under patron image. If you choose the Account, Create manual invoice or Create manual credit you no longer see the patrons Home library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 20788] New: Duplicate system preference EnableAdvancedCatalogingEditor
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '20

13 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20788 Bug ID: 20788 Summary: Duplicate system preference EnableAdvancedCatalogingEditor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: bgkriegel(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org There are duplicate entries of EnableAdvancedCatalogingEditor on source/systempreferences.rst, lines 2072 and 7690 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 19075] New: Improve header line of cash register report
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '20

13 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19075 Bug ID: 19075 Summary: Improve header line of cash register report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When exporting the results of the cash register report as CSV, the columns are currently labelled like this: mfirstname card number firstname branchname date accounttype amount title barcode itype I think it would be a bit nicer, if the columns started with a capital and I would also rename a few of them: mfirstname = Manager name (btw, why only firstname, the screen shows both firstname and surname firstname = Borrower lastname (same as above) branchname = Library date = Transaction date itype = Itemtype -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1