October 2019 - Koha-bugs - lists.koha-community.org

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '19

30 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #43 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 94888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94888&action=ed… Bug 15260: (QA follow-up) Fix updatedatabase message Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '19

30 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #42 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 94887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94887&action=ed… Bug 15260: (follow-up) Fix bug in subtraction prev_open_days can receive either positive or negative numbers and then does the right thing with them. However, we weren't also doing this with the number it receives back from get_push_amt Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '19

30 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #41 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 94886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94886&action=ed… Bug 15260: (follow-up) Fix misnamed variable This was causing the amount to push by to be incorrectly calculated Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '19

30 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #40 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 94885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94885&action=ed… Bug 15260: Fix calculation of add amount In a sequence of closed days, we should take into account the nature of each closed day as we encounter it in order to calculate the amount to add to reach the next potential closed date. We are now doing this. Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '19

30 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #39 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 94884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94884&action=ed… Bug 15260: Add unit tests This patch adds unit tests of the CalcDueDate function to ensure that the useDaysMode "Dayweek" mode works as expected Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '19

30 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #38 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 94883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94883&action=ed… Bug 15260: Implement weekly rollforward This patch will, when appropriate, roll due dates forward by full weeks, rather than single days. Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '19

30 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #37 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 94882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94882&action=ed… Bug 15260: Modify next/prev_open_day We require next_open_day & prev_open_day to be more flexible. We could create a separate sub, but that's not very DRY given that they'll do pretty much the same thing. So next_open_day becomes next_open_days and prev_open_day becomes prev_open_days and both functions accept an additional parameter which determines how many days they add or subtract. All calls of these two functions have been modified accordingly. Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '19

30 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #36 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 94881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94881&action=ed… Bug 15260: Modify description of Dayweek option Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '19

30 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89380|0 |1 is obsolete| | Attachment #89381|0 |1 is obsolete| | Attachment #89382|0 |1 is obsolete| | Attachment #89383|0 |1 is obsolete| | Attachment #89384|0 |1 is obsolete| | Attachment #89385|0 |1 is obsolete| | Attachment #89386|0 |1 is obsolete| | Attachment #89387|0 |1 is obsolete| | Attachment #89388|0 |1 is obsolete| | Attachment #89885|0 |1 is obsolete| | --- Comment #35 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 94880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94880&action=ed… Bug 15260: Add new useDaysMode option "Dayweek" This patch adds a new "Dayweek" option to the useDaysMode syspref, it has the description: "the calendar to push the due date to the next open day on the same weekday". Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '19

30 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0