October 2019 - Koha-bugs - lists.koha-community.org

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '19

29 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #68 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 94853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94853&action=ed… Bug 14697: (QA follow-up) Organize tests in subtests This patch organizes the tests better, and adds some more. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '19

29 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #67 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 94852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94852&action=ed… Bug 14697: Make controller methods rely on the stashed user This patch adjusts the return values and HTTP status codes, as well as removing the use of C4::Context->userenv. It also makes the date calculation happen on the DB engine in the case of resolving the claim. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '19

29 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #66 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 94851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94851&action=ed… Bug 14697: (follow-up) Rely on the UNIQUE constraint and return 409 for issue_id This patch avoids querying the DB for an already existing Koha::Checkouts::ReturnClaim with the same issue_id, now that there's a UNIQUE constraint on it. Also, 409 should be returned instead. Tests added for this changes. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '19

29 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #65 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 94850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94850&action=ed… Bug 14697: Schema updates Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '19

29 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #64 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 94849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94849&action=ed… Bug 14697: Enhance the return claims feature [FIXME] This adds a "Claims returned" feature that extends and enhances the claims returned lost status. To use this feature, a new LOST status to represent an item claimed as returned needs to be created. The value of this LOST authorised value should be set in the new syspref ClaimReturnedLostValue. Setting this system preference turns on the feature. Once the feature is enabled, you should be able to mark checked out items as return claims from the checkout and patron details pages, and also modify them from the new claims tab on those pages. Returning a claimed item will notify the librarian that the item in question has a claim on it. Setting the ClaimReturnedWarningThreshold will add an alert to make librarians aware that this patron has many return claims on the patron's record. Test Plan: 1) Create a "Claims Returned" lost value 2) Create some RETURN_CLAIM_RESOLUTION authorized values 3) Set ClaimReturnedLostValue 4) Set ClaimReturnedChargeFee 5) Set ClaimReturnedWarningThreshold 6) Create some checkouts 7) Claim some returns 8) Verify ClaimReturnedChargeFee works with all 3 options 9) Verify ClaimReturnedWarningThreshold shows a warning once the threshold has been exceeded 10) Edit notes on a claim 11) Resolve a claim 12) Delete a claim Sponsored-by: North Central Regional Library System Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '19

29 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #63 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 94848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94848&action=ed… Bug 14697: Add routes to handle return claims This patch adds the /return_claims route to add new return claims, and then routes to updates notes and the resolution code. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '19

29 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #62 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 94847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94847&action=ed… Bug 14697: Add Koha::Patron->return_claims Adds the ability to get a list of a patron's return claims directly from the Patron object. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '19

29 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #61 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 94846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94846&action=ed… Bug 14697: Add Koha::Checkout->claim_returned Adds the ability to generate a return claim from a Checkout object. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '19

29 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #60 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 94845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94845&action=ed… Bug 14697: Add return claim handling to AddReturn This adds the ability to alert a librarian of an item claimed as returned is actually returned. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '19

29 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #59 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 94844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94844&action=ed… Bug 14697: Introduce Koha::Checkouts::ReturnClaim(s) This patch introduces the Koha::Object(s)-derived classes for handling return claims. Tests are added to cover the overloaded ->store method, and domain-specific exceptions are added as well. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Checkouts/ReturnClaim.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0