October 2019 - Koha-bugs - lists.koha-community.org

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '19

21 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94461|0 |1 is obsolete| | --- Comment #175 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 94468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94468&action=ed… Bug 11879: (follow-up) Corrected OPAC and removed unrelated changes modified: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt modified: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '19

21 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94460|0 |1 is obsolete| | --- Comment #174 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 94467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94467&action=ed… Bug 11879: Remove unecessary code in controller - adds the field required is defined in BorrowerMandatoryField (staff only) - removes code from controller (not needed, we can follow existing pattern) - does not send patron's attribute separately (we have the 'patron' variable already) Need to be done: - same changes for the OPAC - remove extra changes made to moremember-brief.tt (if bugfix it needs to be moved on a separate bug report) - deal with PatronSelfModificationBorrowerUnwantedField and PatronSelfRegistrationBorrowerUnwantedField I first thought it would have replaced AutoEmailPrimaryAddress, but it actually only needed for display purpose, how/where can we explain that? Are release notes enough? Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '19

21 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94459|0 |1 is obsolete| | --- Comment #173 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 94466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94466&action=ed… Bug 11879: Schema updates Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '19

21 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94458|0 |1 is obsolete| | --- Comment #172 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 94465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94465&action=ed… Bug 11879: (QA follow-up) Fix problems found in code review Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '19

21 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94457|0 |1 is obsolete| | --- Comment #171 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 94464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94464&action=ed… Bug 11879: (follow-up) Streamline markup and make label corrections This patch makes minor markup corrections to the patron detail page template: - Simplify the SWITCH markup - Add "primary" to primary phone label - Correct case on label - Add IF statement to hide label if there is no primary contact method Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '19

21 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94456|0 |1 is obsolete| | --- Comment #170 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 94463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94463&action=ed… Bug 11879: Add the "Main contact method" field in borrower informations. This patch adds the "Main Contact Method" field in the borrower modification form. This field is useful for reporting purposes, or to know which contact method to use first when trying to contact a borrower. Following Nicolas' fix, removed a $branch variable from patch, since it has been suppressed in Bug 17284. Test case : * Edit a borrower's informations. The "Main Contact Method" selectbox should appear in the form and its value should be saved correctly. Sponsored-by: CCSR <http://www.ccsr.qc.ca> Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22905] New: Edit suggestions - wrong branchcode behavior
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '19

21 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 Bug ID: 22905 Summary: Edit suggestions - wrong branchcode behavior Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 22368 Target Milestone: --- Because of the "Library" filter on the left of the "Suggestions management" screen, there is something wrong happening: 1. Create a suggestion from library A, login from library B 2. Go to Home › Acquisitions › Suggestions management => The suggestion does not appear - OK 3. In the filter on the left, select "all library" => The suggestion appears on the pending tab - KO 4. Select the suggestion and mark is as 'Accepted' => => The suggestion still appears on the pending tab - Failure The log says: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`suggestions`, CONSTRAINT `suggestions_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) [for Statement "UPDATE `suggestions` SET `accepteddate` = ?, `branchcode` = ?, `currency` = ?, `manageddate` = ?, `price` = ?, `reason` = ?, `suggesteddate` = ?, `total` = ? WHERE ( `suggestionid` = ? )" with ParamValues: 0='2019-05-14T15:48:18', 1="", 2="CAD", 3='2019-05-14T15:48:18', 4="0.00", 5="", 6='2019-05-14T00:00:00', 7="0.00", 8=3] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 [Bug 22368] Table suggestions lacks foreign key constraints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 30

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '19

21 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93901|0 |1 is obsolete| | --- Comment #169 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 94461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94461&action=ed… Bug 11879: (follow-up) Corrected OPAC and removed unrelated changes modified: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt modified: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '19

21 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93855|0 |1 is obsolete| | --- Comment #168 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 94460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94460&action=ed… Bug 11879: Remove unecessary code in controller - adds the field required is defined in BorrowerMandatoryField (staff only) - removes code from controller (not needed, we can follow existing pattern) - does not send patron's attribute separately (we have the 'patron' variable already) Need to be done: - same changes for the OPAC - remove extra changes made to moremember-brief.tt (if bugfix it needs to be moved on a separate bug report) - deal with PatronSelfModificationBorrowerUnwantedField and PatronSelfRegistrationBorrowerUnwantedField I first thought it would have replaced AutoEmailPrimaryAddress, but it actually only needed for display purpose, how/where can we explain that? Are release notes enough? Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '19

21 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93854|0 |1 is obsolete| | --- Comment #167 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 94459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94459&action=ed… Bug 11879: Schema updates Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0