November 2019 - Koha-bugs - lists.koha-community.org

[Bug 23488] New: Line wrapping doesn't always respect word order in Patron card creator
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '20

16 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23488 Bug ID: 23488 Summary: Line wrapping doesn't always respect word order in Patron card creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: maryse.simard(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org In patron card creator, layouts can define up to three lines of text to print to the card. When the text of a line is too long, wrapping will happen. If the wrapped text contains a word that is repeated at least once in the string, the words in the text can be rearranged, the repeated words being grouped together. To reproduce, I use the following text that I put in a card layout : "one two three one two three one two three one two three one two three one two three one two three one two three" I then export some patron cards using this layout. In the resulting file, the words are all out of order : all of the ones appear first, followed by all the twos and only then the threes. The problem is that wrapping happens by finding the last word that can be cut from the string and putting it in a new line. But, when the word is then removed from the original text, only the first occurrence is removed if it appears more than once. The new last word to be removed from the end of the line is the same word again and again until there is none left. We should make sure to remove the word at the end of the line, exactly where we found it to start with. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 22744] New: 'Do not notify' is really a 'Clear' option
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '20

15 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744 Bug ID: 22744 Summary: 'Do not notify' is really a 'Clear' option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- 'Do not notify' in messages sort of hints that messages will be prevented, however, when checked it simply clear the other boxes. Hold notices wil generate print even when nothing is selected, so we shouldn't imply that there is an 'Opt out'/'Do not notify' (see bug 5501 for that) The goal of this bug is to simply rename this option -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 47

[Bug 24131] New: Improved formatting for output of updatedatabase
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '20

15 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 Bug ID: 24131 Summary: Improved formatting for output of updatedatabase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Some updates include more than just the 'Updated to' text.. like Warnings and Notes to run scripts. It would be nice to format these nicely in the webinstaller. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 60

[Bug 21416] New: 'gr' option missing from ZEBRA_LANGUAGE options in koha-sites.conf
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '20

15 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21416 Bug ID: 21416 Summary: 'gr' option missing from ZEBRA_LANGUAGE options in koha-sites.conf Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P3 Component: Searching - Zebra Assignee: koha-bugs(a)lists.koha-community.org Reporter: arouss1980(a)gmail.com Bug 11927 added a Zebra charmap file (sort-string-utf.chr) for Greek language sorting support and also updated the 'koha-create' script to list 'gr' as an available option to the --zebralang argument. However, the main configuration file in /etc/koha/koha-sites.conf (AKA debian/templates/koha-sites.conf in git) does not list 'gr' as an option for the ZEBRA_LANGUAGE variable. I believe 'gr' should be listed among the other language codes, otherwise those who are unaware of Bug 11927 won't know that such support has been added. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 22943] New: The in_ipset syspref name can be confusing.
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '20

15 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22943 Bug ID: 22943 Summary: The in_ipset syspref name can be confusing. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- In bug 14407 we introduced a new system preference to allow limiting the online self checkout system to an IP or IP Range. The preference introduced, however, is called in_ipset which can be confusing (as for those in the know there is a tool in linux called ipset which isn't related to the original bug). We should therefore rename the system preference to in_iprange to more accurately describe it's function. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 28

[Bug 23384] New: Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '20

15 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 Bug ID: 23384 Summary: Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org After spending a while digging into this, I can't explain why it's a problem, but I know that it is and I know how to fix it. During the development of Bug 23112 I encountered a weird problem whereby adding "use Illrequests" to C4/Circulation.pm causes the whole of the app to break with the following error: Bareword "Koha::ArticleRequest::Status::Pending" not allowed while "strict subs" in use at /home/koha-koha/kohaclone/Koha/Patron.pm line 811. Bareword "Koha::ArticleRequest::Status::Processing" not allowed while "strict subs" in use at /home/koha-koha/kohaclone/Koha/Patron.pm line 811. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Illrequest.pm line 37. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Illrequest.pm line 37. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Illrequests.pm line 23. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Illrequests.pm line 23. Compilation failed in require at /home/koha-koha/kohaclone/C4/Circulation.pm line 49. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Circulation.pm line 49. Compilation failed in require at /home/koha-koha/kohaclone/C4/Overdues.pm line 31. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Overdues.pm line 31. Compilation failed in require at /home/koha-koha/kohaclone/C4/Members.pm line 32. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Members.pm line 32. Compilation failed in require at /home/koha-koha/kohaclone/C4/Letters.pm line 30. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Letters.pm line 30. Compilation failed in require at /home/koha-koha/kohaclone/C4/Suggestions.pm line 29. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Suggestions.pm line 29. Compilation failed in require at /home/koha-koha/kohaclone/C4/Acquisition.pm line 25. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Acquisition.pm line 25. Compilation failed in require at /home/koha-koha/kohaclone/C4/Budgets.pm line 27. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Budgets.pm line 27. Compilation failed in require at /home/koha-koha/kohaclone/C4/Biblio.pm line 94. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Biblio.pm line 94. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Biblio.pm line 27. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Biblio.pm line 27. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Biblios.pm line 26. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Biblios.pm line 26. Compilation failed in require at /home/koha-koha/kohaclone/Koha/ArticleRequest.pm line 26. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/ArticleRequest.pm line 26. Compilation failed in require at /home/koha-koha/kohaclone/Koha/ArticleRequests.pm line 26. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/ArticleRequests.pm line 26. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Patrons.pm line 28. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Patrons.pm line 28. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Item.pm line 33. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Item.pm line 33. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Items.pm line 26. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Items.pm line 26. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Checkout.pm line 28. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Checkout.pm line 28. Compilation failed in require at /home/koha-koha/kohaclone/Koha/Checkouts.pm line 25. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/Koha/Checkouts.pm line 25. Compilation failed in require at /home/koha-koha/kohaclone/C4/Auth.pm line 37. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/C4/Auth.pm line 37. Compilation failed in require at /home/koha-koha/kohaclone/admin/preferences.pl line 23. BEGIN failed--compilation aborted at /home/koha-koha/kohaclone/admin/preferences.pl line 23. The reference to "preferences.pl" is a red herring and just reflects the page you're on at the time. The rest of the error is the same regardless of the page. Poking around, I've not been able to determine why the usage of Illrequest in Circulation.pm would cause Patron.pm to suddenly complain about Koha::ArticleRequest::Status::* calls being barewords. With Modern::Perl the strict subs pragma should catch that sort of stuff. So I've really got no idea what's going on. Anyway, the obvious fix is to add "use Koha::ArticleRequest::Status;" to Patron.pm, which is what the patch for this bug is going to do. I just wish I understood why it's a problem in the first place! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25

[Bug 17464] New: Order deny, allow / Deny from all was deprecated in Apache 2.4 and is now a hard error
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '20

14 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 Bug ID: 17464 Summary: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt(a)gmail.com Reporter: bob-ewart(a)bobsown.com QA Contact: testopia(a)bugs.koha-community.org The Allow, Deny and Order directives were deprecated in Apache 2.4 and are no longer recognized. Order deny,allow Deny from all Should be: Require all denied lines 36/37 and 169/170 in koha-httpd.conf should be changed This is in Koha compiled from source and appears in most of the versions I've tried. Also add: <Directory '/usr/share/koha'> Require all granted </Directory> or you will get an 'access forbidden' error If using plugins also add: <Directory '/var/lib/koha'> Require all granted </Directory> -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 23753] New: Background job JavaScript should not try to call humanMsg library
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '20

14 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753 Bug ID: 23753 Summary: Background job JavaScript should not try to call humanMsg library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org While trying to fix Bug 8645 I noticed that background-job-progressbar.js has error-handling code which tries to call the "humanMsg" function which is defined in the "HUMANIZED MESSAGES" plugin humanmsg.js. The plugin is currently loaded on the following pages: admin\preferences.tt cataloguing\editor.tt tools\stage-marc-import.tt Whereas background-job-progressbar.js is used on these pages: offline_circ\process_koc.tt tools\batch_record_modification.tt tools\batchMod-edit.tt tools\manage-marc-import.tt tools\stage-marc-import.tt tools\upload-images.tt The background job error handling doesn't do anything other than return the AJAX error message, so I don't think it's worth it to add the humanmsg plugin everywhere. Better, I think, to change it to an alert. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 21879] New: Code cleaning in printinvoice.pl
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '20

14 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21879 Bug ID: 21879 Summary: Code cleaning in printinvoice.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: kohadevinim(a)devinim.com.tr QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com While working on bug 19489, we realized that some lines are nor necessary anymore, hence we will clean those. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 21

[Bug 24114] New: modules must not warn
by bugzilla-daemon＠bugs.koha-community.org 14 Apr '20

14 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Bug ID: 24114 Summary: modules must not warn Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Bug 21336 introduced warn statements in Koha::Patrons. That should be avoided, the warn must be done in the cronjob script. -- You are receiving this mail because: You are watching all bug changes.

1 32