November 2019 - Koha-bugs - lists.koha-community.org

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '19

27 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93391|0 |1 is obsolete| | --- Comment #104 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 95856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95856&action=ed… Bug 12446: (QA follow-up) QA tests fixing, cleaning code This patch does 3 things : - Remove old code in C4/Utils/DataTables/Members.pm. - Fix the AdditionalGuarantorField dead link for the borrowers table schema. - Remove unused variables so QA tests pass. Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '19

27 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93390|0 |1 is obsolete| | --- Comment #103 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 95855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95855&action=ed… Bug 12446: (follow-up) Show all guarantees on the guarantor detail page Only one guarantee is shown on the guarantor detail page. The guarantees list should be passed to the template as a ref. Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '19

27 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93389|0 |1 is obsolete| | --- Comment #102 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 95854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95854&action=ed… Bug 12446: (QA follow-up) Cleaning, and fixing, old code carried accidentally Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '19

27 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93388|0 |1 is obsolete| | --- Comment #101 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 95853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95853&action=ed… Bug 12446: Enable an adult to have a guarantor Conflicts have been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenarios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional it should have been set by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantee bouton; 3) Validate Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validate Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validate Garantor information/Main address/Contact fieldsets filled; 8) Validate Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantee bouton; 6) Validate Garantor information/Main address/Contact fieldsets filled; 7) Validate Garantor additional alternate address/contact filled; Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24130] New: Update 18.12.00.024 can fail due to bad date data
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '19

27 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24130 Bug ID: 24130 Summary: Update 18.12.00.024 can fail due to bad date data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_suggestedbyFOREIGN KEY (suggestedby) REFERENCESborrowers(borrowernumber) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17646. DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_managedbyFOREIGN KEY (managedby) REFERENCESborrowers(borrowernumber) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17657. DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_acceptedbyFOREIGN KEY (acceptedby) REFERENCESborrowers(borrowernumber) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17669. DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_rejectedbyFOREIGN KEY (rejectedby) REFERENCESborrowers(borrowernumber) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17681. DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_biblionumberFOREIGN KEY (biblionumber) REFERENCESbiblio(biblionumber) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17693. DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_branchcodeFOREIGN KEY (branchcode) REFERENCESbranches(branchcode) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17705. This is undoubtedly due to bad data having been left behind after bug 12627. I think the most pragmatic approach is to just update any such values with a default date far in the past. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7

[Bug 9290] Restricting patron category for online purchase suggestion
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '19

27 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 --- Comment #11 from Vinod <mishravk79(a)gmail.com> --- Hello Is there any update on this development, please? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15497] Limit item types by library
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '19

27 Nov '19

1 0

[Bug 17526] New: OPAC lists require a sortfield
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '19

27 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526 Bug ID: 17526 Summary: OPAC lists require a sortfield Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: gmcharlt(a)gmail.com Reporter: philippe.blouin(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Using the OPAC, going into the public lists, I click one of them and get DBIx::Class::Storage::DBI::_dbh_execute(): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'ASC LIMIT 10) `me` JOIN `biblio` `biblionumber` ON `biblionumber`.`biblionumber' THis is because the sortfield is empty and creates a SQL like GROUP BY ASC LIMIT 10. Missing the group by. In the intranet list, there's a default usage of 'title' that makes it all work. TESTING: 1) just create a public list with no sortfield. - virtualshelves.category = 2 - virtualshelves.sortfield = '' 2) click on the list in the OPAC's public list. Boom! -- You are receiving this mail because: You are watching all bug changes.

1 27

[Bug 13958] Add a suspensionsCalendar syspref
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '19

27 Nov '19

1 0

[Bug 22996] New: Move barcode separators to a preference
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '19

27 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22996 Bug ID: 22996 Summary: Move barcode separators to a preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 30