November 2019 - Koha-bugs - lists.koha-community.org

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 19 Nov '19

19 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured and add/update user
by bugzilla-daemon＠bugs.koha-community.org 19 Nov '19

19 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #15 from Maryse Simard <maryse.simard(a)inlibro.com> --- Thank you very much for testing and for your feedback! I added support for the functionality to other pages where patron search is possible, the list is in the patch description. I also added error handling, showing the error in the user interface if there is a problem when creating the new borrower in Koha. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured and add/update user
by bugzilla-daemon＠bugs.koha-community.org 19 Nov '19

19 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 --- Comment #14 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 95573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95573&action=ed… Bug 11808: (QA follow-up) Adds support for other patron searches This patch add supports to other pages where patron search is possible: patron search, hold and article requests. Removes the code that tried to support searching for search fields other than cardnumber in circulation.pl Catch exception on broken FK contraint if information on the LDAP server can't be added to the database as to not interrupt execution. The error message is shown on the UI. Revised test plan: 0. You need to have an ldap server containing patron informations configured in Koha. 1. Apply patch and update database. 2. Check that the new system preference SearchCardnumberWithLDAP has been added and set as 'never'. 3. Choose a patron who exists in your ldap server but not in Koha. (you can delete an existing patron from Koha if needed) 4. Search for the patron by it's cardnumber in the following locations. Do not choose from the dropdown list, use the submit button. - circ/circulation.pl - circ/article-request.pl - reserve/request.pl - members/member.pl both at the top and in the filter box - any page using common/patron_search.tt, for example adding a guarantor with the members/guarantor_search.pl popup => Should return cardnumber/patron not found or no results 5. Change SearchCardnumberWithLDAP to 'if not found locally'. 6. Repeat step 4. => The patron should be added to Koha. 7. Edit the patron and change any of the existing information. 8. Repeat step 4. => The patron has not been updated (the change made in step 7 is still there) 9. Change SearchCardnumberWithLDAP to 'always'. 10. Repeat step 4. => The patron has been updated. Change made in step 7 has been rewritten and patron informations is the same as in step 6. 11. Try searching for a patron who doesn't exist in Koha and has a nonexistant branch on the LDAP server. An error message should appear accompanying the absence of results. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5016] Basket PDF has several non-translatable issues
by bugzilla-daemon＠bugs.koha-community.org 19 Nov '19

19 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016 --- Comment #4 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Nicole C. Engard from comment #0) > * pdf invoice says “ publié par” instead of “published by” This has been fixed. > * pdf invoice says degree symbol instead of # (as does the basket > grouping) This could be corrected by modifying the .odt files in koha-tmpl/intranet-tmpl/prog/pdf > * pdf invoice says GST instead of tax rate Where does one generate a PDF of an invoice? > * pdf not translatable I don't know if this bug predates the introduction of the OrderPdfFormat preference... It's better than nothing but only expands the options to English, French, and German. Why don't we simply generate a printable view and let the user save as/print to a PDF? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug.

1 0

[Bug 4958] XSLT views in staff client and OPAC don't show multiple URL subfields
by bugzilla-daemon＠bugs.koha-community.org 19 Nov '19

19 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4958 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard <oleonard(a)myacpl.org> --- This appears to be fixed. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3317] Author displays inconsistently ( and incorrectly ) in opac-basket.pl (and when emailing cart )
by bugzilla-daemon＠bugs.koha-community.org 19 Nov '19

19 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3317 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #4 from Owen Leonard <oleonard(a)myacpl.org> --- I believe this issue has been fixed. If someone finds otherwise please re-open with additional details. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 19721] New: Tabulation in the description of a patron category breaks the patron search. Cause : tabs must be escaped in JSON
by bugzilla-daemon＠bugs.koha-community.org 19 Nov '19

19 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19721 Bug ID: 19721 Summary: Tabulation in the description of a patron category breaks the patron search. Cause: tabs must be escaped in JSON Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: victor.grousset(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com === Reproduce === 1. Go to staff: /cgi-bin/koha/admin/categories.pl 2. Edit a category with existing patrons 3. Add a tab in the description here is one to copy for convenience: " " 4. Save the category 5. Go to /cgi-bin/koha/members/members-home.pl 6. Filters → Category → select the just edited one 7. Hit search, just below 8. Then you should see "Processing..." As if the request was still running forever === Cause === In the browser dev tools, we can see that the XRH request to "search" actually comes back. The response seems normal. Except that Firefox warns "SyntaxError: JSON.parse: bad control character in string literal at line 23 column 29 of the JSON data" Which points to our tab. Which invalidates the JSON: https://stackoverflow.com/questions/19799006/unable-to-parse-tab-in-json-fi… > The whitespace characters are: character tabulation (U+0009), line feed (U+000A), carriage return (U+000D), and space (U+0020). > Whitespace is not allowed within any token, except that space is allowed in strings. === Workaround === Remove the tab from the description of the category. In /cgi-bin/koha/admin/categories.pl One can use the filter in the table (called search). And search for a tab " " to get the "corrupted" ones. === Fix === It seems that we should escape the tabs (and CRs(\r) and LFs(\n)) Or just get rid of them. Another question is where? - Where the category form is processed? - early in the upper layers? (when the request just comes) - or in the lower layers? (if the category is managed by the ORM) - In the database itself with a trigger? - Other ideas? === Going further === How to find which other bugs like this one might cause hard to diagnose issues? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 23734] New: Defaults set during patron imports throws warnings
by bugzilla-daemon＠bugs.koha-community.org 19 Nov '19

19 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23734 Bug ID: 23734 Summary: Defaults set during patron imports throws warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To recreate: Create a small import file, with minimal columns, tail the logs, import and note warnings IN DBIX/Class/Row: elsif ($self->_is_column_numeric($col)) { # do a numeric comparison if datatype allows it return $old == $new; But in Koha/Patrons/Import.pm We assume "" for all defaults Even if we pass defaults of '0' for these columns elsif ( $defaults->{$key} ) { won't be triggered by a 0 value, it should be 'exists' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 21465] New: Overlaying with Patron Imports cannot be done if user id and cardnumber are the same.
by bugzilla-daemon＠bugs.koha-community.org 19 Nov '19

19 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465 Bug ID: 21465 Summary: Overlaying with Patron Imports cannot be done if user id and cardnumber are the same. Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org In the Koha version of 18.05 using the patron import tool, if a patron has the same userid and cardnumber, and a library attempts of overlaying an updated file on patron information into Koha, an error will occur. Test Plan 1. Create patron csv according to the download starter CSV in Koha. 2. Patrons were assigned a card number by the library and this card number was also used for their User ID. 3. Import the Patron CSV into Koha. 4. Adjust this same Patron CSV file adding/updating an address, adding/updating a field of data. 5. Use this new file to import into Koha 6 Choose to match on the cardnumber 7. Choose to overwrite the existing one with this file. 8. Koha will produce an error saying that the userid already in use by another patron. Different Scenario Do Steps 1-5 the same 6. Choose to match on the User Id 7. Choose to overwrite the existing one with this file. 8. Koha will do the overwrite correctly. Libraries do tend to give patrons a cardnumber and also use that as the patron's userid. It would appear that matching on the userid works, however, this should not work this way, it should be able to match on either and produce same results- a successful overlay. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 30

[Bug 24005] New: Software error: at login
by bugzilla-daemon＠bugs.koha-community.org 19 Nov '19

19 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24005 Bug ID: 24005 Summary: Software error: at login Change sponsored?: --- Product: Koha Version: 19.05 Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrewanandal(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 95245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95245&action=ed… Error Page Dear all Greetings! I am a new Koha user establishing library system for a non-profit postgraduate educational institution. Nice to meet all developers and thank you for making Koha freely accessible to all globally. Just now I have installed Koha 19.05 on Ubuntu using Ubuntu 18.04.3 LTS terminal, following all the steps in the webinstaller. I attempted logging in using the newly created administrator password. An error message popped up in the subsequent screen: ______________________________________________________________________ Software error: DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha_library.discharges' doesn't exist at /usr/share/koha/lib/Koha/Patron/Discharge.pm line 31 For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. ______________________________________________________________________ Attached is the error screen for your reference. For your information, the MySQL on the Ubuntu 18.04.3 LTS downloaded through Ubuntu terminal using "sudo apt-get mysql-server". Also during installation, I followed all the steps as mentioned on https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages. The patron categories and administrator account were already set up during the webinstall stage. Could anyone give some pointers ahead? Most grateful for all your professional advice! Best Andrew -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7