December 2019 - Koha-bugs - lists.koha-community.org

[Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '19

03 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41033|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 95942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95942&action=ed… Bug 14543: Order lines updated that have a tax rate not in gist will have tax rate set to 0! If the tax rate for a given order line has been removed from the system preference gist, that tax rate will show in the pulldown as 0. If a librarian then saves the order line the original tax rate will be overwritten with 0%! Test Plan: 1) Find an order line 2) Remove the tax rate set for that order line from the syspref gist 3) Edit the order line 4) Note the tax rate is 0 5) Apply this patch 6) Edit the order line 7) Note the tax rate now displays with a warning -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '19

03 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '19

03 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23463 URL| |https://gitlab.com/joubu/Ko | |ha/commits/bug_8132 Assignee|koha-bugs(a)lists.koha-commun |jonathan.druart(a)bugs.koha-c |ity.org |ommunity.org --- Comment #28 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Here is a try to fix this long standing issue. It is based on top of bug 23463. A remote branch is available for testing on my gitlab repop: https://gitlab.com/joubu/Koha/commits/bug_8132 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '19

03 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 95939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95939&action=ed… Bug 8132: Adding message when deleting from the UI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '19

03 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 95938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95938&action=ed… Bug 8132: Delete the items in a transaction and rollback if something wrong The last_item_for_hold case cannot be guessed (easily), and so we are going to delete the items in a transaction. If something wrong happened we rollback and display a list of items that caused the rollback. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '19

03 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #25 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 95937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95937&action=ed… Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion. It takes effect if the hold is found (W or T), to follow existing behavior for item-level holds. If we want to block deletion for any holds we should deal with it on a separate bug report. Test plan: 0/ Setup Create Biblio B1 with 1 item Create Biblio B2 with 2 items Create Biblio B3 with 1+ item Create Biblio B4 with 1+ item Place a biblio-level hold on B1 and B2 Place an item-level hold on B3 Confirm the holds (to mark them waiting) 1/ Use the 5 items and delete them in a batch. => delete of item from B1 is blocked on first screen => delete of items from B2 is *not* blocked on first screen => delete of item from B3 is blocked on first screen => delete of item from B4 is *not* blocked Note that you can only select items from B2 and B4 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process 3/ Remove the biblio-level hold 4/ Repeat 1 => The deletion has been effective! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '19

03 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #24 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 95936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95936&action=ed… Bug 8132: No changes but disable checkboxes When the list of items is displayed we already know if there will be a problem during the deletion. So let's disable the checkbox to tell the user in advance that items cannot be deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '19

03 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '19

03 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #78 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- last patch still doesn't apply anyway... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '19

03 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki(a)biblibre.com Attachment #92774|1 |0 is patch| | Attachment #92774|0 |1 is obsolete| | --- Comment #77 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Comment on attachment 92774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92774 Bug 7376 Transfer limits should be checked at check-in Hi Olivier, Hope if it's ok if I obsolete your patch since Lari has provided a newer version with some correction? That way it makes it easier to test by anyone using sandboxes :) Arthur -- You are receiving this mail because: You are watching all bug changes.

1 0