February 2019 - Koha-bugs - lists.koha-community.org

[Bug 20978] New: Add Koha::Account::add_credit
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '19

22 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Bug ID: 20978 Summary: Add Koha::Account::add_credit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org There's code spread in several controller scripts that directly inserts account lines on the DB, with hardcoded values that only exist on the forms data comes from (mancredit.pl, maninvoice, etc). There should be a high-level function to deal with credits with a simple set of valid values. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 49

[Bug 14825] Accounts Rewrite Omnibus
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '19

22 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21683 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 [Bug 21683] Remove accountlines.accountno -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '19

22 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #18 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Owen Leonard from comment #17) > Is there still a way forward for this bug, assuming its dependencies are > taken care of? I am taking care of the dependencies. This patchset is to big to keep it up-to-date with all the deps. If you want to give it a try you should use Jesse's remote branch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '19

22 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #24 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Josef Moravec from comment #22) > Comment on attachment 85497 [details] [review] > Bug 15400: (followup) Adding age to check out search dropdown > > Review of attachment 85497 [details] [review]: > ----------------------------------------------------------------- > > ::: circ/ysearch.pl > @@ +85,4 @@ > > firstname => $b->firstname // '', > > cardnumber => $b->cardnumber // '', > > dateofbirth => format_sqldatetime($b->dateofbirth, undef, undef, 1) // '', > > + age => $b->get_age // 'Age unknown', > > This is bad, string 'Age unknown' is not translatable When woudl this display? I think if the user has no date of birth, we should just display 'nothing'. Thx Josef for spotting this! I also liked the 'years'. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '19

22 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #23 from Josef Moravec <josef.moravec(a)gmail.com> --- Also, I do not like the 'years' word removed, but that's only my personal opinion -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '19

22 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '19

22 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #22 from Josef Moravec <josef.moravec(a)gmail.com> --- Comment on attachment 85497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85497 Bug 15400: (followup) Adding age to check out search dropdown Review of attachment 85497: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=154…) ----------------------------------------------------------------- ::: circ/ysearch.pl @@ +85,4 @@ > firstname => $b->firstname // '', > cardnumber => $b->cardnumber // '', > dateofbirth => format_sqldatetime($b->dateofbirth, undef, undef, 1) // '', > + age => $b->get_age // 'Age unknown', This is bad, string 'Age unknown' is not translatable -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '19

21 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #21 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 85497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85497&action=ed… Bug 15400: (followup) Adding age to check out search dropdown Confirm age shows in the suggestions dropdown when using the checkout search in header (if user set DOB). Confirm 'Age unknown' shows if no DOB set. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '19

21 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #20 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 85496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85496&action=ed… Bug 15400: (follow-up) Updating text display Now shows as 'Born: [date of birth] (age)' in circ sidebar menu and search results Sponsored-by: Catalyst IT Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '19

21 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #19 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 85495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85495&action=ed… Bug 15400: Display date of birth and age more consistantly Test plan: 0) Apply the patch 1) Go to all of these pages Patron detail Other patron pages - look on the left side (circ-menu) Patron search Guarantor search ( go to child patron -> edit -> in guarantor section click "Set to patron" Search through "Check out" (in the header) 2) Confirm that does show date of birth and date consistantly, try it on patrons with and without date of birth set to find possible reggressions Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0