February 2019 - Koha-bugs - lists.koha-community.org

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85255|0 |1 is obsolete| | --- Comment #15 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 85408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85408&action=ed… Bug 14293: Add more tests and improve get_chargeable_units Not sure at all about this change, especially because it could modify CalcFine Signed-off-by: Arthur Suzuki <arthur.suzuki(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12166] Improve display of Reserve charges in patron account
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18352 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18352 [Bug 18352] Need barcode along with record details in fines section -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85252|0 |1 is obsolete| | --- Comment #14 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 85407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85407&action=ed… Bug 14293: The suspension should be calculated in days There was a mismatch between bug 13909 and bug 5549. The get_chargeable_units call from _debar_user_on_return should specify that we want a suspension in days. However I don't understand the comment let by the author of bug 5549 f61a9617184ec4b24100c1d99150bfd4ebf13336 1/ > finedays is in days, so hourly loans must multiply by 24 Yes but the suspension is in days, so no need to * 24 2/ And we should have a look on this one too: > grace period is measured in the same units as the loan But the grace period is always in days. On the circ rules the column is "Fine grace period (day)". I think we should replace DateTime::Duration->new( $unit => $issuingrule->{firstremind} ); with DateTime::Duration->new( days => $issuingrule->{firstremind} ); Anyway, we definitelly need more tests in this area! Test plan: 1/ Define an issuing rule with a unit=hour 2/ Set a suspension in days 3/ Check an item out and specify a past due date. 4/ Check the item in 5/ The patron should be debarred correctly Signed-off-by: Nick Clemens <nick(a)quecheelibrary.org> Signed-off-by: Arthur Suzuki <arthur.suzuki(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14869] Show barcode instead of itemnumber on fines summary
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14869 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Owen Leonard <oleonard(a)myacpl.org> --- This appears to be fixed now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 7515] authorized value code showing in opac for public note
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 --- Comment #23 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Galen Charlton from comment #22) > > 2) Solve at the .tt level: i.e. use > > Koha::Template::Plugin::KohaAuthorisedValues and patch as we go along at the > > template level. > I prefer this option. This is very easily done, but we don't have a default authorized value category for public note and nonpublic note. Are these defaults we want to add? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #102 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- > > 4) Not really about this patch, but stil trying to see how it all fits > > together: > > NewItemsDefaultLocation referst to the cart_to_shelf cronjob, but I think > > this might be incorrect. > cart_to_shelf stil exists - if you set items to be returned to the cart then > you still need to reset them to original location after they are returned > (or add a rule to move from CART to PERM and check them in again) I know it does still exist :) But I think this pref isn't about the cart? What if I chose 'new item shelf' as my default location? Or PROC. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #101 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Katrin Fischer from comment #99) > 1) This example in the system preference is wrong (appears in a few spots): Updated the description to say 'Processing center' > 2) Missing dot, also: PROC not? CART are always returned to permanent on checkout - proc is only update if included in this pref now (used to be syspref controlled by InProcessingToShelvingCart) kout > 3) Use <b> instead of ** to highlight: Done > 4) Not really about this patch, but stil trying to see how it all fits > together: > NewItemsDefaultLocation referst to the cart_to_shelf cronjob, but I think > this might be incorrect. cart_to_shelf stil exists - if you set items to be returned to the cart then you still need to reset them to original location after they are returned (or add a rule to move from CART to PERM and check them in again) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #100 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 85406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85406&action=ed… Bug 14576: (follow-up) fix some typos and style -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12324] Hard coded fine codes
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12324 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Owen Leonard <oleonard(a)myacpl.org> --- I believe Bug 12166 fixes this *** This bug has been marked as a duplicate of bug 12166 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12166] Improve display of Reserve charges in patron account
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon(a)cdalibrary.org --- Comment #4 from Owen Leonard <oleonard(a)myacpl.org> --- *** Bug 12324 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0