February 2019 - Koha-bugs - lists.koha-community.org

[Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 --- Comment #18 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 85363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85363&action=ed… Bug 17746: (QA follow-up) Make set_password.pl generate a password if required This patch makes the set_password.pl script generate the password if it is not passed as an argument. It also changes the behaviour of set_password.pl: it will now print the userid and password (generated or not) to mimick the behaviour from koha-reset-passwd. The koha-reset-passwd gets simplified as it doesn't generate the random password anymore, it passes the responsability to set_password.pl To test: - Follow the steps from the original platch - Verify all behaves as expected Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12318] Show subscription shelving location on subscription tabs
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12318 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Nice little enhancement, no regressions of qa script failures.. Passing QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12318] Show subscription shelving location on subscription tabs
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12318 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84895|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 85362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85362&action=ed… Bug 12318: Show shelving location on subscription tab in OPAC and staff The shelving location can be helpful to locate an item in the library. Especially, if the library has decided not to create items for a subscription this information is currently not visible to the patron. To test: - Apply patch - Create a subscription, set location - View the subscription tab in detail and staff - Verify that the location now shows above the callnumber - Unset location in the subscription - Verify that the page still looks ok Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois(a)inLibro.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12318] Show subscription shelving location on subscription tabs
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12318 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia(a)bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22376] New: Using the Checkin Box from Circulation.pl, refund of lost items does not happen
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22376 Bug ID: 22376 Summary: Using the Checkin Box from Circulation.pl, refund of lost items does not happen Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- If a library chooses to display the check-in box from the patron's circulation page, an item that gets returned via this check-in box, and that item was LOST will not get a refund- if the library is choosing to give refunds to lost items. It would appear that this by-passes the refund process by using the check-in box from the circulation.pl page. Steps to recreate: 1. The patron was charged replacement price of an item and the item is LOSt and still on their account. 2. Patron returns the book, however, instead of using the return.pl page, the staff use the check-in box on the circulation.pl page of the patron. 3. This returns the book but does not give the refund to the patron (although the library has chosen to refund lost fees. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 11969] Show patrons star rating on their reading history
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82749|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 85354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85354&action=ed… Bug 11969: Show patrons star rating on their reading history This patch adds display of a user's ratings to their reading history in the OPAC. Also changed: Removed obsolete "border" attribute from the template. To test, apply the patch and rebuild the OPAC CSS. OpacStarRatings should be enabled. - Log in to the OPAC as a user with a reading history and titles in that history which have ratings. - Under the "your reading history" tab, your ratings should show under rated titles with the date of the rating. - Test also with OpacStarRatings disabled. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11375] Improve patrons permissions display
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #26 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 85352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85352&action=ed… Bug 11375: (follow-up) Add links to show all/hide all This patch adds links in the toolbar to show or hide all sub-permissions. To test, apply the patch and view the permissions page for a patron. Clicking the "Show all" or "Hide all" links should work to show or hide all sub-permissions. The corresponding "Show details" and "Hide details" links for each permission set should be correctly toggled. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11375] Improve patrons permissions display
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84701|0 |1 is obsolete| | Attachment #84702|0 |1 is obsolete| | --- Comment #25 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 85351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85351&action=ed… Bug 11375: Improve patrons permissions display This patch updates the patron permissions interface in order to emphasize permission descriptions (which can be translated) over permission code (which cannot). The tree structure (and jQuery plugin) is removed, and permissions are displayed in a table-like way. Sub-permissions are shown or hidden with a link. A free-text filter is added to the top for narrowing the list by keyword. Save and cancel buttons are now in a floating toolbar. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. - Open the "Set permissions" page for any patron. - Confirm that the filter works correctly to show only lines which match your entry - Note that the superlibrarian line stays visible all the time. This is to make it clearer that sub-permissions cannot be selected if superlibrarian is checked. - Check the superlibrarain "hint" text for clarity. - Test the show/hide controls. - Test that checking a "parent" permission displays the sub-permissions. - Test that the toolbar with Save and Cancel floats when scrolling. - Test that changing and saving permissions works correctly. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11375] Improve patrons permissions display
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15505] Mark Hold Items 'On hold' instead of 'Available'
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83643|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 85349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85349&action=ed… Bug 15505 - Mark Hold Items 'On hold' instead of 'Available' This patch adds a 'pending hold' column to C4::Items:GetItemsInfo to allow for displaying status of an item when it has been selected for a hold by the holdsqueue and AllowItemsOnHoldCheckout is set to 'Don't allow' To test: 00 - Set AllowItemsOnHoldCheckout to 'Allow' 01 - Place a hold on an item 02 - Build the holdsqueue (kohadevbox example below) sudo koha-shell kohadev perl misc/cronjobs/holds/build_holds_queue.pl 03 - Search for the item on the OPAC 04 - Note item shows as 'Available' in results and details 05 - Toggle AllowItemsOnHOldCheckout to 'Don't allow' 06 - Repeat search, note there is no change 06 - Apply Patch 07 - Search for the item on the OPAC 08 - Note that item now shows as 'Pending hold' 09 - Toggle AllowItemsOnHoldCheckout to Allow 10 - Note item shows as available 11 - prove -v t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes.

1 0