February 2019 - Koha-bugs - lists.koha-community.org

[Bug 13515] Table messages is missing FK constraints and is never cleaned up
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83509|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 85155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85155&action=ed… Bug 13515: Add a foreign key constraint to messages.borrowernumber This patch adds a missing foreign key constraint to mesages.borrowernumber. To create it sucessfully the entries from the messages table that are not linked with an existing patron will be removed. Test plan: 0/ Do not apply the patch 1/ Add messages to different patrons 2/ Delete one of the patron's record 3/ Have a look at the messages table and notice that the messages for the deleted patron's record still appear 4/ Apply the patch and execute the update DB entry 5/ Have a look again at the messages table and notice that the messages for the deleted patron's record have been removed 6/ Delete a patron that have messages 7/ Notice that now the messages are deleted when the patron's record is deleted Signed-off-by: Nazlı Çetin <nazli(a)devinim.com.tr> Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13515] Table messages is missing FK constraints and is never cleaned up
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #257 from Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> --- Tested again, and the functionality works perfectly. As far as I can tell all the stylings are now correct. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84322|0 |1 is obsolete| | --- Comment #256 from Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> --- Created attachment 85152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85152&action=ed… Bug 10662: (follow-up) Template corrections and improvements This patch makes a number of corrections and improvements to the OAI harvester templates: - Add missing DataTables CSS include - Replace YUI grid with Bootstrap - Correct style of inline dialogs (.dialog.alert, .dialog.message) - Correct class of form hint and error messages - Format dates in saved and submitted requests tables - Add title-string sorting to DataTables configuration - Add delete confirmation to saved and submitted tables - Disable sorting on action columns - Style action links inside tables as buttons - Removed commented markup - Add missing JavaScript include (tools-menu.js) to highlight active section in sidebar menu - Add CodeMirror styling to record view page (CodeMirror XML mode file is added to enable this) - Remove invalid <script> "type" attribute To test, apply the patch and clear your cache if necessary. - Go to Tools -> OAI-PMH harvester - "Saved," "Submitted," and "Import history" table should look correct and work correctly: Sorting, column visibility, pagination, etc. - In the "Saved" and "Submitted" tables, dates should be formatted according to the dateformat preference and sorting of these dates should work correctly. - In the "Import history" table the "View record" and "View in catalog" links should be styled as Bootstrap buttons. - Click the "View record" button. - The view of the downloaded record should have XML syntax highlighting. - When you perform actions like submitting requests, starting requests, etc, corresponding dialogs should be styled correctly. Informational/successful information should be "message" style dialogs. Error dialogs should be "alert" style. - Click "New request" - Form hints in the new request form should be styled correctly. - Submit the form without filling in any fields. Field-specific error messages should be styled italic red. Signed-off-by: David Cook <dcook(a)prosentient.com.au> Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19701] New: Modify patron loses password in Microsoft Edge
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19701 Bug ID: 19701 Summary: Modify patron loses password in Microsoft Edge Change sponsored?: --- Product: Koha Version: 16.05 Hardware: PC OS: Windows Status: NEW Severity: minor Priority: P5 - low Component: Browser compatibility Assignee: oleonard(a)myacpl.org Reporter: emma.perks(a)heartofengland.nhs.uk QA Contact: testopia(a)bugs.koha-community.org In Microsoft Edge editing a patron record takes away the password and you have to add it back in before you can save the record. -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 12488] Make bulkmarcimport.pl -d use DELETE instead of TRUNCATE
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488 --- Comment #18 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #17) > @RM: We still keep: > $dbh->do("truncate auth_header"); > $dbh->do("truncate zebraqueue"); The lowercase here is bad here imo btw. Harder to locate.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12488] Make bulkmarcimport.pl -d use DELETE instead of TRUNCATE
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488 --- Comment #17 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- @RM: We still keep: $dbh->do("truncate auth_header"); $dbh->do("truncate zebraqueue"); -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12488] Make bulkmarcimport.pl -d use DELETE instead of TRUNCATE
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | Assignee|gmcharlt(a)gmail.com |magnus(a)libriotech.no CC| |m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12488] Make bulkmarcimport.pl -d use DELETE instead of TRUNCATE
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84963|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 85148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85148&action=ed… Bug 12488: Make bulkmarcimport.pl -d use DELETE instead of TRUNCATE On MySQL >= 5.5 bulkmarcimport.pl with the -d (delete) switch gives an error like "Cannot truncate a table referenced in a foreign key constraint". This patch proposes to replace the offending TRUNCATE with DELETE. Auto incerement counters are reset to 1 to preserve the functionality from TRUNCATE. To test: - Make sure you havae a test database with some records and items - Run bulkmarcimport.pl with the -d switch - Observe the error described above - Apply this patch - Run bulkmarcimport.pl with the -d switch again - Observe the lack of an error - Verify that the newly imported records and items have biblionumber and itemnumbers starting with 1 Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0