February 2019 - Koha-bugs - lists.koha-community.org

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '19

14 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 --- Comment #15 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 85104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85104&action=ed… Bug 3820: (follow-up) Clean up warnings -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '19

14 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85102|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 85103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85103&action=ed… Bug 3820: Add changes to MEMBERS MODIFY logaction This patch attemps to add a more refined and detailed info structure detailing what fields were changed and what they were changed from and to. Test Plan: Enable BorrowersLog in the system preferences and undertake a series of borrower detail changes. Go to view the actionlogs and note that MEMBER MODIFY logs now detail what fields you have changed using the following form: { FIELD1: { before: BEFORE_VALUE, after: AFTER_VALUE } } -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 22336] New: Better conversion from illrequestattributes to HTML attributes
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '19

14 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22336 Bug ID: 22336 Summary: Better conversion from illrequestattributes to HTML attributes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no Target Milestone: --- The illrequestattributes table can hold any kind of attribute for an ILL request. Which attributes are displayed in the ILL detail view (both OPAC and Intranet) are determined by the per backend "metadata" sub, which can also assign labels to each attribute. So if you have an attribute called "lending_library" with a value of "LibraryX", you can call it "Lending library" and make it display as: Lending library: LibraryX To make things stylable the label of the attribute is turned into an HTML ID or class. In the OPAC: <div class="requestattr-Lending library"><span class="label">Lending library:</span>LibraryX</div> In the staff client: <li class="requestmeta-Lending_library"><span class="label">Lending library:</span>LibraryX</li> We should be a bit more careful about how we use the labels in HTML attributes: - Avoid spaces and other illegal characters (ISBN/ISSN is currently turned into "requestmeta-ISBN/ISSN") - Maybe lowercase it? - Be consistent between OPAC and staff client Perhaps it would be an alternative to just use the attribute name from the database? ("requestmeta-lending_library" in this example) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '19

14 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton(a)bywatersolutions.com | |, | |kyle(a)bywatersolutions.com, | |nick(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '19

14 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 --- Comment #13 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Changed fields will be listed in canonical order now. Any opinions on 'before/after' vs 'from/to'.. if we switch to 'from/to' we get them in that order for free with the canonicalisation switch.. with 'before/after' we will get 'after' coming before 'before' in the output wherever the raw json is shown as obviously 'a' comes before 'b' in the alphabet ;) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '19

14 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85100|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 85102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85102&action=ed… Bug 3820: Add changes to MEMBERS MODIFY logaction This patch attemps to add a more refined and detailed info structure detailing what fields were changed and what they were changed from and to. Test Plan: Enable BorrowersLog in the system preferences and undertake a series of borrower detail changes. Go to view the actionlogs and note that MEMBER MODIFY logs now detail what fields you have changed using the following form: { FIELD1: { before: BEFORE_VALUE, after: AFTER_VALUE } } -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '19

14 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs(a)lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '19

14 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '19

14 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '19

14 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 --- Comment #11 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 85100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85100&action=ed… Bug 3820: Add changes to MEMBERS MODIFY logaction This patch attemps to add a more refined and detailed info structure detailing what fields were changed and what they were changed from and to. Test Plan: Enable BorrowersLog in the system preferences and undertake a series of borrower detail changes. Go to view the actionlogs and note that MEMBER MODIFY logs now detail what fields you have changed using the following form: { FIELD1: { before: BEFORE_VALUE, after: AFTER_VALUE } } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug.

1 0