March 2019 - Koha-bugs - lists.koha-community.org

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #29 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6473] Test bug for Git-bz
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86645|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6473] Test bug for Git-bz
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #222 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 86645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86645&action=ed… Bug 18736: Calculate tax depending on rounding Marcel's comments pointed out that while I tried to avoid storing rounded values it is required for tax generation. This patch makes that change and adds test coverage and POD for populate_order_with_prices To test: Follow plan on other patches, ensure that orders and totals match on the basket, invoice, and budget pages prove -v t/db_dependent/Acquisition/populate_order_with_prices.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6473] Test bug for Git-bz
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86644|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6473] Test bug for Git-bz
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #221 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 86644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86644&action=ed… Bug 18736: Calculate tax depending on rounding Marcel's comments pointed out that while I tried to avoid storing rounded values it is required for tax generation. This patch makes that change and adds test coverage and POD for populate_order_with_prices To test: Follow plan on other patches, ensure that orders and totals match on the basket, invoice, and budget pages prove -v t/db_dependent/Acquisition/populate_order_with_prices.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14825] Accounts Rewrite Omnibus
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Janet McGowan <janet.mcgowan(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan(a)ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #28 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86643&action=ed… Bug 14591: (QA follow-up) Fix AddReturn call in Circulation/issue.t Test plan: prove t/db_dependent/Circulation/issue.t Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #27 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86642&action=ed… Bug 14591: (QA follow-up) Optimize DateTime passing We were passing around possibly undefined $return_date variables from AddReturn and then instantiating a new DateTime object as a default for each routine. This followup sets the default higher up the stack within AddReturn which provider clearer logic and a small performance improvment. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #26 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86641&action=ed… Bug 14591: Update unit tests Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #25 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86640&action=ed… Bug 14591: Update other calls to AddReturn Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0