March 2019 - Koha-bugs - lists.koha-community.org

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #21 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I really like this solution! It tidies up the code significantly and corrects the logic considerably! Signing off as it all works in testing as described... Some QA comments for the next in line however. * Can we/Should we remove the 'lastincrement' field here as I believe this was the only use case for it? * The logic here puts 'dropboxmode/dropboxdate' in precidence to any specified return date.. I think we perhaps need a bit more in this regard, but perhaps that can be done within bug 13044 as there's a fair bit of contextual conversation over there around this issue. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #20 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 86621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86621&action=ed… Bug 14591: (QA follow-up) Optimize DateTime passing We were passing around possibly undefined $return_date variables from AddReturn and then instantiating a new DateTime object as a default for each routine. This followup sets the default higher up the stack within AddReturn which provider clearer logic and a small performance improvment. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86616|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 86620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86620&action=ed… Bug 14591: Update unit tests Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86615|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 86619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86619&action=ed… Bug 14591: Update other calls to AddReturn Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86614|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 86618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86618&action=ed… Bug 14591: book drop / drop box mode incorrectly decrements accrued overdue fines Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #16 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 86616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86616&action=ed… Bug 14591: Update unit tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #15 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 86615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86615&action=ed… Bug 14591: Update other calls to AddReturn -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86611|0 |1 is obsolete| | Attachment #86612|0 |1 is obsolete| | Attachment #86613|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 86614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86614&action=ed… Bug 14591: book drop / drop box mode incorrectly decrements accrued overdue fines -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #13 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 86613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86613&action=ed… Bug 14591: Update unit tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #12 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 86612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86612&action=ed… Bug 14591: Update other calls to AddReturn -- You are receiving this mail because: You are watching all bug changes.

1 0