March 2019 - Koha-bugs - lists.koha-community.org

[Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '19

13 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86563|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '19

13 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86564|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 86566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86566&action=ed… Bug 10577: (QA follow-up) Remove bad call signature Whilst working through this patch for signoff I found a case where the calling signature of GetBudgetPeriod was incorrect. I removed the superflous passed parameter in this followup Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '19

13 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 --- Comment #8 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 86565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86565&action=ed… Bug 10577: Improve semantics of GetBudgetPeriod() Remove the option to pass zero to this function in order to get "the" active budget. This was a problem in three ways: - Koha doesn't require that there be only one active budget at a time, so the concept of "the" active budget doesn't make sense. - Having the single parameter be either an ID or a flag based on its value is poor function design. - No callers of GetBudgetPeriod() were actually using this modality. This patch also improves the DB-dependent tests for budgets by - wrapping the test in a transaction - counting budgets correctly To test: [1] Apply the patch. [2] Verify that prove -v t/db_dependent/Budgets.t passes [3] Verify in the staff interface that: - the budget hierarchy displays correctly - you can add and modify a budget Signed-off-by: Galen Charlton <gmc(a)esilibrary.com> Rescued-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '19

13 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs(a)lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '19

13 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Patch rescued and tested.. Signing off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '19

13 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 --- Comment #6 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 86564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86564&action=ed… Bug 10577: (QA follow-up) Remove bad call signature Whilst working through this patch for signoff I found a case where the calling signature of GetBudgetPeriod was incorrect. I removed the superflous passed parameter in this followup Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '19

13 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19578|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 86563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86563&action=ed… bug 10577: improve semantics of GetBudgetPeriod() Remove the option to pass zero to this function in order to get "the" active budget. This was a problem in three ways: - Koha doesn't require that there be only one active budget at a time, so the concept of "the" active budget doesn't make sense. - Having the single parameter be either an ID or a flag based on its value is poor function design. - No callers of GetBudgetPeriod() were actually using this modality. This patch also improves the DB-dependent tests for budgets by - wrapping the test in a transaction - counting budgets correctly To test: [1] Apply the patch. [2] Verify that prove -v t/db_dependent/Budgets.t passes [3] Verify in the staff interface that: - the budget hierarchy displays correctly - you can add and modify a budget Signed-off-by: Galen Charlton <gmc(a)esilibrary.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '19

13 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|In Discussion |Needs Signoff --- Comment #4 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- This is still the case but I think the issue with it that Katrin found was resolved in bug 11578, setting back to NSO -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 22485] New: Add randomly generated password suggestion to add/modify patron form
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '19

13 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22485 Bug ID: 22485 Summary: Add randomly generated password suggestion to add/modify patron form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: emma.perks(a)heartofengland.nhs.uk QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- We would like to add the randomly generated password feature from member-password.tt to the OPAC/Staff login section on memberentry.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 9821] Zebra indexes useless subfields in UNIMARC 5XX
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '19

13 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9821 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I think we can safely kill this one off.. it's not been looked at for 5 years! -- You are receiving this mail because: You are watching all bug changes.

1 0